[Bro-Dev] [JIRA] (BIT-1072) merge topic/bernhard/hyperloglog
[ https://bro-tracker.atlassian.net/browse/BIT-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13819#comment-13819 ] Robin Sommer commented on BIT-1072: --- I ended up refactoring and reformatting this quite a bit, it's in topic/robin/hyperlolog-merge. However, I broke something, the tests aren't working. Need to debug that later. In the meantime, some requests/questions: - Please look over my changes and see if they make sense. (You don't need to track down the bug; I take the blame for that :). - Can you please rework the Doxygen comments in HyperLogLog.h so that the descriptions for the public methods are understandable on their own. Right now I can't really follow them as often they talk about internal parameters/functionality. What you could do is provide a short overview of the data structure parameters in the class' doc string, and then refer to that in the methods. Also, please use the @param and @return syntax. (Start from my branch with this: I already reformatted and reordered things there quite a bit.) - I don't understand what can be parameterized by the user and what not (and why not). One can give an error margin to the actor, but the confidence is a compile time constant. Also, where are the magic alpha_m values in *.cc coming from? Are these indeed always static values that don't depend on any parameters? > merge topic/bernhard/hyperloglog > > > Key: BIT-1072 > URL: https://bro-tracker.atlassian.net/browse/BIT-1072 > Project: Bro Issue Tracker > Issue Type: New Feature > Components: Bro >Affects Versions: git/master >Reporter: Bernhard Amann > Fix For: 2.2 > > Attachments: out.pdf > > > The branch adds support for the hyperloglog data structure. > In the branch, core/leaks/basic-cluster.bro currently faisl. However, this > seems to be unrelated to hll and just to be triggered by the addition of it > to the sumstats tests. It looks like some kind of scriptland issue. pprof > output is attached. (master, workers don't leak memory) -- This message was sent by Atlassian JIRA (v6.1-OD-06#6139) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1071) Initializing an opaqueval as a global segfaults Bro
[
https://bro-tracker.atlassian.net/browse/BIT-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jon Siwek updated BIT-1071:
---
Resolution: Fixed
Status: Closed (was: Open)
> Initializing an opaqueval as a global segfaults Bro
> ---
>
> Key: BIT-1071
> URL: https://bro-tracker.atlassian.net/browse/BIT-1071
> Project: Bro Issue Tracker
> Issue Type: Problem
> Components: Bro
>Affects Versions: git/master
>Reporter: Bernhard Amann
> Fix For: 2.2
>
>
> Running Bro with a file containing
> {quote}
> global test = md5_hash_init();
> {quote}
> crashes Bro and results in the following backtrace:
> {quote}
> #0 0x08259e95 in Ref (o=0x0) at /home/bernhard/bro/src/Obj.h:205
> #1 0x0825a037 in BroType::Ref (this=0x0) at /home/bernhard/bro/src/Type.h:225
> #2 0x0825a35b in Val::Val (this=0x87c7580, t=0x0) at
> /home/bernhard/bro/src/Val.h:387
> #3 0x08377d46 in OpaqueVal::OpaqueVal (this=0x87c7580, t=0x0) at
> /home/bernhard/bro/src/Val.cc:3133
> #4 0x0830b6a8 in HashVal::HashVal (this=0x87c7580, t=0x0) at
> /home/bernhard/bro/src/OpaqueVal.cc:62
> #5 0x0830b8bd in MD5Val::MD5Val (this=0x87c7580) at
> /home/bernhard/bro/src/OpaqueVal.cc:81
> #6 0x082d68aa in BifFunc::bro_md5_hash_init (frame=0x0, BiF_ARGS=0x93db520)
> at bro.bif:631
> #7 0x082d4df1 in BuiltinFunc::Call (this=0x8b57e40, args=0x93db520,
> parent=0x0) at /home/bernhard/bro/src/Func.cc:507
> #8 0x082c76a6 in CallExpr::Eval (this=0x93e4300, f=0x0) at
> /home/bernhard/bro/src/Expr.cc:4827
> #9 0x082b438b in Expr::InitVal (this=0x93e4300, t=0x897c740, aggr=0x0) at
> /home/bernhard/bro/src/Expr.cc:130
> #10 0x0837a4de in init_val (init=0x93e4300, t=0x897c740, aggr=0x0) at
> /home/bernhard/bro/src/Var.cc:17
> #11 0x0837abc5 in make_var (id=0x93d0c30, t=0x897c740, c=INIT_FULL,
> init=0x93e4300, attr=0x0, dt=VAR_REGULAR, do_init=1) at
> /home/bernhard/bro/src/Var.cc:188
> #12 0x0837adc5 in add_global (id=0x93d0c30, t=0x0, c=INIT_FULL,
> init=0x93e4300, attr=0x0, dt=VAR_REGULAR) at /home/bernhard/bro/src/Var.cc:226
> #13 0x08255c0c in yyparse () at parse.y:1068
> #14 0x08268da1 in main (argc=2, argv=0xb624) at
> /home/bernhard/bro/src/main.cc:859
> {quote}
> Seems to work for any opaque val.
--
This message was sent by Atlassian JIRA
(v6.1-OD-06#6139)
___
bro-dev mailing list
bro-dev@bro.org
http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1072) merge topic/bernhard/hyperloglog
[ https://bro-tracker.atlassian.net/browse/BIT-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robin Sommer updated BIT-1072: -- Status: Open (was: Merge Request) > merge topic/bernhard/hyperloglog > > > Key: BIT-1072 > URL: https://bro-tracker.atlassian.net/browse/BIT-1072 > Project: Bro Issue Tracker > Issue Type: New Feature > Components: Bro >Affects Versions: git/master >Reporter: Bernhard Amann > Fix For: 2.2 > > Attachments: out.pdf > > > The branch adds support for the hyperloglog data structure. > In the branch, core/leaks/basic-cluster.bro currently faisl. However, this > seems to be unrelated to hll and just to be triggered by the addition of it > to the sumstats tests. It looks like some kind of scriptland issue. pprof > output is attached. (master, workers don't leak memory) -- This message was sent by Atlassian JIRA (v6.1-OD-06#6139) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1072) merge topic/bernhard/hyperloglog
[ https://bro-tracker.atlassian.net/browse/BIT-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13817#comment-13817 ] Robin Sommer commented on BIT-1072: --- I'm getting a number of conflicts when merging into master. Please merge the branch with master first. > merge topic/bernhard/hyperloglog > > > Key: BIT-1072 > URL: https://bro-tracker.atlassian.net/browse/BIT-1072 > Project: Bro Issue Tracker > Issue Type: New Feature > Components: Bro >Affects Versions: git/master >Reporter: Bernhard Amann > Fix For: 2.2 > > Attachments: out.pdf > > > The branch adds support for the hyperloglog data structure. > In the branch, core/leaks/basic-cluster.bro currently faisl. However, this > seems to be unrelated to hll and just to be triggered by the addition of it > to the sumstats tests. It looks like some kind of scriptland issue. pprof > output is attached. (master, workers don't leak memory) -- This message was sent by Atlassian JIRA (v6.1-OD-06#6139) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1072) merge topic/bernhard/hyperloglog
[ https://bro-tracker.atlassian.net/browse/BIT-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bernhard Amann updated BIT-1072: Status: Merge Request (was: Open) > merge topic/bernhard/hyperloglog > > > Key: BIT-1072 > URL: https://bro-tracker.atlassian.net/browse/BIT-1072 > Project: Bro Issue Tracker > Issue Type: New Feature > Components: Bro >Affects Versions: git/master >Reporter: Bernhard Amann > Fix For: 2.2 > > Attachments: out.pdf > > > The branch adds support for the hyperloglog data structure. > In the branch, core/leaks/basic-cluster.bro currently faisl. However, this > seems to be unrelated to hll and just to be triggered by the addition of it > to the sumstats tests. It looks like some kind of scriptland issue. pprof > output is attached. (master, workers don't leak memory) -- This message was sent by Atlassian JIRA (v6.1-OD-06#6139) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1072) merge topic/bernhard/hyperloglog
[ https://bro-tracker.atlassian.net/browse/BIT-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robin Sommer updated BIT-1072: -- Status: Open (was: Merge Request) > merge topic/bernhard/hyperloglog > > > Key: BIT-1072 > URL: https://bro-tracker.atlassian.net/browse/BIT-1072 > Project: Bro Issue Tracker > Issue Type: New Feature > Components: Bro >Affects Versions: git/master >Reporter: Bernhard Amann > Fix For: 2.2 > > Attachments: out.pdf > > > The branch adds support for the hyperloglog data structure. > In the branch, core/leaks/basic-cluster.bro currently faisl. However, this > seems to be unrelated to hll and just to be triggered by the addition of it > to the sumstats tests. It looks like some kind of scriptland issue. pprof > output is attached. (master, workers don't leak memory) -- This message was sent by Atlassian JIRA (v6.1-OD-06#6139) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1072) merge topic/bernhard/hyperloglog
[ https://bro-tracker.atlassian.net/browse/BIT-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13818#comment-13818 ] Bernhard Amann commented on BIT-1072: - Sorry - re-merged master > merge topic/bernhard/hyperloglog > > > Key: BIT-1072 > URL: https://bro-tracker.atlassian.net/browse/BIT-1072 > Project: Bro Issue Tracker > Issue Type: New Feature > Components: Bro >Affects Versions: git/master >Reporter: Bernhard Amann > Fix For: 2.2 > > Attachments: out.pdf > > > The branch adds support for the hyperloglog data structure. > In the branch, core/leaks/basic-cluster.bro currently faisl. However, this > seems to be unrelated to hll and just to be triggered by the addition of it > to the sumstats tests. It looks like some kind of scriptland issue. pprof > output is attached. (master, workers don't leak memory) -- This message was sent by Atlassian JIRA (v6.1-OD-06#6139) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [Auto] Merge Status
Open Merge Requests === IDComponentReporterAssigneeUpdated For Version PrioritySummary --- -- -- -- - -- BIT-1072 [1] Bro Bernhard Amann - 2013-08-29 2.2 Normal merge topic/bernhard/hyperloglog Open Fastpath Commits == Commit ComponentAuthor DateSummary --- --- - -- -- dc2e3d6 [2] bro Jon Siwek 2013-08-29 Fix global opaque val segfault, addresses BIT-1071 742a047 [3] bro Jon Siwek 2013-08-29 Fix malloc/delete mismatch. c4e8908 [4] bro Jon Siwek 2013-08-29 Fix invalid pointer dereference in AsciiFormatter. Open GitHub Pull Requests = IssueComponentUser Updated Title --- --- - -- -- #1 [5] broccoli dcode [6] 2013-08-12 Updated specfile. Works under mock for EL6 [7] [1] BIT-1072 https://bro-tracker.atlassian.net/browse/BIT-1072 [2] dc2e3d6 https://github.com/bro/bro/commit/dc2e3d6e04ad7504989b0b377f3c2f6cb9e1a2ef [3] 742a047 https://github.com/bro/bro/commit/742a047a40e6eeb32aea9ededf6bd294d5263ff8 [4] c4e8908 https://github.com/bro/bro/commit/c4e8908c8e267c1e93fd7fa0c9df22f474ec47f3 [5] Pull Request #1 https://github.com/bro/broccoli/issues/1 [6] dcode https://github.com/dcode [7] Merge Pull Request #1 with git pull https://github.com/dcode/broccoli.git master ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
