[Bro-Dev] [Auto] Merge Status
Open Merge Requests === IDComponentReporter AssigneeUpdated For Version PrioritySummary --- - -- -- - -- --- BIT-1087 [1] BroControl Daniel Thayer - 2013-10-092.2 Normal topic/dnthayer/broctl-fixes [2] Open Fastpath Commits == Commit ComponentAuthor DateSummary --- --- -- -- --- 00b622f [3] bro Bernhard Amann 2013-10-08 IANA assigned a couple of new tls extension numbers 737b15a [4] bro Bernhard Amann 2013-10-08 add 3 more really new ciphers. [1] BIT-1087 https://bro-tracker.atlassian.net/browse/BIT-1087 [2] broctl-fixes https://github.com/bro/brocontrol/tree/topic/dnthayer/broctl-fixes [3] 00b622f https://github.com/bro/bro/commit/00b622f54d4fbe0fbf750933c8da559a21f2c2a7 [4] 737b15a https://github.com/bro/bro/commit/737b15aef9f36b3860d4890087980b27de6baab1 ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1087) topic/dnthayer/broctl-fixes
[ https://bro-tracker.atlassian.net/browse/BIT-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202#comment-14202 ] Daniel Thayer commented on BIT-1087: I found all of these bugs by installing and testing on platforms that we don't do our automated testing (although the first three do affect all platforms, these are not new bugs, and so I would be OK with postponing this until after 2.2). I also tested this branch on all of the platforms where we do our automated testing to make sure I didn't break anything. > topic/dnthayer/broctl-fixes > --- > > Key: BIT-1087 > URL: https://bro-tracker.atlassian.net/browse/BIT-1087 > Project: Bro Issue Tracker > Issue Type: Problem > Components: BroControl >Reporter: Daniel Thayer > Fix For: 2.2 > > > This branch fixes several bugs in broctl: > 1) on Linux, the broctl "top" command output sometimes shows wrong values for > memory statistics, > 2) there is a race condition when the "sendmail" option is an empty string, > 3) there is a deadlock when broctl runs a local command that produces a > sufficiently large amount of output, > 4) the shell scripts used by broctl are not as portable as they could be > (specifically, some commands, such as sed, do not support the same options on > all implementations) -- This message was sent by Atlassian JIRA (v6.1-OD-09-WN#6144) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1087) topic/dnthayer/broctl-fixes
[ https://bro-tracker.atlassian.net/browse/BIT-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14201#comment-14201 ] Robin Sommer commented on BIT-1087: --- This all makes sense, however some of the fixes make me wary to apply between beta and release as I can't really tell by just looking at them if they'll work correctly everywhere. I suppose you have you tested these all on the major platforms? Does our test suite cover them so that we'd catch if something breaks on one of the tested platforms? If/where not, can you add tests that exercise the changed code paths (probably not easily possible everywhere, but for some). > topic/dnthayer/broctl-fixes > --- > > Key: BIT-1087 > URL: https://bro-tracker.atlassian.net/browse/BIT-1087 > Project: Bro Issue Tracker > Issue Type: Problem > Components: BroControl >Reporter: Daniel Thayer > Fix For: 2.2 > > > This branch fixes several bugs in broctl: > 1) on Linux, the broctl "top" command output sometimes shows wrong values for > memory statistics, > 2) there is a race condition when the "sendmail" option is an empty string, > 3) there is a deadlock when broctl runs a local command that produces a > sufficiently large amount of output, > 4) the shell scripts used by broctl are not as portable as they could be > (specifically, some commands, such as sed, do not support the same options on > all implementations) -- This message was sent by Atlassian JIRA (v6.1-OD-09-WN#6144) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
