Re: [Bro-Dev] [Bro-Commits] [git/bro] fastpath: Change X509 extension value parsing to not abort on malloc failures. (385438d)
> + // TODO: see about using regular malloc here, there were unknown > problems > + // using anything other than OPENSSL_malloc that need investigation. > + char* buffer = (char*) OPENSSL_malloc(length); Bernhard, do you know any more details of what was wrong w/ regular malloc() here? I think it makes sense to get away from using OpenSSL’s malloc wrapper if it’s possible. If I change it, running the test suites on OS X don’t show a problem. Is triggering the problem more subtle than the test suites will pick up on? - Jon ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
Re: [Bro-Dev] [Bro-Commits] [git/bro] fastpath: Change X509 extension value parsing to not abort on malloc failures. (385438d)
On May 1, 2014, at 12:02 PM, Siwek, Jonathan Luke wrote: > >> +// TODO: see about using regular malloc here, there were unknown >> problems >> +// using anything other than OPENSSL_malloc that need investigation. >> +char* buffer = (char*) OPENSSL_malloc(length); > > Bernhard, do you know any more details of what was wrong w/ regular malloc() > here? I think it makes sense to get away from using OpenSSL’s malloc wrapper > if it’s possible. > > If I change it, running the test suites on OS X don’t show a problem. Is > triggering the problem more subtle than the test suites will pick up on? Nah, it was fairly obvious. I might just have done something else wrong and blamed it on that - if everything still works, that should be good enough :) Bernhard ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
Re: [Bro-Dev] [Bro-Commits] [git/bro] fastpath: Change X509 extension value parsing to not abort on malloc failures. (385438d)
On May 1, 2014, at 2:15 PM, Bernhard Amann wrote: > > On May 1, 2014, at 12:02 PM, Siwek, Jonathan Luke wrote: > >> >>> + // TODO: see about using regular malloc here, there were unknown >>> problems >>> + // using anything other than OPENSSL_malloc that need investigation. >>> + char* buffer = (char*) OPENSSL_malloc(length); >> >> Bernhard, do you know any more details of what was wrong w/ regular malloc() >> here? I think it makes sense to get away from using OpenSSL’s malloc >> wrapper if it’s possible. >> >> If I change it, running the test suites on OS X don’t show a problem. Is >> triggering the problem more subtle than the test suites will pick up on? > > Nah, it was fairly obvious. I might just have done something else wrong and > blamed it on that - if everything still works, that should be good enough :) Thanks, I’ll make the change after this one gets reviewed/promoted. - Jon ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1142) SNMP Analysis
[ https://bro-tracker.atlassian.net/browse/BIT-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Slagell reassigned BIT-1142: - Assignee: Jon Siwek (was: Seth Hall) > SNMP Analysis > - > > Key: BIT-1142 > URL: https://bro-tracker.atlassian.net/browse/BIT-1142 > Project: Bro Issue Tracker > Issue Type: New Feature > Components: BinPAC, Bro >Affects Versions: git/master >Reporter: Jon Siwek >Assignee: Jon Siwek > Fix For: 2.3 > > > /topic/jsiwek/snmp in bro, binpac, and bro-testing-private adds support for > parsing SNMP datagrams. It's only absent a snmp.log. > Seth, do you mind taking a look at what might make sense for a default > snmp.log? I'm guessing it might look similar in concept to dns.log. A > difference is I'm not sure how meaningful raw OID to value mappings will be. > The code is in a merge-able state as it is in the branch/repos I mentioned, > and IMO, has value even without a default snmp.log. So if you just want to > flip to a merge request and postpone thinking up an snmp.log for later, I > think that's fine, too. -- This message was sent by Atlassian JIRA (v6.3-OD-03-012#6321) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1141) Investigate further improvements to file analysis performance
[ https://bro-tracker.atlassian.net/browse/BIT-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robin Sommer updated BIT-1141: -- Status: Closed (was: Merge Request) Sounds good, thanks. > Investigate further improvements to file analysis performance > - > > Key: BIT-1141 > URL: https://bro-tracker.atlassian.net/browse/BIT-1141 > Project: Bro Issue Tracker > Issue Type: Problem > Components: Bro >Reporter: Robin Sommer >Assignee: Jon Siwek > Fix For: 2.3 > > > Some further ideas for measuring and improving the performance of maintaining > the handles were floating around. -- This message was sent by Atlassian JIRA (v6.3-OD-03-012#6321) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1185) topic/dnthayer/broctld-work
[ https://bro-tracker.atlassian.net/browse/BIT-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robin Sommer updated BIT-1185: -- Resolution: Merged (was: Fixed) Status: Closed (was: Merge Request) > topic/dnthayer/broctld-work > --- > > Key: BIT-1185 > URL: https://bro-tracker.atlassian.net/browse/BIT-1185 > Project: Bro Issue Tracker > Issue Type: Problem > Components: BroControl >Reporter: Daniel Thayer > Fix For: 2.3 > > > This branch contains some code cleanup and also fixes or improves the > following issues: > The df, exec, and top commands now run only once per host. > Avoid reporting same disk check error msg multiple times for same host. > Improve output column formatting. > Added warning to do a "broctl install" if broctl or node config changes. > Don't email about "$total" pseudo-node not receiving any packets. > Remove unused "home" broctl option. > Changed plugin API hosts() function to be more useful. -- This message was sent by Atlassian JIRA (v6.3-OD-03-012#6321) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1150) X509 updates
[ https://bro-tracker.atlassian.net/browse/BIT-1150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robin Sommer updated BIT-1150: -- Status: Closed (was: Merge Request) > X509 updates > > > Key: BIT-1150 > URL: https://bro-tracker.atlassian.net/browse/BIT-1150 > Project: Bro Issue Tracker > Issue Type: Problem > Components: Bro >Reporter: Robin Sommer >Assignee: Bernhard Amann > Fix For: 2.3 > > Attachments: signature.asc > > -- This message was sent by Atlassian JIRA (v6.3-OD-03-012#6321) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1189) merge topic/bernhard/ec-curve
[ https://bro-tracker.atlassian.net/browse/BIT-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robin Sommer updated BIT-1189: -- Resolution: Merged (was: Fixed) Status: Closed (was: Merge Request) > merge topic/bernhard/ec-curve > - > > Key: BIT-1189 > URL: https://bro-tracker.atlassian.net/browse/BIT-1189 > Project: Bro Issue Tracker > Issue Type: Improvement > Components: Bro >Affects Versions: git/master >Reporter: Bernhard Amann > Fix For: 2.3 > > > topic/bernhard/ec-curve adds support for recognizing which curve was chosen > in a connection using ECDH/ECDHE as well as returning the DH parameters for > DHE/DH-Anon. > Furthermore, it adds a small policy script that warns on weak certificate > keys or DH-parameters. > Github diff link: https://github.com/bro/bro/compare/topic;bernhard;ec-curve -- This message was sent by Atlassian JIRA (v6.3-OD-03-012#6321) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [Auto] Merge Status
Open Merge Requests === IDComponentReporterAssignee Updated For Version PrioritySummary --- -- -- - -- - BIT-1177 [1] Bro Bernhard Amann Seth Hall 2014-04-21 2.3 Normal SumStats dynamic updates do not work in cluster mode BIT-348 [2] Bro gregor Robin Sommer 2014-04-30 2.3 HighReassembler integer overflow issues. Data not delivered after 2GB Open GitHub Pull Requests = IssueComponent UserUpdated Title --- -- -- --- #4 [3] time-machine mareq [4] 2014-04-10 When deleting connections hashtable, delete stored connections as well. [5] #3 [6] time-machine mareq [7] 2014-04-10 Correct handling of Linux SLL header and VLAN headers. [8] #2 [9] time-machine mareq [10] 2014-04-09 Query interval start/end is now taken into account. [11] #1 [12] time-machine mareq [13] 2014-03-19 TM-16: Really skip VLAN header for indexing. [14] [1] BIT-1177 https://bro-tracker.atlassian.net/browse/BIT-1177 [2] BIT-348 https://bro-tracker.atlassian.net/browse/BIT-348 [3] Pull Request #4 https://github.com/bro/time-machine/pull/4 [4] mareq https://github.com/mareq [5] Merge Pull Request #4 with git pull https://github.com/mareq/time-machine.git topic/mareq/memory-leaks [6] Pull Request #3 https://github.com/bro/time-machine/pull/3 [7] mareq https://github.com/mareq [8] Merge Pull Request #3 with git pull https://github.com/mareq/time-machine.git topic/mareq/linktype-linux-sll [9] Pull Request #2 https://github.com/bro/time-machine/pull/2 [10] mareq https://github.com/mareq [11] Merge Pull Request #2 with git pull https://github.com/mareq/time-machine.git topic/mareq/in-memory-query-interval [12] Pull Request #1 https://github.com/bro/time-machine/pull/1 [13] mareq https://github.com/mareq [14] Merge Pull Request #1 with git pull https://github.com/mareq/time-machine.git topic/mareq/tm-16 ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
