Re: [Bro-Dev] Moving to GitHub?
On Thu, May 17, 2018 at 11:21 -0500, you wrote: > * For porting over JIRA tickets to GitHub, "most recent" doesn't seem like a > good metric to use. Agree. :) > they may as well just port all the older ones that are still valid > over to GitHub. That may be a bit too broad though. How about "still valid and either (1) quite important or (2) something we expect will be addresses reasonably soon"? We have many old tickets that are technically still valid but unlikely to see any work anytime soon (otherwise they would have been addressed already), and I'm worried that they would just add noise without value. The old tickets won't go away, the JIRA will remain. If something becomes relevant/active, we can always bring it over at that time. > I find myself in that situation quite often, actually, so > transitioning to GitHub PRs, I wonder if we'd want a PR to be created > against each individual repo? Good point. Creating just one root PR that mentions the others sounds good to me for such cases. Robin -- Robin Sommer * ICSI/LBNL * ro...@icir.org * www.icir.org/robin ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
Re: [Bro-Dev] Moving to GitHub?
On 15 May 2018, at 20:19, Robin Sommer wrote: > This has been coming up in various contexts & subgroups of people, and > I wanted to send it out as a proposal to gather some broader feedback: > Do we want to move Bro's git repositories and tickets to GitHub? I like the idea. It'll be nice to have one process for handling everything instead of the multiple avenues for tickets and merge requests that we have today. It seems that we should even be able to solve the issue with the immediate diff emails by using webhooks with an AWS lambda function. I'm not sure if we'd be able to do all of the git work from that though. .Seth -- Seth Hall * Corelight, Inc * www.corelight.com ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
Re: [Bro-Dev] Moving to GitHub?
On 5/15/18 7:19 PM, Robin Sommer wrote: > What do people think? Any support, or concerns? Yeah, generally in favor with some comments: * For porting over JIRA tickets to GitHub, "most recent" doesn't seem like a good metric to use. e.g. BIT-1829 (pcap triggering assertion in binpac) seems kind of important and not something I'd want to have lost in the move, although it had no activity in almost a year. So, I think it's worth it to be more comprehensive here, and as long as someone is going through to review all the tickets, they may as well just port all the older ones that are still valid over to GitHub. (Yeah, I guess I'm volunteering). * One thing I did like about using JIRA for merge requests is that I could make a single ticket and just say I have a given branch name in a bunch of repos that are ready for review/merge. I find myself in that situation quite often, actually, so transitioning to GitHub PRs, I wonder if we'd want a PR to be created against each individual repo? Seems a bit much in terms of overhead. Alternatively, could still create a GH issue and just say "please review branch foo in repos X, Y, Z and merge them". Or else create a single PR in the "root" repo and mention in the PR that the same branch in child submodules also exists and needs merging. That may play better with Travis CI integration even, although maybe not in the case where you need to change things in the "external testing" repos, which are not connected to bro via a submodule. - Jon ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
