Bob created BIT-1091:
------------------------
Summary: Broctl config.py handling of [manager] header is brittle
Key: BIT-1091
URL: https://bro-tracker.atlassian.net/browse/BIT-1091
Project: Bro Issue Tracker
Issue Type: Problem
Components: BroControl
Affects Versions: 2.2
Environment: RHEL6
Reporter: Bob
$prefix/lib/broctl/BroControl/config.py (line 159, in nodes()) special cases
the manager node of the etc/node.cfg config and checks it by the attribute
n.name, as opposed to all of the other types that are handled earlier in the
function, which get checked by the attribute n.type. This means that anyone
who might try to set a more descriptive manager name, like
[broproductionmanager] or [brotestmanager], will break broctl to disastrous
effect:
[root@bro-testmgr bro-2.2-beta]# /opt/bro/bin/broctl install
removing old policies in /var/bro/spool/installed-scripts-do-not-touch/site ...
done.
removing old policies in /var/bro/spool/installed-scripts-do-not-touch/auto ...
done.
creating policy directories ... done.
installing site policies ... done.
generating local-networks.bro ... done.
Traceback (most recent call last):
File "/opt/bro/bin/broctl", line 980, in <module>
loop.onecmd(line)
File "/usr/lib64/python2.6/cmd.py", line 219, in onecmd
return func(arg)
File "/opt/bro/bin/broctl", line 202, in do_install
result = install.install(local)
File "/opt/bro/lib/broctl/BroControl/install.py", line 112, in install
util.force_symlink(manager.cwd(), current)
AttributeError: 'NoneType' object has no attribute 'cwd'
abnormal termination, saving state ...
This should be cleaned up to make this field user-modifiable as the others are,
or at the very least we should implement a warning to users that they should
not change the name of the field.
--
This message was sent by Atlassian JIRA
(v6.1-OD-09-WN#6144)
_______________________________________________
bro-dev mailing list
bro-dev@bro.org
http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
