[Bro-Dev] [JIRA] (BIT-1154) Formatters restructed in: topic/seth/json-formatter
[ https://bro-tracker.atlassian.net/browse/BIT-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Seth Hall updated BIT-1154: --- Resolution: Fixed Status: Closed (was: Open) Let's just close this for now. > Formatters restructed in: topic/seth/json-formatter > --- > > Key: BIT-1154 > URL: https://bro-tracker.atlassian.net/browse/BIT-1154 > Project: Bro Issue Tracker > Issue Type: New Feature > Components: Bro >Affects Versions: 2.4 >Reporter: Seth Hall >Assignee: Seth Hall > Fix For: 2.5 > > > topic/seth/json-formatter has an abstraction for Formatters and I created a > formatters directory under threading. There is also a new JSON formatter and > support in the Ascii and ElasticSearch writers for the JSON formatter. > I went ahead and threw in per-filter configuration options for the Ascii > writer for all of the options that were exposed globally too. -- This message was sent by Atlassian JIRA (v7.0.0-OD-08-002#70107) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1154) Formatters restructed in: topic/seth/json-formatter
[ https://bro-tracker.atlassian.net/browse/BIT-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=22613#comment-22613 ] Johanna Amann commented on BIT-1154: Seth, will you still do these? :) > Formatters restructed in: topic/seth/json-formatter > --- > > Key: BIT-1154 > URL: https://bro-tracker.atlassian.net/browse/BIT-1154 > Project: Bro Issue Tracker > Issue Type: New Feature > Components: Bro >Affects Versions: 2.4 >Reporter: Seth Hall >Assignee: Seth Hall > Fix For: 2.5 > > > topic/seth/json-formatter has an abstraction for Formatters and I created a > formatters directory under threading. There is also a new JSON formatter and > support in the Ascii and ElasticSearch writers for the JSON formatter. > I went ahead and threw in per-filter configuration options for the Ascii > writer for all of the options that were exposed globally too. -- This message was sent by Atlassian JIRA (v7.0.0-OD-08-002#70107) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1154) Formatters restructed in: topic/seth/json-formatter
[ https://bro-tracker.atlassian.net/browse/BIT-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20417#comment-20417 ] Robin Sommer commented on BIT-1154: --- Lesson: Don't merge without the tests being there > Formatters restructed in: topic/seth/json-formatter > --- > > Key: BIT-1154 > URL: https://bro-tracker.atlassian.net/browse/BIT-1154 > Project: Bro Issue Tracker > Issue Type: New Feature > Components: Bro >Affects Versions: 2.4 >Reporter: Seth Hall >Assignee: Seth Hall > Fix For: 2.5 > > > topic/seth/json-formatter has an abstraction for Formatters and I created a > formatters directory under threading. There is also a new JSON formatter and > support in the Ascii and ElasticSearch writers for the JSON formatter. > I went ahead and threw in per-filter configuration options for the Ascii > writer for all of the options that were exposed globally too. -- This message was sent by Atlassian JIRA (v6.5-OD-01-120#65000) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1154) Formatters restructed in: topic/seth/json-formatter
[ https://bro-tracker.atlassian.net/browse/BIT-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robin Sommer updated BIT-1154: -- Fix Version/s: (was: 2.4) 2.5 > Formatters restructed in: topic/seth/json-formatter > --- > > Key: BIT-1154 > URL: https://bro-tracker.atlassian.net/browse/BIT-1154 > Project: Bro Issue Tracker > Issue Type: New Feature > Components: Bro >Affects Versions: 2.4 >Reporter: Seth Hall >Assignee: Seth Hall > Fix For: 2.5 > > > topic/seth/json-formatter has an abstraction for Formatters and I created a > formatters directory under threading. There is also a new JSON formatter and > support in the Ascii and ElasticSearch writers for the JSON formatter. > I went ahead and threw in per-filter configuration options for the Ascii > writer for all of the options that were exposed globally too. -- This message was sent by Atlassian JIRA (v6.5-OD-01-120#65000) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1154) Formatters restructed in: topic/seth/json-formatter
[ https://bro-tracker.atlassian.net/browse/BIT-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robin Sommer reassigned BIT-1154: - Assignee: Seth Hall > Formatters restructed in: topic/seth/json-formatter > --- > > Key: BIT-1154 > URL: https://bro-tracker.atlassian.net/browse/BIT-1154 > Project: Bro Issue Tracker > Issue Type: New Feature > Components: Bro >Affects Versions: 2.4 >Reporter: Seth Hall >Assignee: Seth Hall > Fix For: 2.4 > > > topic/seth/json-formatter has an abstraction for Formatters and I created a > formatters directory under threading. There is also a new JSON formatter and > support in the Ascii and ElasticSearch writers for the JSON formatter. > I went ahead and threw in per-filter configuration options for the Ascii > writer for all of the options that were exposed globally too. -- This message was sent by Atlassian JIRA (v6.4-OD-16-006#64014) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1154) Formatters restructed in: topic/seth/json-formatter
[ https://bro-tracker.atlassian.net/browse/BIT-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Siwek updated BIT-1154: --- Fix Version/s: 2.4 > Formatters restructed in: topic/seth/json-formatter > --- > > Key: BIT-1154 > URL: https://bro-tracker.atlassian.net/browse/BIT-1154 > Project: Bro Issue Tracker > Issue Type: New Feature > Components: Bro >Affects Versions: 2.4 >Reporter: Seth Hall > Fix For: 2.4 > > > topic/seth/json-formatter has an abstraction for Formatters and I created a > formatters directory under threading. There is also a new JSON formatter and > support in the Ascii and ElasticSearch writers for the JSON formatter. > I went ahead and threw in per-filter configuration options for the Ascii > writer for all of the options that were exposed globally too. -- This message was sent by Atlassian JIRA (v6.4-OD-15-055#64014) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1154) Formatters restructed in: topic/seth/json-formatter
[ https://bro-tracker.atlassian.net/browse/BIT-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16809#comment-16809 ] Seth Hall commented on BIT-1154: Robin's points are right and I'd like to do a bit more here so I bumped the ticket to 2.4. > Formatters restructed in: topic/seth/json-formatter > --- > > Key: BIT-1154 > URL: https://bro-tracker.atlassian.net/browse/BIT-1154 > Project: Bro Issue Tracker > Issue Type: New Feature > Components: Bro >Affects Versions: 2.4 >Reporter: Seth Hall > > topic/seth/json-formatter has an abstraction for Formatters and I created a > formatters directory under threading. There is also a new JSON formatter and > support in the Ascii and ElasticSearch writers for the JSON formatter. > I went ahead and threw in per-filter configuration options for the Ascii > writer for all of the options that were exposed globally too. -- This message was sent by Atlassian JIRA (v6.3-OD-06-017#6327) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1154) Formatters restructed in: topic/seth/json-formatter
[ https://bro-tracker.atlassian.net/browse/BIT-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Seth Hall updated BIT-1154: --- Affects Version/s: (was: 2.3) 2.4 > Formatters restructed in: topic/seth/json-formatter > --- > > Key: BIT-1154 > URL: https://bro-tracker.atlassian.net/browse/BIT-1154 > Project: Bro Issue Tracker > Issue Type: New Feature > Components: Bro >Affects Versions: 2.4 >Reporter: Seth Hall > > topic/seth/json-formatter has an abstraction for Formatters and I created a > formatters directory under threading. There is also a new JSON formatter and > support in the Ascii and ElasticSearch writers for the JSON formatter. > I went ahead and threw in per-filter configuration options for the Ascii > writer for all of the options that were exposed globally too. -- This message was sent by Atlassian JIRA (v6.3-OD-06-017#6327) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1154) Formatters restructed in: topic/seth/json-formatter
[ https://bro-tracker.atlassian.net/browse/BIT-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212#comment-16212 ] Jon Siwek commented on BIT-1154: Is there still more to do here? If so, should a "fix version" be set to put it on the roadmap? > Formatters restructed in: topic/seth/json-formatter > --- > > Key: BIT-1154 > URL: https://bro-tracker.atlassian.net/browse/BIT-1154 > Project: Bro Issue Tracker > Issue Type: New Feature > Components: Bro >Affects Versions: 2.3 >Reporter: Seth Hall > > topic/seth/json-formatter has an abstraction for Formatters and I created a > formatters directory under threading. There is also a new JSON formatter and > support in the Ascii and ElasticSearch writers for the JSON formatter. > I went ahead and threw in per-filter configuration options for the Ascii > writer for all of the options that were exposed globally too. -- This message was sent by Atlassian JIRA (v6.3-OD-02-026#6318) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1154) Formatters restructed in: topic/seth/json-formatter
[ https://bro-tracker.atlassian.net/browse/BIT-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robin Sommer reassigned BIT-1154: - Assignee: (was: Robin Sommer) > Formatters restructed in: topic/seth/json-formatter > --- > > Key: BIT-1154 > URL: https://bro-tracker.atlassian.net/browse/BIT-1154 > Project: Bro Issue Tracker > Issue Type: New Feature > Components: Bro >Affects Versions: 2.3 >Reporter: Seth Hall > > topic/seth/json-formatter has an abstraction for Formatters and I created a > formatters directory under threading. There is also a new JSON formatter and > support in the Ascii and ElasticSearch writers for the JSON formatter. > I went ahead and threw in per-filter configuration options for the Ascii > writer for all of the options that were exposed globally too. -- This message was sent by Atlassian JIRA (v6.2-OD-10-004-WN#6253) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1154) Formatters restructed in: topic/seth/json-formatter
[ https://bro-tracker.atlassian.net/browse/BIT-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robin Sommer updated BIT-1154: -- Status: Open (was: Merge Request) > Formatters restructed in: topic/seth/json-formatter > --- > > Key: BIT-1154 > URL: https://bro-tracker.atlassian.net/browse/BIT-1154 > Project: Bro Issue Tracker > Issue Type: New Feature > Components: Bro >Affects Versions: 2.3 >Reporter: Seth Hall >Assignee: Robin Sommer > > topic/seth/json-formatter has an abstraction for Formatters and I created a > formatters directory under threading. There is also a new JSON formatter and > support in the Ascii and ElasticSearch writers for the JSON formatter. > I went ahead and threw in per-filter configuration options for the Ascii > writer for all of the options that were exposed globally too. -- This message was sent by Atlassian JIRA (v6.2-OD-10-004-WN#6253) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1154) Formatters restructed in: topic/seth/json-formatter
[ https://bro-tracker.atlassian.net/browse/BIT-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15729#comment-15729 ] Robin Sommer commented on BIT-1154: --- Also, regarding renaming: agree that the Ascii formatter is misnamed now. No great ideas for alternatives though, maybe one of "Log" or "Bro" or "Standard" or "Default"? > Formatters restructed in: topic/seth/json-formatter > --- > > Key: BIT-1154 > URL: https://bro-tracker.atlassian.net/browse/BIT-1154 > Project: Bro Issue Tracker > Issue Type: New Feature > Components: Bro >Affects Versions: 2.3 >Reporter: Seth Hall >Assignee: Robin Sommer > > topic/seth/json-formatter has an abstraction for Formatters and I created a > formatters directory under threading. There is also a new JSON formatter and > support in the Ascii and ElasticSearch writers for the JSON formatter. > I went ahead and threw in per-filter configuration options for the Ascii > writer for all of the options that were exposed globally too. -- This message was sent by Atlassian JIRA (v6.2-OD-10-004-WN#6253) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1154) Formatters restructed in: topic/seth/json-formatter
[ https://bro-tracker.atlassian.net/browse/BIT-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15728#comment-15728 ] Robin Sommer commented on BIT-1154: --- Merged. The tests are a bit on the weak side though ... I'm leaving the ticket open hoping that we can add a few more: - More extensive tests of the JSON output (though I realize that's not quite trivial as the JSON output requires some normalization to diff larger log volumes) - I don't think there's any test of the new per-filter config options? Also, it might be nice to format the JSON a bit prettier, like with some more white space? > Formatters restructed in: topic/seth/json-formatter > --- > > Key: BIT-1154 > URL: https://bro-tracker.atlassian.net/browse/BIT-1154 > Project: Bro Issue Tracker > Issue Type: New Feature > Components: Bro >Affects Versions: 2.3 >Reporter: Seth Hall >Assignee: Robin Sommer > > topic/seth/json-formatter has an abstraction for Formatters and I created a > formatters directory under threading. There is also a new JSON formatter and > support in the Ascii and ElasticSearch writers for the JSON formatter. > I went ahead and threw in per-filter configuration options for the Ascii > writer for all of the options that were exposed globally too. -- This message was sent by Atlassian JIRA (v6.2-OD-10-004-WN#6253) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1154) Formatters restructed in: topic/seth/json-formatter
Seth Hall created BIT-1154: -- Summary: Formatters restructed in: topic/seth/json-formatter Key: BIT-1154 URL: https://bro-tracker.atlassian.net/browse/BIT-1154 Project: Bro Issue Tracker Issue Type: New Feature Components: Bro Affects Versions: 2.3 Reporter: Seth Hall Assignee: Robin Sommer topic/seth/json-formatter has an abstraction for Formatters and I created a formatters directory under threading. There is also a new JSON formatter and support in the Ascii and ElasticSearch writers for the JSON formatter. I went ahead and threw in per-filter configuration options for the Ascii writer for all of the options that were exposed globally too. -- This message was sent by Atlassian JIRA (v6.2-OD-10-004-WN#6253) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1154) Formatters restructed in: topic/seth/json-formatter
[ https://bro-tracker.atlassian.net/browse/BIT-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Seth Hall updated BIT-1154: --- Status: Merge Request (was: Open) > Formatters restructed in: topic/seth/json-formatter > --- > > Key: BIT-1154 > URL: https://bro-tracker.atlassian.net/browse/BIT-1154 > Project: Bro Issue Tracker > Issue Type: New Feature > Components: Bro >Affects Versions: 2.3 >Reporter: Seth Hall >Assignee: Robin Sommer > > topic/seth/json-formatter has an abstraction for Formatters and I created a > formatters directory under threading. There is also a new JSON formatter and > support in the Ascii and ElasticSearch writers for the JSON formatter. > I went ahead and threw in per-filter configuration options for the Ascii > writer for all of the options that were exposed globally too. -- This message was sent by Atlassian JIRA (v6.2-OD-10-004-WN#6253) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
