[Bro-Dev] [JIRA] (BIT-1476) btest-diff can generate too much output when a test fails
Daniel Thayer created BIT-1476: -- Summary: btest-diff can generate too much output when a test fails Key: BIT-1476 URL: https://bro-tracker.atlassian.net/browse/BIT-1476 Project: Bro Issue Tracker Issue Type: Improvement Components: BTest Reporter: Daniel Thayer When btest-diff fails for a test, it shows the file and then the diff of the file vs. the baseline. For small output sizes, this can be very useful, but it doesn't seem useful when one must scroll through hundreds (or thousands) of lines of output just to find where the diff begins. There is a MAX_LINES parameter in btest-diff to truncate the output of huge files, but it cannot be customized and the default value is 5000, which seems really excessive. There is also a TEST_DIFF_BRIEF option to prevent showing any file contents, but this is not desirable to use for tests with small baselines, and having to set it for each test with a large baseline seems like too much of a maintenance burden. -- This message was sent by Atlassian JIRA (v7.0.0-OD-04-018#70102) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1476) btest-diff can generate too much output when a test fails
[ https://bro-tracker.atlassian.net/browse/BIT-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=22028#comment-22028 ] Daniel Thayer commented on BIT-1476: In branch "topic/dnthayer/max-lines" in the btest git repo, I've changed the value of MAX_LINES to a smaller value, added ability for a user to override this value by setting the TEST_DIFF_FILE_MAX_LINES env. variable, and changed btest-diff to always show the entire file when no baseline exists. > btest-diff can generate too much output when a test fails > - > > Key: BIT-1476 > URL: https://bro-tracker.atlassian.net/browse/BIT-1476 > Project: Bro Issue Tracker > Issue Type: Improvement > Components: BTest >Reporter: Daniel Thayer > > When btest-diff fails for a test, it shows the file and then the diff of > the file vs. the baseline. For small output sizes, this can be very useful, > but it > doesn't seem useful when one must scroll through hundreds (or thousands) of > lines of output just to find where the diff begins. There is a MAX_LINES > parameter > in btest-diff to truncate the output of huge files, but it cannot be > customized and > the default value is 5000, which seems really excessive. There is also a > TEST_DIFF_BRIEF option to prevent showing any file contents, but this is > not desirable to use for tests with small baselines, and having to set it for > each > test with a large baseline seems like too much of a maintenance burden. -- This message was sent by Atlassian JIRA (v7.0.0-OD-04-018#70102) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1476) btest-diff can generate too much output when a test fails
[ https://bro-tracker.atlassian.net/browse/BIT-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Thayer updated BIT-1476: --- Status: Merge Request (was: Open) > btest-diff can generate too much output when a test fails > - > > Key: BIT-1476 > URL: https://bro-tracker.atlassian.net/browse/BIT-1476 > Project: Bro Issue Tracker > Issue Type: Improvement > Components: BTest >Reporter: Daniel Thayer > > When btest-diff fails for a test, it shows the file and then the diff of > the file vs. the baseline. For small output sizes, this can be very useful, > but it > doesn't seem useful when one must scroll through hundreds (or thousands) of > lines of output just to find where the diff begins. There is a MAX_LINES > parameter > in btest-diff to truncate the output of huge files, but it cannot be > customized and > the default value is 5000, which seems really excessive. There is also a > TEST_DIFF_BRIEF option to prevent showing any file contents, but this is > not desirable to use for tests with small baselines, and having to set it for > each > test with a large baseline seems like too much of a maintenance burden. -- This message was sent by Atlassian JIRA (v7.0.0-OD-04-018#70102) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1476) btest-diff can generate too much output when a test fails
[ https://bro-tracker.atlassian.net/browse/BIT-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robin Sommer reassigned BIT-1476: - Assignee: Robin Sommer > btest-diff can generate too much output when a test fails > - > > Key: BIT-1476 > URL: https://bro-tracker.atlassian.net/browse/BIT-1476 > Project: Bro Issue Tracker > Issue Type: Improvement > Components: BTest >Reporter: Daniel Thayer >Assignee: Robin Sommer > > When btest-diff fails for a test, it shows the file and then the diff of > the file vs. the baseline. For small output sizes, this can be very useful, > but it > doesn't seem useful when one must scroll through hundreds (or thousands) of > lines of output just to find where the diff begins. There is a MAX_LINES > parameter > in btest-diff to truncate the output of huge files, but it cannot be > customized and > the default value is 5000, which seems really excessive. There is also a > TEST_DIFF_BRIEF option to prevent showing any file contents, but this is > not desirable to use for tests with small baselines, and having to set it for > each > test with a large baseline seems like too much of a maintenance burden. -- This message was sent by Atlassian JIRA (v7.0.0-OD-07-011#70107) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-1476) btest-diff can generate too much output when a test fails
[ https://bro-tracker.atlassian.net/browse/BIT-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robin Sommer updated BIT-1476: -- Resolution: Merged (was: Fixed) Status: Closed (was: Merge Request) > btest-diff can generate too much output when a test fails > - > > Key: BIT-1476 > URL: https://bro-tracker.atlassian.net/browse/BIT-1476 > Project: Bro Issue Tracker > Issue Type: Improvement > Components: BTest >Reporter: Daniel Thayer >Assignee: Robin Sommer > > When btest-diff fails for a test, it shows the file and then the diff of > the file vs. the baseline. For small output sizes, this can be very useful, > but it > doesn't seem useful when one must scroll through hundreds (or thousands) of > lines of output just to find where the diff begins. There is a MAX_LINES > parameter > in btest-diff to truncate the output of huge files, but it cannot be > customized and > the default value is 5000, which seems really excessive. There is also a > TEST_DIFF_BRIEF option to prevent showing any file contents, but this is > not desirable to use for tests with small baselines, and having to set it for > each > test with a large baseline seems like too much of a maintenance burden. -- This message was sent by Atlassian JIRA (v7.0.0-OD-07-011#70107) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
