[Bro-Dev] [JIRA] (BIT-931) Ascii writer does not escape empty sets / vectors
[ https://bro-tracker.atlassian.net/browse/BIT-931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Siwek reassigned BIT-931: - Assignee: Seth Hall > Ascii writer does not escape empty sets / vectors > - > > Key: BIT-931 > URL: https://bro-tracker.atlassian.net/browse/BIT-931 > Project: Bro Issue Tracker > Issue Type: Problem > Components: Bro >Affects Versions: git/master >Reporter: Johanna Amann >Assignee: Seth Hall > Fix For: 2.4 > > > The script > {noformat} > redef LogAscii::empty_field = "EMPTY"; > module SSH; > export { > redef enum Log::ID += { LOG }; > type Log: record { > ss: set[string]; > } &log; > } > event bro_init() > { > Log::create_stream(SSH::LOG, [$columns=Log]); > Log::write(SSH::LOG, [ > $ss=set("EMPTY") > ]); > } > {noformat} > Outputs the line > {noformat} > EMPTY > {noformat} > to a log-file. This makes it impossible to distinguish a line containing > EMPTY from a line containing an empty set. -- This message was sent by Atlassian JIRA (v6.4-OD-15-055#64014) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-931) Ascii writer does not escape empty sets / vectors
[ https://bro-tracker.atlassian.net/browse/BIT-931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=19974#comment-19974 ] Jon Siwek commented on BIT-931: --- Seth, do you want to try fixing this in conjunction w/ BIT-1333 ? I think all that's needed is to modify the ASCII formatter to add an escape sequence for empty_field the same way it currently does for set_separator ? > Ascii writer does not escape empty sets / vectors > - > > Key: BIT-931 > URL: https://bro-tracker.atlassian.net/browse/BIT-931 > Project: Bro Issue Tracker > Issue Type: Problem > Components: Bro >Affects Versions: git/master >Reporter: Johanna Amann >Assignee: Seth Hall > Fix For: 2.4 > > > The script > {noformat} > redef LogAscii::empty_field = "EMPTY"; > module SSH; > export { > redef enum Log::ID += { LOG }; > type Log: record { > ss: set[string]; > } &log; > } > event bro_init() > { > Log::create_stream(SSH::LOG, [$columns=Log]); > Log::write(SSH::LOG, [ > $ss=set("EMPTY") > ]); > } > {noformat} > Outputs the line > {noformat} > EMPTY > {noformat} > to a log-file. This makes it impossible to distinguish a line containing > EMPTY from a line containing an empty set. -- This message was sent by Atlassian JIRA (v6.4-OD-15-055#64014) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] [JIRA] (BIT-931) Ascii writer does not escape empty sets / vectors
[ https://bro-tracker.atlassian.net/browse/BIT-931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robin Sommer updated BIT-931: - Fix Version/s: (was: 2.4) 2.5 > Ascii writer does not escape empty sets / vectors > - > > Key: BIT-931 > URL: https://bro-tracker.atlassian.net/browse/BIT-931 > Project: Bro Issue Tracker > Issue Type: Problem > Components: Bro >Affects Versions: git/master >Reporter: Johanna Amann >Assignee: Seth Hall > Fix For: 2.5 > > > The script > {noformat} > redef LogAscii::empty_field = "EMPTY"; > module SSH; > export { > redef enum Log::ID += { LOG }; > type Log: record { > ss: set[string]; > } &log; > } > event bro_init() > { > Log::create_stream(SSH::LOG, [$columns=Log]); > Log::write(SSH::LOG, [ > $ss=set("EMPTY") > ]); > } > {noformat} > Outputs the line > {noformat} > EMPTY > {noformat} > to a log-file. This makes it impossible to distinguish a line containing > EMPTY from a line containing an empty set. -- This message was sent by Atlassian JIRA (v6.4-OD-16-006#64014) ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev