bug#23803: 11.89.4; Integration of pdf-tools lazy loading
Hello, I was not really sure if this qualifies as a bug but decided to post it here anyway. There seems to be an issue when lazy loading auctex and pdf-tools. tex.el uses (unless (featurep 'pdf-tools)) at http://git.savannah.gnu.org/cgit/auctex.git/tree/tex.el#n1265 to check if pdf-tools is installed. This does not work if pdf-tools is loaded with e.g. use-package and the :defer flag set to t. I've worked around that (https://github.com/syl20bnr/spacemacs/pull/6365) by defining my own function which omits the (featurep) check and it works fine so this might be something to consider for auctex. Best, Christoph Emacs : GNU Emacs 24.5.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.20.6) of 2016-06-04 on juergen Package: 11.89.4 current state: == (setq AUCTeX-date "2016-05-22" window-system 'x LaTeX-version "2e" TeX-style-path '("~/.emacs.d/auctex" "/home/cp/.emacs.d/elpa/auctex-11.89.4/style" "/home/cp/.emacs.d/auctex/auto" "/home/cp/.emacs.d/auctex/style" "auto" "style") TeX-auto-save t TeX-parse-self t TeX-master t TeX-command-list '(("LatexMk" "latexmk %(-PDF)%S%(mode) %(file-line-error) %t" TeX-run-latexmk nil (plain-tex-mode latex-mode doctex-mode) :help "Run LatexMk") ("TeX" "%(PDF)%(tex) %(file-line-error) %(extraopts) %`%S%(PDFout)%(mode)%' %t" TeX-run-TeX nil (plain-tex-mode ams-tex-mode texinfo-mode) :help "Run plain TeX") ("LaTeX" "%`%l%(mode)%' %t" TeX-run-TeX nil (latex-mode doctex-mode) :help "Run LaTeX") ("Makeinfo" "makeinfo %(extraopts) %t" TeX-run-compile nil (texinfo-mode) :help "Run Makeinfo with Info output") ("Makeinfo HTML" "makeinfo %(extraopts) --html %t" TeX-run-compile nil (texinfo-mode) :help "Run Makeinfo with HTML output") ("AmSTeX" "amstex %(PDFout) %(extraopts) %`%S%(mode)%' %t" TeX-run-TeX nil (ams-tex-mode) :help "Run AMSTeX") ("ConTeXt" "%(cntxcom) --once --texutil %(extraopts) %(execopts)%t" TeX-run-TeX nil (context-mode) :help "Run ConTeXt once") ("ConTeXt Full" "%(cntxcom) %(extraopts) %(execopts)%t" TeX-run-TeX nil (context-mode) :help "Run ConTeXt until completion") ("BibTeX" "bibtex %s" TeX-run-BibTeX nil t :help "Run BibTeX") ("Biber" "biber %s" TeX-run-Biber nil t :help "Run Biber") ("View" "%V" TeX-run-discard-or-function t t :help "Run Viewer") ("Print" "%p" TeX-run-command t t :help "Print the file") ("Queue" "%q" TeX-run-background nil t :help "View the printer queue" :visible TeX-queue-command) ("File" "%(o?)dvips %d -o %f " TeX-run-dvips t t :help "Generate PostScript file") ("Dvips" "%(o?)dvips %d -o %f " TeX-run-dvips nil t :help "Convert DVI file to PostScript") ("Dvipdfmx" "dvipdfmx %d" TeX-run-dvipdfmx nil t :help "Convert DVI file to PDF with dvipdfmx") ("Ps2pdf" "ps2pdf %f" TeX-run-ps2pdf nil t :help "Convert PostScript file to PDF") ("Index" "makeindex %s" TeX-run-index nil t :help "Run makeindex to create index file") ("Xindy" "texindy %s" TeX-run-command nil t :help "Run xindy to create index file") ("Check" "lacheck %s" TeX-run-compile nil (latex-mode) :help "Check LaTeX file for correctness") ("ChkTeX" "chktex -v6 %s" TeX-run-compile nil (latex-mode) :help "Check LaTeX file for common mistakes") ("Spell" "(TeX-ispell-document \"\")" TeX-run-function nil t :help "Spell-check the document") ("Clean" "TeX-clean" TeX-run-function nil t :help "Delete generated intermediate files") ("Clean All" "(TeX-clean t)" TeX-run-function nil t :help "Delete generated intermediate and output files") ("Other" "" TeX-run-command t t :help "Run an arbitrary command")) ) -- --- Christoph Paulik Twitter, Github: @cpaulik PGP: 8CFC D7DF 2867 B2DC 749B 1B0A 6E3B A262 5186 A0AC signature.asc Description: PGP signature ___ bug-auctex mailing list bug-auctex@gnu.org https://lists.gnu.org/mailman/listinfo/bug-auctex
bug#23803: 11.89.4; Integration of pdf-tools lazy loading
Hi Christoph, 2016-06-19 13:16 GMT+02:00 Christoph Paulik : > > Hello, > > I was not really sure if this qualifies as a bug but decided to post it here > anyway. > > There seems to be an issue when lazy loading auctex and pdf-tools. > > tex.el uses (unless (featurep 'pdf-tools)) at > http://git.savannah.gnu.org/cgit/auctex.git/tree/tex.el#n1265 to check if > pdf-tools is installed. This does not work if pdf-tools is loaded with e.g. > use-package and the :defer flag set to t. > I've worked around that (https://github.com/syl20bnr/spacemacs/pull/6365) by > defining my own function which omits the (featurep) check and it works fine > so this might be something to consider for auctex. Thanks for the report. I'd like to keep a test, if possible. Tassilo, can we use `fboundp' on an autoloaded function? Maybe `pdf-tools-install'? Bye, Mosp ___ bug-auctex mailing list bug-auctex@gnu.org https://lists.gnu.org/mailman/listinfo/bug-auctex
bug#23803: 11.89.4; Integration of pdf-tools lazy loading
Yes, I think that should work and would be the right function. Can you do that please. I'm almost off to holidays. Bye, Tassilo Am 23. Juni 2016 23:27:26 schrieb Mosè Giordano : Hi Christoph, 2016-06-19 13:16 GMT+02:00 Christoph Paulik : Hello, I was not really sure if this qualifies as a bug but decided to post it here anyway. There seems to be an issue when lazy loading auctex and pdf-tools. tex.el uses (unless (featurep 'pdf-tools)) at http://git.savannah.gnu.org/cgit/auctex.git/tree/tex.el#n1265 to check if pdf-tools is installed. This does not work if pdf-tools is loaded with e.g. use-package and the :defer flag set to t. I've worked around that (https://github.com/syl20bnr/spacemacs/pull/6365) by defining my own function which omits the (featurep) check and it works fine so this might be something to consider for auctex. Thanks for the report. I'd like to keep a test, if possible. Tassilo, can we use `fboundp' on an autoloaded function? Maybe `pdf-tools-install'? Bye, Mosp ___ bug-auctex mailing list bug-auctex@gnu.org https://lists.gnu.org/mailman/listinfo/bug-auctex
bug#23803: 11.89.4; Integration of pdf-tools lazy loading
Hi Tassilo, 2016-06-24 8:03 GMT+02:00 Tassilo Horn : > Yes, I think that should work and would be the right function. Thank you. Christoph, can you please confirm the attached patch solves the problem for you? > Can you do > that please. I'm almost off to holidays. Sure, I can do it as soon as I get a confirmation it works. Bye, Mosè diff --git a/tex.el b/tex.el index 923ce32..fe24c44 100644 --- a/tex.el +++ b/tex.el @@ -1262,8 +1262,8 @@ DE is the name of the desktop environment, either \"gnome\" or If `TeX-source-correlate-mode' is disabled, only find and pop to the output PDF file. Used by default for the PDF Tools viewer entry in `TeX-view-program-list-builtin'." - (unless (featurep 'pdf-tools) -(error "PDF Tools are not installed")) + (unless (fboundp 'pdf-tools-install) +(error "PDF Tools are not available")) (unless TeX-PDF-mode (error "PDF Tools only work with PDF output")) (add-hook 'pdf-sync-backward-redirect-functions ___ bug-auctex mailing list bug-auctex@gnu.org https://lists.gnu.org/mailman/listinfo/bug-auctex
bug#23803: 11.89.4; Integration of pdf-tools lazy loading
Dear Mosè, The patch solves the problem. Thank you for the quick fix. Best, Christoph Mosè Giordano writes: > Hi Tassilo, > > 2016-06-24 8:03 GMT+02:00 Tassilo Horn : >> Yes, I think that should work and would be the right function. > > Thank you. Christoph, can you please confirm the attached patch > solves the problem for you? > >> Can you do >> that please. I'm almost off to holidays. > > Sure, I can do it as soon as I get a confirmation it works. > > Bye, > Mosè -- --- Christoph Paulik Twitter, Github: @cpaulik PGP: 8CFC D7DF 2867 B2DC 749B 1B0A 6E3B A262 5186 A0AC signature.asc Description: PGP signature ___ bug-auctex mailing list bug-auctex@gnu.org https://lists.gnu.org/mailman/listinfo/bug-auctex
bug#23803: 11.89.4; Integration of pdf-tools lazy loading
Hi Christoph, 2016-06-25 21:00 GMT+02:00 Christoph Paulik : > Dear Mosè, > > The patch solves the problem. Thank you for the quick fix. Thank you for the confirmation! Patch installed. Bye, Mosè ___ bug-auctex mailing list bug-auctex@gnu.org https://lists.gnu.org/mailman/listinfo/bug-auctex