bug#70442: [PATCH] Open new previews when they cover point
Paul Nelson writes: > Thanks, I see it now. Please see attached. Thanks. I slightly changed your patch (most notably, the value of :group tag) and installed it, closing. Best, Arash ___ bug-auctex mailing list bug-auctex@gnu.org https://lists.gnu.org/mailman/listinfo/bug-auctex
bug#70442: [PATCH] Open new previews when they cover point
Thanks, I see it now. Please see attached. 0001-Add-new-custom-option-preview-protect-point.patch Description: Binary data ___ bug-auctex mailing list bug-auctex@gnu.org https://lists.gnu.org/mailman/listinfo/bug-auctex
bug#70442: [PATCH] Open new previews when they cover point
Paul Nelson writes: > Actually, I'll wait until the correction for the parenthesis from > bug#70348 is available on master, so as to avoid faulty patches. That issue is already fixed with commit ed37457621. Note that I also deleted the unused lexical variable '(ov (car ovl))'. Do you see the commit after 'git pull'? Best, Arash ___ bug-auctex mailing list bug-auctex@gnu.org https://lists.gnu.org/mailman/listinfo/bug-auctex
bug#70442: [PATCH] Open new previews when they cover point
Actually, I'll wait until the correction for the parenthesis from bug#70348 is available on master, so as to avoid faulty patches. ___ bug-auctex mailing list bug-auctex@gnu.org https://lists.gnu.org/mailman/listinfo/bug-auctex
bug#70442: [PATCH] Open new previews when they cover point
Hi Arash, sure thing. I'll use "preview-protect-point" for the name of the user option unless you can immediately think of something better, and send the patch in a bit. Thanks, Paul ___ bug-auctex mailing list bug-auctex@gnu.org https://lists.gnu.org/mailman/listinfo/bug-auctex
bug#70442: [PATCH] Open new previews when they cover point
Hi Paul, Paul Nelson writes: > Steps to reproduce: > - Create test.tex with a valid equation environment. > - Put the point inside the equation environment. > - preview-buffer > > When the preview generates, the point is ejected from the equation > environment due to the new overlay. > > With this patch, the preview instead temporarily opens, as if the user > had entered it. > > I view the latter behavior as "clearly" better, but if I missed some > advantage of the current approach or if my suggestion is deemed > subjective, then I would be happy to resubmit the patch with this > behavior enabled by a user option. thanks for looking at this. I'm not sure which behavior is better, but since we're about to change something which was there "since forever", I suggest to introduce an user option and make the new behavior "opt-in". Does this make sense? Best, Arash ___ bug-auctex mailing list bug-auctex@gnu.org https://lists.gnu.org/mailman/listinfo/bug-auctex
bug#70442: [PATCH] Open new previews when they cover point
Steps to reproduce: - Create test.tex with a valid equation environment. - Put the point inside the equation environment. - preview-buffer When the preview generates, the point is ejected from the equation environment due to the new overlay. With this patch, the preview instead temporarily opens, as if the user had entered it. I view the latter behavior as "clearly" better, but if I missed some advantage of the current approach or if my suggestion is deemed subjective, then I would be happy to resubmit the patch with this behavior enabled by a user option. Thanks, best, Paul 0001-Open-new-previews-when-they-cover-point.patch Description: Binary data ___ bug-auctex mailing list bug-auctex@gnu.org https://lists.gnu.org/mailman/listinfo/bug-auctex
