[sr #110983] AC_SYS_LARGEFILE doesn't honor AC_LANG setting

[anonymous]

Follow-up Comment #7, sr #110983 (group autoconf):

This patch also works for me, thanks.

Jakub Bogusz


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[sr #110983] AC_SYS_LARGEFILE doesn't honor AC_LANG setting

[Paul Eggert]

Update of sr #110983 (group autoconf):

  Status:   Confirmed => Done   

___

Follow-up Comment #6:

I installed
[https://git.savannah.gnu.org/cgit/autoconf.git/commit/?id=b71143738516017f0e0d347a4025301c06c40254
a patch]; please give it a try. In the meantime I am boldly closing this bug
report.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[sr #110983] AC_SYS_LARGEFILE doesn't honor AC_LANG setting

[anonymous]

Follow-up Comment #5, sr #110983 (group autoconf):

Hi,

The attached patch seems to fix AC_SYS_LARGEFILE and co. with C++ for me (and
test suite passes on i686).

Jakub Bogusz 

(file #55940)

___

Additional Item Attachment:

File name: autoconf-largefile.patch   Size: 1KiB
   



AGPL NOTICE

These attachments are served by Savane. You can download the corresponding
source code of Savane at
https://git.savannah.nongnu.org/cgit/administration/savane.git/snapshot/savane-4448d8da181e3133acac16b178e98513aa6405cd.tar.gz


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[sr #110983] AC_SYS_LARGEFILE doesn't honor AC_LANG setting

[Zack Weinberg]

Follow-up Comment #4, sr#110983 (group autoconf):

@Paul Eggert: Not today, hopefully tomorrow.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[sr #110983] AC_SYS_LARGEFILE doesn't honor AC_LANG setting

[Zack Weinberg]

Follow-up Comment #3, sr#110983 (group autoconf):

As a workaround, make sure to invoke AC_SYS_LARGEFILE and/or AC_SYS_YEAR2038
early in configure.ac (this is a good idea anyway, as they can affect the
results of later checks), in C mode, even if nothing else uses the C compiler.
 For example:


AC_INIT([my-C++-program], [1.0], ...)
AC_PROG_CC
AC_SYS_LARGEFILE
AC_PROG_CXX
AC_LANG([C++])
# rest of the configure script
AC_OUTPUT




___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[sr #110983] AC_SYS_LARGEFILE doesn't honor AC_LANG setting

[Paul Eggert]

Follow-up Comment #2, sr#110983 (group autoconf):

Do you have an idea for a patch? We could put the patch into Gnulib's copy of
AC_SYS_LARGEFILE now, and it'll see more real-worldish testing that way.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[sr #110983] AC_SYS_LARGEFILE doesn't honor AC_LANG setting

[Zack Weinberg]

Update of sr#110983 (group autoconf):

Priority:   5 - Unprioritized => 3 - Release N+1
Severity:  3 - Normal => 4 - Important  
Operating System: Solaris => None   

___

Follow-up Comment #1:

I don't want to mess with AC_SYS_LARGEFILE this close to a release, but we
should prioritize fixing this very soon afterward.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[sr #110983] AC_SYS_LARGEFILE doesn't honor AC_LANG setting

[Zack Weinberg]

URL:
  

 Summary: AC_SYS_LARGEFILE doesn't honor AC_LANG setting
   Group: Autoconf
   Submitter: zackw
   Submitted: Tue 19 Dec 2023 06:36:10 PM UTC
Priority: 5 - Unprioritized
Severity: 3 - Normal
  Status: Confirmed
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
Operating System: Solaris


___

Follow-up Comments:


---
Date: Tue 19 Dec 2023 06:36:10 PM UTC By: Zack Weinberg 
_AC_SYS_LARGEFILE_PROBE unconditionally modifies $CC, regardless of the
current AC_LANG setting. Therefore, a configure script like this


AC_INIT
AC_LANG([C++])
AC_SYS_LARGEFILE
AC_OUTPUT


will *not* enable large file support, on a system where it's off by default
but can be enabled.  Because it put -D_FILE_OFFSET_BITS=64 into $CC, where
AC_COMPILE_IFELSE won't pick it up because we're using $CXX instead.

Since AC_SYS_YEAR2038 depends on AC_SYS_LARGEFILE, this affects that macro as
well.







___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/