bug#11345: Fwd: lex-depend-cxx automake-1.12 test failure on Mac OS X 10.7.3 (Xcode-4.3.2)

[Stefano Lattarini]

Forwarding this to bug-automake, so that we'll have a bug number to
reference in our fix.

Original message:


 Original Message 
Subject: lex-depend-cxx automake-1.12 test failure on Mac OS X 10.7.3   
(Xcode-4.3.2)
Date: Wed, 25 Apr 2012 19:25:00 -0500
From: Adam Mercer 
To: autom...@gnu.org

Hi

I've been looking at getting the version of automake in MacPorts
updated to automake-1.12 and I'm getting the following test failure:

FAIL: t/lex-depend-cxx
==

Running from installcheck: no
Using TAP: no
PATH = 
/opt/local/var/macports/build/_Users_ram_macports_ports_devel_automake/automake/work/automake-1.12/t/ax:/opt/local/var/macports/build/_Users_ram_macports_ports_devel_automake/automake/work/automake-1.12/t/wrap:/opt/local/bin:/opt/local/sbin:/bin:/sbin:/usr/bin:/usr/sbin
++ pwd
/opt/local/var/macports/build/_Users_ram_macports_ports_devel_automake/automake/work/automake-1.12/t/lex-depend-cxx.dir
+ cat
+ cat
+ cat
+ cp joe.ll moe.l++
+ cat
+ aclocal-1.12 -Werror
+ automake-1.12 --foreign -Werror -Wall -a
configure.ac: installing './ylwrap'
+ /usr/bin/grep -F joe.Po Makefile.in
@AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/joe.Po@am__quote@
test -f $(DEPDIR)/joe.Po
+ /usr/bin/grep -F moe.Po Makefile.in
@AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/moe.Po@am__quote@
test -f $(DEPDIR)/moe.Po
+ autoconf
+ ./configure --enable-dependency-tracking
checking for a BSD-compatible install... /opt/local/bin/ginstall -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /opt/local/bin/gmkdir -p
checking for gawk... no
checking for mawk... no
checking for nawk... no
checking for awk... awk
checking whether make sets $(MAKE)... yes
checking for g++... g++
checking whether the C++ compiler works... yes
checking for C++ compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking for style of include used by make... GNU
checking dependency style of g++... gcc3
checking for gcc... gcc
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for flex... lex
checking lex output file root... lex.yy
checking lex library... -lfl
checking whether yytext is a pointer... yes
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: executing depfiles commands
+ make test-deps-exist
ls -l .deps ;: For debugging.
total 16
-rw-r--r--  1 macports  admin  8 Apr 25 17:45 joe.Po
-rw-r--r--  1 macports  admin  8 Apr 25 17:45 moe.Po
test -f .deps/joe.Po
test -f .deps/moe.Po
+ make
/bin/sh ./ylwrap joe.ll lex.yy.c joe.cc -- lex
g++ -DPACKAGE_NAME=\"lex-depend-cxx\"
-DPACKAGE_TARNAME=\"lex-depend-cxx\" -DPACKAGE_VERSION=\"1.0\"
-DPACKAGE_STRING=\"lex-depend-cxx\ 1.0\" -DPACKAGE_BUGREPORT=\"\"
-DPACKAGE_URL=\"\" -DPACKAGE=\"lex-depend-cxx\" -DVERSION=\"1.0\"
-DYYTEXT_POINTER=1 -I. -g -O2 -MT joe.o -
MD -MP -MF .deps/joe.Tpo -c -o joe.o joe.cc
In file included from /usr/include/c++/4.2.1/bits/os_defines.h:61,
 from /usr/include/c++/4.2.1/bits/c++config.h:41,
 from /usr/include/c++/4.2.1/cstdio:50,
 from my-hdr.hxx:2,
 from joe.ll:10:
joe.ll:3: error: previous declaration of ‘int isatty(int)’ with ‘C++’ linkage
/usr/include/unistd.h:502: error: conflicts with new declaration with
‘C’ linkage
make: *** [joe.o] Error 1
+ exit_status=2
+ set +e
+ cd 
/opt/local/var/macports/build/_Users_ram_macports_ports_devel_automake/automake/work/automake-1.12
+ test no = yes
+ case $am_explicit_skips in
+ test 2 -eq 0
+ keep_testdirs=yes
+ am_keeping_testdirs
+ case $keep_testdirs in
+ return 0
+ set +x
lex-depend-cxx: exit 2

This is with Mac OS 10.7.3 and Xcode-4.3.2

Cheers

Adam

bug#11346: automake-1.12 - one test fails (due to truncated timestamp)

[Peter Breitenlohner]

Hi,

I just fetched automake-1.12, built it on our no-distro x86-linux-gnu
system

  uname -r: 2.6.28.6-x86_64 (most binaries are 32-bit)
  /lib/libc-2.3.6.so
  /lib64/libc-2.3.6.so

and got one test suite failure.

  FAIL: t/self-check-is_newest.tap 19 - is_newest u x

It seems that 'touch -r x u' (on jfs) has truncated the timestamp, but I
have also seen timestamps rounded upwards to the next second (I think).

Therefore I would suggest to replace
  touch -r x u
in self-check-is_newest.tap by
  touch -r x x; touch -r x u
such that x's time first gets rounded (up or down) to the next second and
then transferred to u.

Regards
Peter Breitenlohner 

bug#11345: Fwd: lex-depend-cxx automake-1.12 test failure on Mac OS X 10.7.3 (Xcode-4.3.2)

[Stefano Lattarini]

Hi Adam, thanks for the report.

On 04/26/2012 10:05 AM, Adam Mercer wrote:
> 
> I've been looking at getting the version of automake in MacPorts
> updated to automake-1.12 and I'm getting the following test failure:
> 
> FAIL: t/lex-depend-cxx
> ==
>
> [SNIP]
>
> + make
> /bin/sh ./ylwrap joe.ll lex.yy.c joe.cc -- lex
> g++ -DPACKAGE_NAME=\"lex-depend-cxx\"
> -DPACKAGE_TARNAME=\"lex-depend-cxx\" -DPACKAGE_VERSION=\"1.0\"
> -DPACKAGE_STRING=\"lex-depend-cxx\ 1.0\" -DPACKAGE_BUGREPORT=\"\"
> -DPACKAGE_URL=\"\" -DPACKAGE=\"lex-depend-cxx\" -DVERSION=\"1.0\"
> -DYYTEXT_POINTER=1 -I. -g -O2 -MT joe.o -
> MD -MP -MF .deps/joe.Tpo -c -o joe.o joe.cc
> In file included from /usr/include/c++/4.2.1/bits/os_defines.h:61,
>  from /usr/include/c++/4.2.1/bits/c++config.h:41,
>  from /usr/include/c++/4.2.1/cstdio:50,
>  from my-hdr.hxx:2,
>  from joe.ll:10:
> joe.ll:3: error: previous declaration of ‘int isatty(int)’ with ‘C++’ linkage
> /usr/include/unistd.h:502: error: conflicts with new declaration with
> ‘C’ linkage
> make: *** [joe.o] Error 1
> 
> This is with Mac OS 10.7.3 and Xcode-4.3.2
> 
Does the attached patch solves the problem for you?

Thanks,
  Stefano
>From 2eb5bde080ca3a74eabdb8e269a283da9b6cd4ca Mon Sep 17 00:00:00 2001
Message-Id: <2eb5bde080ca3a74eabdb8e269a283da9b6cd4ca.1335429514.git.stefano.lattar...@gmail.com>
From: Stefano Lattarini 
Date: Thu, 26 Apr 2012 10:29:42 +0200
Subject: [PATCH] tests: fix a failure in Lex/C++ tests on Mac OS X

The  header from Xcode-4.3.2 on Mac OS X 10.7.3 declares a 'isatty'
function with C++ linkage, that conflicts with our dummy definition of the
same function, which in turn is required to work around the absence of the
unistd.h header on MinGW (see commit 'v1.11-2138-gfeea090' of 11-04-2012).
So we tweak the affected tests to work around this new problem as well.

This fixes automake bug#11345.

* t/lex-clean-cxx.sh ($required): Since we are at it, add an explicit
'c++' requirement.
* t/lex-depend-cxx.sh ($required): Likewise.
(my-hdr.hxx): Don't include .  The "using namespace" directive
should still be enough to ensure the content of this header is not valid
C, albeit being of course valid C++.
Fix unrelated typos in comments.
(joe.ll): Adjust, by removing the call to 'printf'.

Signed-off-by: Stefano Lattarini 
---
 t/lex-clean-cxx.sh  |2 +-
 t/lex-depend-cxx.sh |6 ++
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/t/lex-clean-cxx.sh b/t/lex-clean-cxx.sh
index 1c57524..d1a745b 100755
--- a/t/lex-clean-cxx.sh
+++ b/t/lex-clean-cxx.sh
@@ -20,7 +20,7 @@
 # "make maintainer-clean".
 # See also sister test 'lex-clean.test'.
 
-required=lex
+required='c++ lex'
 . ./defs || Exit 1
 
 cat >> configure.ac << 'END'
diff --git a/t/lex-depend-cxx.sh b/t/lex-depend-cxx.sh
index 490516f..7bdfdf9 100755
--- a/t/lex-depend-cxx.sh
+++ b/t/lex-depend-cxx.sh
@@ -17,7 +17,7 @@
 # Test to make sure dependencies work with Lex/C++.
 # Test synthesized from PR automake/6.
 
-required=lex
+required='c++ lex'
 . ./defs || Exit 1
 
 cat >> configure.ac << 'END'
@@ -61,7 +61,6 @@ int yywrap (void)
 }
 int main (int argc, char **argv)
 {
-  printf("Hello, World!\n");
   return 0;
 }
 END
@@ -69,8 +68,7 @@ END
 cp joe.ll moe.l++
 
 cat > my-hdr.hxx <<'END'
-// This header contains deliberetly invalid C (but valid C++)
-#include 
+// This header contains deliberately invalid C (but valid C++).
 using namespace std;
 END
 
-- 
1.7.9.5

bug#11346: automake-1.12 - one test fails (due to truncated timestamp)

[Stefano Lattarini]

On 04/26/2012 10:26 AM, Peter Breitenlohner wrote:
> Hi,
>
Hi Peter, thanks for the report (and the fix ;-)

> I just fetched automake-1.12, built it on our no-distro x86-linux-gnu
> system
> 
>   uname -r: 2.6.28.6-x86_64 (most binaries are 32-bit)
>   /lib/libc-2.3.6.so
>   /lib64/libc-2.3.6.so
> 
> and got one test suite failure.
> 
>   FAIL: t/self-check-is_newest.tap 19 - is_newest u x
> 
> It seems that 'touch -r x u' (on jfs) has truncated the timestamp, but I
> have also seen timestamps rounded upwards to the next second (I think).
> 
> Therefore I would suggest to replace
>   touch -r x u
> in self-check-is_newest.tap by
>   touch -r x x; touch -r x u
> such that x's time first gets rounded (up or down) to the next second and
> then transferred to u.
>
Good idea.  Can you confirm that the attached patch solves your problem?

Thanks,
  Stefano
>From b3baa4f5f2312617c6f115b271efc48f84d908db Mon Sep 17 00:00:00 2001
Message-Id: 
From: Stefano Lattarini 
Date: Thu, 26 Apr 2012 10:52:48 +0200
Subject: [PATCH] tests: fix a spurious failure due to truncated timestamps

Fixes automake bug#11346.

* t/self-check-is_newest.tap: Apparently, on some systems (or file
systems), "touch -r" can truncate timestamps :-(  Work around that.

Co-authored-by: Peter Breitenlohner 
Copyright-paperwork-exempt: yes
Signed-off-by: Stefano Lattarini 
---
 t/self-check-is_newest.tap |   14 --
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/t/self-check-is_newest.tap b/t/self-check-is_newest.tap
index 76b69ac..842c411 100755
--- a/t/self-check-is_newest.tap
+++ b/t/self-check-is_newest.tap
@@ -24,6 +24,16 @@ plan_ 21
 Y () { command_ok_ "is_newest $*" is_newest "$@"; }
 N () { command_ok_ "not is_newest $*" not is_newest "$@"; }
 
+# A simple "touch -r" might not work, since on some file systems, and/or
+# with some 'touch' versions, it might truncate the timestamp (or even
+# rounded it upwards maybe).  So the first (apparently redundant) 'touch'
+# invocation below ensures that the timestamp gets "normalized" in a way
+# that allows it to be correctly copied by the second 'touch' invocation.
+copy_timestamp ()
+{
+  touch -r "$1" "$1" && touch -r "$1" "$2"
+}
+
 : > a
 $sleep
 : > b
@@ -38,7 +48,7 @@ Y c b
 Y c c
 Y c a b c
 
-touch -r c d
+copy_timestamp c d
 
 stat c d || : # For debugging.
 
@@ -69,7 +79,7 @@ done
 Y x/foo x
 N x x/foo
 
-touch -r x u
+copy_timestamp x u
 Y x u
 Y u x
 
-- 
1.7.9.5

bug#11346: automake-1.12 - one test fails (due to truncated timestamp)

[Peter Breitenlohner]

On Thu, 26 Apr 2012, Stefano Lattarini wrote:


Good idea.  Can you confirm that the attached patch solves your problem?


Hi Stefano,

it does indeed.

BTW: The "Copyright-paperwork-exempt: yes" should be unnecessary because you
should still have the paperwork from the ObjC++ integration.

Regards
Peter

bug#11346: automake-1.12 - one test fails (due to truncated timestamp)

[Stefano Lattarini]

tags 11346 + patch
thanks

On 04/26/2012 11:32 AM, Peter Breitenlohner wrote:
> On Thu, 26 Apr 2012, Stefano Lattarini wrote:
> 
>> Good idea.  Can you confirm that the attached patch solves your problem?
> 
> Hi Stefano,
> 
> it does indeed.
>
Good.  Will push shortly then.

> BTW: The "Copyright-paperwork-exempt: yes" should be unnecessary
>
Will remove it then.

> because you should still have the paperwork from the ObjC++ integration.
>
I wasn't involved in the project yet back then, so I wasn't aware you had
the paperwork in place already.  Now I am :-)

Thanks,
  Stefano

bug#11345: Fwd: lex-depend-cxx automake-1.12 test failure on Mac OS X 10.7.3 (Xcode-4.3.2)

[Stefano Lattarini]

On 04/26/2012 10:38 AM, Stefano Lattarini wrote:
> Hi Adam, thanks for the report.
> 
> On 04/26/2012 10:05 AM, Adam Mercer wrote:
>>
>> I've been looking at getting the version of automake in MacPorts
>> updated to automake-1.12 and I'm getting the following test failure:
>>
>> FAIL: t/lex-depend-cxx
>
> Does the attached patch solves the problem for you?
>
Oops, I forgot to add you to the THANKS file.  Consider the following
hunk squashed in:

  diff --git a/THANKS b/THANKS
  index 16367e1..c8e4012 100644
  --- a/THANKS
  +++ b/THANKS
  @@ -3,6 +3,7 @@ It would not be what it is today without the invaluable help 
of these
   people:

   Adam J. Richtera...@yggdrasil.com
  +Adam Mercerramer...@gmail.com
   Adam Sampson   a...@offog.org
   Adrian Bunkb...@fs.tum.de
   Akim Demaille  a...@freefriends.org

Sorry for the noise,
  Stefano

bug#11347: the remake rules in the automake test suite are too greedy

[Stefano Lattarini]

Severity: minor

Reference: 

On 04/22/2012 08:10 PM, Bruno Haible wrote:
>
> [SNIP]
>
> Modifying a test apparently requires me to have the same exact Autoconf
> version (2.68) as you did. What an annoyance! I have to proceed like this:
>
> 1. On a machine with autoconf 2.68:
>- Unpack a fresh automake-1.11d directory.
>$ ./configure; make   # This is necessary to build 'automake'.
>- Then only! change t/lex-libobj.sh
>$ make# This uses the built 'automake'.
>$ make distclean
> 2. Copy this directory to the target machine (without autoconf 2.68).
> 3. $ ./configure; make
>$ make check TESTS=t/lex-libobj
>
I agree this situation is suboptimal and can hinder on-field testing by
the users that are not automake developers.  I will fix this soonish.

Thanks,
  Stefano

bug#11346: automake-1.12 - one test fails (due to truncated timestamp)

[Stefano Lattarini]

On 04/26/2012 11:38 AM, Stefano Lattarini wrote:
>  Will push shortly then.
> 
Pushed now.  I'm thus closing this bug report.

Thanks,
  Stefano

bug#11346: automake-1.12 - one test fails (due to truncated timestamp)

[Peter Breitenlohner]

On Thu, 26 Apr 2012, Stefano Lattarini wrote:


because you should still have the paperwork from the ObjC++ integration.


I wasn't involved in the project yet back then, so I wasn't aware you had
the paperwork in place already.  Now I am :-)


Hi Stefano,

and the whole ObjC++ integration (one of two reasons I was waiting for 1.12)
somehow got lost.

I still have the old patches 0001-2009-07-22-Support-for-Objective-C.patch
from 2009-07-22 etc, but could also apply them to the current git version
and send you these.  I may, however, have problem to modernize the test
cases.

Regards
Peter

bug#11347: the remake rules in the automake test suite are too greedy

[Stefano Lattarini]

On 04/26/2012 12:10 PM, Stefano Lattarini wrote:
> Severity: minor
> 
> Reference: 
> 
> On 04/22/2012 08:10 PM, Bruno Haible wrote:
>>
>> [SNIP]
>>
>> Modifying a test apparently requires me to have the same exact Autoconf
>> version (2.68) as you did. What an annoyance! I have to proceed like this:
>>
>> 1. On a machine with autoconf 2.68:
>>- Unpack a fresh automake-1.11d directory.
>>$ ./configure; make   # This is necessary to build 'automake'.
>>- Then only! change t/lex-libobj.sh
>>$ make# This uses the built 'automake'.
>>$ make distclean
>> 2. Copy this directory to the target machine (without autoconf 2.68).
>> 3. $ ./configure; make
>>$ make check TESTS=t/lex-libobj
>>
> I agree this situation is suboptimal and can hinder on-field testing by
> the users that are not automake developers.  I will fix this soonish.
> 
> Thanks,
>   Stefano
> 
And here is a patch.  The change itself is obvious, but I'd like a review
on the long-winded commit message.  I will push by tomorrow if there is no
review by then.

Regards,
  Stefano
>From bc7013f1d87a3da468c90a43b0136a7ef88cbdbf Mon Sep 17 00:00:00 2001
Message-Id: 
From: Stefano Lattarini 
Date: Thu, 26 Apr 2012 15:05:05 +0200
Subject: [PATCH] build: avoid too greedy rebuilds in the testsuite

The autogenerated makefile fragment 't/testsuite-part.am' used to depend
on the list of *all* the hand-written files.  This was technically correct,
since that makefile fragment was (and still is) generated by the script
'gen-testsuite-part', which scans all the hand-written files to detect
implicit dependencies and to decide for which tests a further wrapper test
should be generated.

However, the presence of such a dependency implied that, whenever *any*
test case was modified (no matter how slightly), the 't/testsuite-part.am'
file was rebuilt, and since that is included by our 'Makefile.am', the
'Makefile.in' file was rebuilt as well by automake.  In order to do so,
automake scanned our 'configure.ac' file, which requires the latest
Autoconf version (2.69 at the time of writing), and the casual user can
easily lack that on his machine (and that should be allowed, as automake
currently supports any autoconf version >= 2.62).

The described situation could hinder hinder on-field testing or debugging
by users (even experienced ones) that are not automake developers; see
for example automake bug#11347.

So we drop the explicit dependency of 't/testsuite-part.am' on the
hand-written test cases.  (As an aside, note that this has already
been done in Automake-NG, albeit for other reasons; see the commit
'v1.11b-129-g1690aca' of 23-40-2012, "[ng] build: define $(TESTS)
through a wildcard").

This is not a serious regression in the faithfulness of the Automake
build systems, since it that already had several undeclared dependencies
unfortunately; e.g., 'Makefile.in' should depend on the automake script,
and 'aclocal.m4' should depend on the aclocal script (but this isn't
possible, as it would mean that distributed files depend on ones generated
at make time).  Similarly, 'Makefile.in' should depend on some of the
'lib/am/*.am' files, but does not.

Currently, the workaround to get a faithful and correct rebuild is to run

  ./bootstrap && ./config.status --recheck && make clean all

and the present commit does not change that.

* Makefile.am ($(srcdir)/t/testsuite-part.am): Don't depend on
't/list-of-tests.mk' nor on '$(handwritten_TESTS)' anymore.
($(generated_TESTS)): Likewise, and don't depend on 'Makefile.am'
either.

Signed-off-by: Stefano Lattarini 
---
 Makefile.am |   10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index dc8932d..419c152 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -379,11 +379,11 @@ $(srcdir)/t/testsuite-part.am:
 	$(AM_V_at)mv -f t/testsuite-part.tmp $@
 EXTRA_DIST += gen-testsuite-part
 
-$(generated_TESTS) $(srcdir)/t/testsuite-part.am: \
-  $(srcdir)/gen-testsuite-part \
-  t/list-of-tests.mk \
-  Makefile.am \
-  $(handwritten_TESTS)
+## The dependnecies declared here are not truly complete, but such a
+## completeness would cause more issues than it would solve.  See
+## automake bug#11347.
+$(generated_TESTS): $(srcdir)/gen-testsuite-part
+$(srcdir)/t/testsuite-part.am: $(srcdir)/gen-testsuite-part Makefile.am
 
 # Static dependencies valid for each test case.
 check_SCRIPTS = t/wrap/aclocal-$(APIVERSION) t/wrap/automake-$(APIVERSION)
-- 
1.7.9.5

bug#11347: the remake rules in the automake test suite are too greedy

[Eric Blake]

On 04/26/2012 07:10 AM, Stefano Lattarini wrote:
>> > 
> And here is a patch.  The change itself is obvious, but I'd like a review
> on the long-winded commit message.  I will push by tomorrow if there is no
> review by then.
> 

> 
> The described situation could hinder hinder on-field testing or debugging

s/hinder hinder on-field/hinder in-field/

> by users (even experienced ones) that are not automake developers; see
> for example automake bug#11347.
> 
> So we drop the explicit dependency of 't/testsuite-part.am' on the
> hand-written test cases.  (As an aside, note that this has already
> been done in Automake-NG, albeit for other reasons; see the commit
> 'v1.11b-129-g1690aca' of 23-40-2012, "[ng] build: define $(TESTS)

s/23-40-2012/2012-04-23/ (typo, plus day/month/year can be ambiguous
with month/day/year, whereas the ISO ordering of year/month/day tends to
be unambiguous).

> through a wildcard").
> 
> This is not a serious regression in the faithfulness of the Automake
> build systems, since it that already had several undeclared dependencies

s/that /unfortunately /

> unfortunately; e.g., 'Makefile.in' should depend on the automake script,

s/unfortunately//

> and 'aclocal.m4' should depend on the aclocal script (but this isn't
> possible, as it would mean that distributed files depend on ones generated
> at make time).  Similarly, 'Makefile.in' should depend on some of the
> 'lib/am/*.am' files, but does not.
> 
> Currently, the workaround to get a faithful and correct rebuild is to run
> 
>   ./bootstrap && ./config.status --recheck && make clean all
> 
> and the present commit does not change that.

> -$(generated_TESTS) $(srcdir)/t/testsuite-part.am: \
> -  $(srcdir)/gen-testsuite-part \
> -  t/list-of-tests.mk \
> -  Makefile.am \
> -  $(handwritten_TESTS)
> +## The dependnecies declared here are not truly complete, but such a

s/dependnecies/dependencies/; s/such a/such/

> +## completeness would cause more issues than it would solve.  See
> +## automake bug#11347.
> +$(generated_TESTS): $(srcdir)/gen-testsuite-part
> +$(srcdir)/t/testsuite-part.am: $(srcdir)/gen-testsuite-part Makefile.am
>  
>  # Static dependencies valid for each test case.
>  check_SCRIPTS = t/wrap/aclocal-$(APIVERSION) t/wrap/automake-$(APIVERSION)
> -- 1.7.9.5
> 

-- 
Eric Blake   ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature

bug#11345: Fwd: lex-depend-cxx automake-1.12 test failure on Mac OS X 10.7.3 (Xcode-4.3.2)

[Stefano Lattarini]

tags 11345 patch
severity 11345 minor
close 11345
thanks

On 04/26/2012 03:56 PM, Adam Mercer wrote:
> On Thu, Apr 26, 2012 at 04:42, Stefano Lattarini
>  wrote:
> 
>>> Does the attached patch solves the problem for you?
>>>
>> Oops, I forgot to add you to the THANKS file.  Consider the following
>> hunk squashed in:
> 
> Yes, that does the trick.
> 
Thanks for confirming.  I've pushed the fix to maint, and I'm closing
this bug report.

Regards,
  Stefano

bug#11347: the remake rules in the automake test suite are too greedy

[Stefano Lattarini]

tags 11347 + patch
close 11347
thanks

On 04/26/2012 04:28 PM, Eric Blake wrote:
> On 04/26/2012 07:10 AM, Stefano Lattarini wrote:
>> And here is a patch.  The change itself is obvious, but I'd like a review
>> on the long-winded commit message.
>>
> [SNIP] useful review
>
I've addressed all you nits, and pushed.  I'm thus closing this bug report.

Thanks for the feedback,
  Stefano

bug#11345: Fwd: lex-depend-cxx automake-1.12 test failure on Mac OS X 10.7.3 (Xcode-4.3.2)

[Adam Mercer]

On Thu, Apr 26, 2012 at 04:42, Stefano Lattarini
 wrote:

>> Does the attached patch solves the problem for you?
>>
> Oops, I forgot to add you to the THANKS file.  Consider the following
> hunk squashed in:

Yes, that does the trick.

Cheers

Adam

bug#11356: automake 1.12 and (C) 2011

[Peter Johansson]

Hello,

Just a tiny nit. After installing the new version (1.12) of automake I 
noticed that 'automake --version' outputs:


automake (GNU automake) 1.12
Copyright (C) 2011 Free Software Foundation, Inc.

whereas I expected it to say 'Copyright (C) 2012...'

Cheers,
Peter