bug#32150: Acknowledgement (Suggested Texinfo Source Corrections)

2018-10-23 Thread Mathieu Lirzin
Hello Paul,

Paul Hardy  writes:

> I had made my corrections on a hard copy and then entered them into
> the computer.  There were two typos that I remembered seeing when I
> read the document but didn't recall entering yesterday, and indeed I
> had not entered them.  Here they are.

Both patches were applied in commit 6624f88b2ea685e5c44c7373d01df488d1dabd19.

Thanks.

-- 
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37





bug#33029: AM_LFLAGS --prefix option breaks build-aux/ylwrap script

2018-10-23 Thread Mathieu Lirzin
Hello Sjoerd,

Sjoerd van Leent  writes:

> Using Automake 1.15.1, I attempted to create a prefix other than the
> default "yy" for usage of the Fast Lexical Analyzer Generator. The
> FLEX arguments used for this, can be set using Automake option
> AM_LFLAGS and friends. Doing this with the --prefix argument however,
> causes a side-effect which the ylwrap script fails to act on. The
> option does not only replace yy inside the generated lex.yy.c file,
> but also changes lex.yy.c to become lex..c. This behavior
> breaks the ylwrap script, as it can no longer find lex.yy.c and
> therefore no longer move and rename it to the proper location
> (breaking the build process).
>
> I managed my way around this, by forcing flex to generate a lex.yy.c
> file (adding -o lex.yy.c also to AM_LFLAGS). The solution to my mind
> is simple: if --prefix is used in the AM_LFLAGS and friends option,
> the ylwrap script should either expect this new prefix as a
> replacement token of the "yy" part of lex.yy.c, or ylwrap should add
> -o lex.yy.c on it's own initiative.
>
> I hope that you are able to aid in repairing this minor deefficiency,
> Best Regards,
> Sjoerd van Leent

I am not familiar with the details of how Flex is working but supporting
the ‘--prefix’ option seems desirable. Currently Automake has very
little manpower, so I encourage you to work on it yourself if you have
some time to devote to it.

Thanks.

-- 
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37





bug#33085: using myprog_CXXFLAGS with VPATH prevents Makefile from finding sources

2018-10-23 Thread Mathieu Lirzin
Hello Nick,

Nick Bowler  writes:

> On 10/18/18, Julien COURTAT  wrote:
>> Here's my bug report, I'm building my software out of the source tree, this
>> is called parallel build (very nice feature).
>> The way to reproduce the issue is very simple, set myprog_CXXFLAGS = -DANY
>> and VPATH=@MYDIR@ and the corresponding Makefile won't find my source file.
>> Replace myprog_CXXFLAGS by AM_CXXFLAGS and it works well.
>> Autoconf 2.69, automake 1.13.4
> [...]
>> Makefile.am :
>> bin_PROGRAMS=myprog
>> myprog_SOURCES  = Main.cpp
>> myprog_CXXFLAGS = -DANY
>> AM_CPPFLAGS  = -I@MYPROG_PATH@
>> VPATH=@MYPROG_PATH@
>
> Don't set VPATH like this.  It supersedes the definition supplied by
> Automake and is almost certainly the cause of your problems.

I agree with your analysis, so I am closing this bug.

Thanks.

-- 
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37