Re: failure in colorful tests

2007-11-13 Thread Bob Proulx 
Ralf Wildenhues wrote:
 Agreed.  Thanks.  I've applied the patch below.

Thanks!

 HP-UX 10.20 -   -   +
 HP-UX 11.23 -   -   +

This really confused me because I was getting color.  So I went back
and looked at things closely and I realized why.  Quite some years ago
I fixed my HP-UX systems.  An upgraded xterm that supported color
plus the terminfo that matched makes color work for me.  So for *me* I
am getting color output there.  But it is only because I have upgraded
the systems.  I see now that it was not a stock solution.  When I look
at a stock machine I see the same results that you are seeing.

I had forgotten I had done that!  Sorry for the bad data point.

 The results looked pretty convincing to me.  But hey, if you can show me
 what setup ANSI escape sequences break, then I'm all ears.

I was pretty happy with the ansi choice.  It was the xterm data that
confused me.

Thanks again.
Bob

Re: failure in colorful tests

2007-11-12 Thread Ralf Wildenhues 
Hi Bob,

* Bob Proulx wrote on Mon, Nov 12, 2007 at 11:44:42PM CET:
 This following automake 'make check' finishes successfully.
 
   env TERM=ansi make -C tests check TESTS=color.test
 
 However this next one has a failure.
 
   env TERM=dumb make -C tests check TESTS=color.test
 
 And this one is quite colorful! :-)
 
   env TERM=dumb VERBOSE=yes make -C tests check TESTS=color.test

Thanks!  Do we need to guard against other TERM settings, too?

Cheers,
Ralf

   * tests/color.test: Skip if TERM is `dumb'.
   Report by Bob Proulx.

diff --git a/tests/color.test b/tests/color.test
index d30d1e0..b2deb23 100755
--- a/tests/color.test
+++ b/tests/color.test
@@ -22,6 +22,10 @@
 
 . ./defs || exit 1
 
+case $TERM in
+dumb) exit 77;;
+esac
+
 set -e
 
 red=''