bug#14498: Failure with MSVC in t/yacc-bison-skeleton.sh
On 2013-05-29 11:56, Stefano Lattarini wrote: > On 05/29/2013 11:54 AM, Peter Rosin wrote: >> diff --git a/t/yacc-bison-skeleton.sh b/t/yacc-bison-skeleton.sh >> index b89d44c..3dfc83f 100644 >> --- a/t/yacc-bison-skeleton.sh >> +++ b/t/yacc-bison-skeleton.sh >> @@ -22,6 +22,7 @@ required='cc bison' >> >> cat >> configure.ac << 'END' >> AC_PROG_CC >> +AC_C_INLINE >> AC_PROG_YACC >> AC_OUTPUT >> END >> > ACK. Extra points if you add an explicative comment, like: > > AC_C_INLINE dnl Required by MSVC. Pushing this: >From d817a68e133f5bf41e1b5926d64ece7bc43ca8c3 Mon Sep 17 00:00:00 2001 From: Peter Rosin Date: Wed, 29 May 2013 12:06:17 +0200 Subject: [PATCH 2/2] tests: avoid a spurious failure with MSVC Fixes automake bug#14498. * t/yacc-bison-skeleton.sh: inline was not standardized prior to C99. Signed-off-by: Peter Rosin --- t/yacc-bison-skeleton.sh |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/t/yacc-bison-skeleton.sh b/t/yacc-bison-skeleton.sh index b89d44c..4553f7e 100644 --- a/t/yacc-bison-skeleton.sh +++ b/t/yacc-bison-skeleton.sh @@ -22,6 +22,7 @@ required='cc bison' cat >> configure.ac << 'END' AC_PROG_CC +AC_C_INLINEdnl Required by some pre-C99 compilers such as MSVC. AC_PROG_YACC AC_OUTPUT END -- 1.7.9
bug#14498: Failure with MSVC in t/yacc-bison-skeleton.sh
On 05/29/2013 11:54 AM, Peter Rosin wrote:
> On 2013-05-29 07:48, Peter Rosin wrote:
>> Hi!
>>
>> With the master branch (baf8a1c22acce0908) bison generates code with
>> a bunch of inline functions, but inline is spelled __inline with
>> MSVC, and the test fails spectacularly.
>>
>> An example error message:
>> zardoz.c(873) : error C2054: expected '(' to follow 'inline'
>>
>> $ bison --version
>> bison (GNU Bison) 2.4.2
>> Written by Robert Corbett and Richard Stallman.
>> ...
>
> The below change makes the test pass for me. Ok to push such a change?
>
> Cheers,
> Peter
>
> diff --git a/t/yacc-bison-skeleton.sh b/t/yacc-bison-skeleton.sh
> index b89d44c..3dfc83f 100644
> --- a/t/yacc-bison-skeleton.sh
> +++ b/t/yacc-bison-skeleton.sh
> @@ -22,6 +22,7 @@ required='cc bison'
>
> cat >> configure.ac << 'END'
> AC_PROG_CC
> +AC_C_INLINE
> AC_PROG_YACC
> AC_OUTPUT
> END
>
ACK. Extra points if you add an explicative comment, like:
AC_C_INLINE dnl Required by MSVC.
Thanks,
Stefano
bug#14498: Failure with MSVC in t/yacc-bison-skeleton.sh
On 2013-05-29 07:48, Peter Rosin wrote:
> Hi!
>
> With the master branch (baf8a1c22acce0908) bison generates code with
> a bunch of inline functions, but inline is spelled __inline with
> MSVC, and the test fails spectacularly.
>
> An example error message:
> zardoz.c(873) : error C2054: expected '(' to follow 'inline'
>
> $ bison --version
> bison (GNU Bison) 2.4.2
> Written by Robert Corbett and Richard Stallman.
> ...
The below change makes the test pass for me. Ok to push such a change?
Cheers,
Peter
diff --git a/t/yacc-bison-skeleton.sh b/t/yacc-bison-skeleton.sh
index b89d44c..3dfc83f 100644
--- a/t/yacc-bison-skeleton.sh
+++ b/t/yacc-bison-skeleton.sh
@@ -22,6 +22,7 @@ required='cc bison'
cat >> configure.ac << 'END'
AC_PROG_CC
+AC_C_INLINE
AC_PROG_YACC
AC_OUTPUT
END
bug#14498: Failure with MSVC in t/yacc-bison-skeleton.sh
On 2013-05-29 07:48, Peter Rosin wrote: > Hi! > > With the master branch (baf8a1c22acce0908) bison generates code with > a bunch of inline functions, but inline is spelled __inline with > MSVC, and the test fails spectacularly. The problem is the same on the micro branch (87e49f4f040c8ab). Cheers, Peter
bug#14498: Failure with MSVC in t/yacc-bison-skeleton.sh
Hi!
With the master branch (baf8a1c22acce0908) bison generates code with
a bunch of inline functions, but inline is spelled __inline with
MSVC, and the test fails spectacularly.
An example error message:
zardoz.c(873) : error C2054: expected '(' to follow 'inline'
$ bison --version
bison (GNU Bison) 2.4.2
Written by Robert Corbett and Richard Stallman.
...
Cheers,
Peter
