bug#26738: Build failures

[Mathieu Lirzin]

Mathieu Lirzin  writes:

> ‘hammer’ and ‘spanner’ are not found when running ‘make distcheck’
> because they are not ditributed in the tarball.  Those scripts are
> declared in the DEJATOOL special variable.  So I am wondering if the
> contents of this variable should be automatically distributed or not.
> If not here is a update for the test:
>
> diff --git a/t/check12.sh b/t/check12.sh
> index 34007896c..111f43318 100644
> --- a/t/check12.sh
> +++ b/t/check12.sh
> @@ -59,6 +59,7 @@ cat >> Makefile.am << 'END'
>  AUTOMAKE_OPTIONS += dejagnu
>  DEJATOOL = hammer spanner
>  AM_RUNTESTFLAGS = HAMMER=$(srcdir)/hammer SPANNER=$(srcdir)/spanner
> +EXTRA_DIST += $(DEJATOOL)
>  EXTRA_DIST += hammer.test/hammer.exp
>  EXTRA_DIST += spanner.test/spanner.exp
>  END

On second thought, I realize that distributing DEJATOOL automatically
would require handling ‘nodist_’ prefix in ‘automake’ since the content
of this variable could be generated scripts.  Given that this would
require a non negligeable amount of work, that seems more valuable to
require the package maintainers to add this variable to EXTRA_DIST
manually.

Let's apply this patch in a first step, and wait for a feature request
with a rationale before considering the other possibilty.

Commited in a0c7e40cf64d4512cc21ee5cdb9ba1341055f11c.

-- 
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37

bug#26738: Build failures

[Mathieu Lirzin]

Hello,

Mathieu Lirzin  writes:

> Mathieu Lirzin  writes:
>
>> I was able to reproduce this bug on my machine (Fedora 25) with the
>> minor development branch (v1.15.0a).  The FAILING tests are related to
>> the presence of DejaGNU on the system.  Unfortunately I have never used
>> it so it won't be easy for me to debug.  Hopefully somebody more
>> knowledgable, will be able to investigate.
>>
>> If you are only using Automake without DejaGNU, you can safely ignore
>> those failures.
>
> Here are my logs when running the "t/check12.sh", "t/check12-w.sh", and
> "t/distcheck-no-prefix-or-srcdir-override.sh" tests that were failing on
> Paul's system:

I have identified the issue

--8<---cut here---start->8---
Running target unix
Using /usr/share/dejagnu/baseboards/unix.exp as board description file for 
target.
Using /usr/share/dejagnu/config/unix.exp as generic interface file for target.
WARNING: Couldn't find tool config file for unix, using default.
Running ../../hammer.test/hammer.exp ...
ERROR: tcl error sourcing ../../hammer.test/hammer.exp.
ERROR: couldn't execute "../../hammer": no such file or directory
[...]
Running target unix
Using /usr/share/dejagnu/baseboards/unix.exp as board description file for 
target.
Using /usr/share/dejagnu/config/unix.exp as generic interface file for target.
WARNING: Couldn't find tool config file for unix, using default.
Running ../../spanner.test/spanner.exp ...
ERROR: tcl error sourcing ../../spanner.test/spanner.exp.
ERROR: couldn't execute "../../spanner": no such file or directory
--8<---cut here---end--->8---

‘hammer’ and ‘spanner’ are not found when running ‘make distcheck’
because they are not ditributed in the tarball.  Those scripts are
declared in the DEJATOOL special variable.  So I am wondering if the
contents of this variable should be automatically distributed or not.
If not here is a update for the test:

diff --git a/t/check12.sh b/t/check12.sh
index 34007896c..111f43318 100644
--- a/t/check12.sh
+++ b/t/check12.sh
@@ -59,6 +59,7 @@ cat >> Makefile.am << 'END'
 AUTOMAKE_OPTIONS += dejagnu
 DEJATOOL = hammer spanner
 AM_RUNTESTFLAGS = HAMMER=$(srcdir)/hammer SPANNER=$(srcdir)/spanner
+EXTRA_DIST += $(DEJATOOL)
 EXTRA_DIST += hammer.test/hammer.exp
 EXTRA_DIST += spanner.test/spanner.exp
 END

-- 
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37

bug#26738: Build failures

[Mathieu Lirzin]

Mathieu Lirzin  writes:

> I was able to reproduce this bug on my machine (Fedora 25) with the
> minor development branch (v1.15.0a).  The FAILING tests are related to
> the presence of DejaGNU on the system.  Unfortunately I have never used
> it so it won't be easy for me to debug.  Hopefully somebody more
> knowledgable, will be able to investigate.
>
> If you are only using Automake without DejaGNU, you can safely ignore
> those failures.

Here are my logs when running the "t/check12.sh", "t/check12-w.sh", and
"t/distcheck-no-prefix-or-srcdir-override.sh" tests that were failing on
Paul's system:

This file contains any messages produced by compilers while
running configure, to aid debugging if configure makes a mistake.

It was created by GNU Automake configure 1.15.0a, which was
generated by GNU Autoconf 2.69.  Invocation command line was

  $ ../configure --no-create --no-recursion

## - ##
## Platform. ##
## - ##

hostname = localhost.localdomain
uname -m = x86_64
uname -r = 4.11.4-200.fc25.x86_64
uname -s = Linux
uname -v = #1 SMP Wed Jun 7 18:28:00 UTC 2017

/usr/bin/uname -p = x86_64
/bin/uname -X = unknown

/bin/arch  = x86_64
/usr/bin/arch -k   = unknown
/usr/convex/getsysinfo = unknown
/usr/bin/hostinfo  = unknown
/bin/machine   = unknown
/usr/bin/oslevel   = unknown
/bin/universe  = unknown

PATH: /home/mthl/bin
PATH: /usr/local/bin
PATH: /usr/bin
PATH: /bin
PATH: /usr/local/sbin
PATH: /usr/sbin
PATH: /home/mthl/.local/bin
PATH: /home/mthl/bin


## --- ##
## Core tests. ##
## --- ##

configure:2031: checking whether make supports nested variables
configure:2048: result: yes
configure:2064: checking build system type
configure:2078: result: x86_64-pc-linux-gnu
configure:2098: checking host system type
configure:2111: result: x86_64-pc-linux-gnu
configure:2164: checking for a BSD-compatible install
configure:2232: result: /usr/bin/install -c
configure:2243: checking whether build environment is sane
configure:2298: result: yes
configure:2449: checking for a thread-safe mkdir -p
configure:2488: result: /usr/bin/mkdir -p
configure:2495: checking for gawk
configure:2511: found /usr/bin/gawk
configure:2522: result: gawk
configure:2533: checking whether make sets $(MAKE)
configure:2555: result: yes
configure:2713: checking whether ln -s works
configure:2717: result: yes
configure:2727: checking for perl
configure:2745: found /usr/bin/perl
configure:2757: result: /usr/bin/perl
configure:2769: /usr/bin/perl --version

This is perl 5, version 24, subversion 1 (v5.24.1) built for 
x86_64-linux-thread-multi
(with 68 registered patches, see perl -V for more detail)

Copyright 1987-2017, Larry Wall

Perl may be copied only under the terms of either the Artistic License or the
GNU General Public License, which may be found in the Perl 5 source kit.

Complete documentation for Perl, including FAQ lists, should be found on
this system using "man perl" or "perldoc perl".  If you have access to the
Internet, point your browser at http://www.perl.org/, the Perl Home Page.

configure:2772: $? = 0
configure:2784: checking for tex
configure:2814: result: no
configure:2822:  --version http://gnu.org/licenses/gpl.html>, 
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by David J. MacKenzie and Akim Demaille.
configure:2942: $? = 0
configure:2950: result: yes
configure:2957: checking whether autoconf works
configure:2964: cd conftest && autoconf -o /dev/null conftest.ac
configure:2967: $? = 0
configure:2976: result: yes
configure:2983: checking whether autoconf is recent enough
configure:2990: cd conftest && autoconf -o /dev/null conftest.ac
configure:2993: $? = 0
configure:3002: result: yes
configure:3009: checking whether ln works
configure:3029: result: yes
configure:3047: checking for grep that handles long lines and -e
configure:3105: result: /usr/bin/grep
configure:3110: checking for egrep
configure:3172: result: /usr/bin/grep -E
configure:3177: checking for fgrep
configure:3239: result: /usr/bin/grep -F
configure:3282: will now look for a sturdy POSIX shell, for our testsuite
configure:3318: checking for sh
configure:3336: found /usr/bin/sh
configure:3348: result: /usr/bin/sh
configure:3318: checking for sh5
configure:3351: result: no
configure:3318: checking for dash
configure:3351: result: no
configure:3318: checking for ash
configure:3351: result: no
configure:3318: checking for bash
configure:3336: found /usr/bin/bash
configure:3348: result: /usr/bin/bash
configure:3318: checking for zsh
configure:3351: result: no
configure:3318: checking for ksh
configure:3351: result: no
configure:3318: checking for pdksh
configure:3351: result: no
configure:3372: checking whether /bin/sh supports $(cmd)
configure:3382: result: yes
configure:3392: checking whether /bin/sh supports $((expr))
configure:3402: result: yes
configur

bug#26738: Build failures

[Mathieu Lirzin]

Hello Paul,

Paul Rogers  writes:

> I'm building LFS-7.10, but encountered these unexpected failures
> following the book's instructions.
> -- 
> Paul Rogers
> paulgrog...@fastmail.fm
> Rogers' Second Law: "Everything you do communicates."
> (I do not personally endorse any additions after this line. TANSTAAFL
> :-)

I was able to reproduce this bug on my machine (Fedora 25) with the
minor development branch (v1.15.0a).  The FAILING tests are related to
the presence of DejaGNU on the system.  Unfortunately I have never used
it so it won't be easy for me to debug.  Hopefully somebody more
knowledgable, will be able to investigate.

If you are only using Automake without DejaGNU, you can safely ignore
those failures.

Thanks for your report.

-- 
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37