Re: add generated files to .gitignore

2018-02-24 Thread Chet Ramey 
On 2/24/18 3:36 PM, don fong wrote:
> Eric, thanks for the tip.
> 
> my feeling is that regardless of whether these files are pushed, they
> clutter up the "git status" listing after i've done a build.

You don't have to build in the source directory.

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRUc...@case.eduhttp://tiswww.cwru.edu/~chet/

Re: add generated files to .gitignore

2018-02-24 Thread don fong 
Eric, thanks for the tip.

my feeling is that regardless of whether these files are pushed, they
clutter up the "git status" listing after i've done a build.



On Sat, Feb 24, 2018 at 11:28 AM, Eric Blake  wrote:
> On 02/24/2018 01:26 PM, Chet Ramey wrote:
>>
>> On 2/24/18 1:46 AM, don fong wrote:
>>>
>>> based on my experience creating one patch, running "make" and "make
>>> test", i found that "git status" was reporting a lot of generated and
>>> built files that i think should be ignored.
>>
>>
>> Those files aren't ever pushed to the bash git repositories (master,
>> devel).
>
>
> If Chet doesn't want to patch the primary bash.git to ignore them for
> everybody in .gitignore, you can still patch your downstream repo to ignore
> them locally by instead adding those exclusions to .git/info/exclude.
>
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.   +1-919-301-3266
> Virtualization:  qemu.org | libvirt.org

Re: add generated files to .gitignore

2018-02-24 Thread Eric Blake 

On 02/24/2018 01:26 PM, Chet Ramey wrote:

On 2/24/18 1:46 AM, don fong wrote:

based on my experience creating one patch, running "make" and "make
test", i found that "git status" was reporting a lot of generated and
built files that i think should be ignored.


Those files aren't ever pushed to the bash git repositories (master,
devel).


If Chet doesn't want to patch the primary bash.git to ignore them for 
everybody in .gitignore, you can still patch your downstream repo to 
ignore them locally by instead adding those exclusions to .git/info/exclude.


--
Eric Blake, Principal Software Engineer
Red Hat, Inc.   +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: add generated files to .gitignore

2018-02-24 Thread Chet Ramey 
On 2/24/18 1:46 AM, don fong wrote:
> based on my experience creating one patch, running "make" and "make
> test", i found that "git status" was reporting a lot of generated and
> built files that i think should be ignored.

Those files aren't ever pushed to the bash git repositories (master,
devel).

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRUc...@case.eduhttp://tiswww.cwru.edu/~chet/

Re: misleading error message from variable modifier

2018-02-24 Thread Chet Ramey 
On 2/23/18 10:20 PM, don fong wrote:
> hi folks.  i'm a bash user, who just noticed a slight anomaly.  it has
> to with the shell variable modifier ${parameter?} .  according to the
> man page, ${X?} should yield an error message and exit if X is unset,
> otherwise the value of X.  in this case,
> 
> unset X; echo ${X?}
> 
> i expect to get an error message, and indeed an error message results.
> 
> bash: X: parameter null or not set
> 
> but i think the error message is misleading.  

Thanks for the report and patch. I'll take a look.

Chet
-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRUc...@case.eduhttp://tiswww.cwru.edu/~chet/