Re: Multiple patches to fix compiler warnings
On 4/17/15 2:03 PM, Eduardo A. Bustamante López wrote: > 0001-Fix-spacing-issues-in-tests-to-make-it-easier-to-tra.patch > 0002-Fix-unclosed-double-quote.patch > 0004-Fix-declare-regression.patch > 0003-Remove-compiler-warnings.-Does-that-really-need-to-b.patch > 0005-Make-the-compiler-happy-remove-volatile.patch > 0006-Remove-unused-variables-and-functions-make-CFLAGS-Wa.patch > 0007-Make-the-compiler-happy.patch Thanks, I'll take a look. In these cases, I want the `volatile' there, even if it causes warnings, since I'm not really interested in whether the function takes a volatile parameter -- I want the compiler's guarantees about volatile variables in the function where they're declared. -- ``The lyf so short, the craft so long to lerne.'' - Chaucer ``Ars longa, vita brevis'' - Hippocrates Chet Ramey, ITS, CWRUc...@case.eduhttp://cnswww.cns.cwru.edu/~chet/
Re: Multiple patches to fix compiler warnings
On Fri, Apr 17, 2015 at 04:26:08PM -0400, Mike Frysinger wrote: > please post patches inline and as a series rather than attaching a binary > tarball. it makes review much harder when you do this. > > in fact, `git send-email` takes care of all of this for you. > -mike Makes sense, thanks! I'll resend them as a series later :-) -- Eduardo Bustamante https://dualbus.me/
Re: Multiple patches to fix compiler warnings
please post patches inline and as a series rather than attaching a binary tarball. it makes review much harder when you do this. in fact, `git send-email` takes care of all of this for you. -mike signature.asc Description: Digital signature
Multiple patches to fix compiler warnings
0001-Fix-spacing-issues-in-tests-to-make-it-easier-to-tra.patch This one attempts to remove the false positives that the different spacing output between od's causes. There's also a change for one of the unicode tests, but I'm not sure about that one. 0002-Fix-unclosed-double-quote.patch This is a simple mistake of leaving an unclosed " 0004-Fix-declare-regression.patch This one I already reported. 0003-Remove-compiler-warnings.-Does-that-really-need-to-b.patch 0005-Make-the-compiler-happy-remove-volatile.patch 0006-Remove-unused-variables-and-functions-make-CFLAGS-Wa.patch 0007-Make-the-compiler-happy.patch Fix multiple compiler warnings. -- Eduardo Bustamante https://dualbus.me/ patches.tar.gz Description: application/tar-gz
