Re: Bash-4.2-rc2 available for FTP
On 2/5/11 1:03 PM, Mike Frysinger wrote: On Wednesday, February 02, 2011 21:49:38 Chet Ramey wrote: On 2/2/11 6:27 PM, Mike Frysinger wrote: - lib/glob/smatch.c needs externs.h for mbsmbchar. seems like externs.h could do with including bashtypes.h/command.h/general.h too since it needs basic types from all of those. Or an extern declaration for mbsmbchar, to avoid having to include other files. that defeats the whole point of having a single extern line. Yes, I understand the tradeoff. -- ``The lyf so short, the craft so long to lerne.'' - Chaucer ``Ars longa, vita brevis'' - Hippocrates Chet Ramey, ITS, CWRUc...@case.eduhttp://cnswww.cns.cwru.edu/~chet/
Re: Bash-4.2-rc2 available for FTP
Am 02.02.2011 14:56, schrieb Chet Ramey: The second release candidate of bash-4.2 is now available with the URL ftp://ftp.cwru.edu/pub/bash/bash-4.2-rc2.tar.gz Thanks. Unfortunately, this version is incredibly slow. For example, it needs 20 seconds (!) to source the bash_completion file, as opposed to 0.2 seconds with 4.1-9. Counting from 1 to 1 is about 20 times slower. Maybe due to heavy debugging? Regards, Bernd -- Bernd Eggink http://sudrala.de
Re: Bash-4.2-rc2 available for FTP
On 2/2/11 11:51 AM, Bernd Eggink wrote: Am 02.02.2011 14:56, schrieb Chet Ramey: The second release candidate of bash-4.2 is now available with the URL ftp://ftp.cwru.edu/pub/bash/bash-4.2-rc2.tar.gz Thanks. Unfortunately, this version is incredibly slow. For example, it needs 20 seconds (!) to source the bash_completion file, as opposed to 0.2 seconds with 4.1-9. Counting from 1 to 1 is about 20 times slower. Maybe due to heavy debugging? Absolutely due to heavy debugging. The malloc debugging features have always been a drag on performance. -- ``The lyf so short, the craft so long to lerne.'' - Chaucer ``Ars longa, vita brevis'' - Hippocrates Chet Ramey, ITS, CWRUc...@case.eduhttp://cnswww.cns.cwru.edu/~chet/
Re: Bash-4.2-rc2 available for FTP
On Wednesday, February 02, 2011 08:56:24 Chet Ramey wrote: The second release candidate of bash-4.2 is now available with the URL ftp://ftp.cwru.edu/pub/bash/bash-4.2-rc2.tar.gz - braces.c:mkseq() is using an intmax_t type for the length in the asprintf call when it needs to be an int. a quick check of a 32bit system shows that sizeof(intmax_t) is 8 bytes which means the output most likely will get screwed up (since it'll be interpreted in the C library as 2 arguments). - lib/glob/smatch.c needs externs.h for mbsmbchar. seems like externs.h could do with including bashtypes.h/command.h/general.h too since it needs basic types from all of those. - lib/glob/smatch.c seems its STR defines could be unified with stuff in general.h - seems like lib/sh/snprintf.c should be including some header for isnan and isinf (maybe math.h ?) otherwise, some quick smoke tests show it seems to be working OK so far ... -mike signature.asc Description: This is a digitally signed message part.
Re: Bash-4.2-rc2 available for FTP
On 2/2/11 6:27 PM, Mike Frysinger wrote: On Wednesday, February 02, 2011 08:56:24 Chet Ramey wrote: The second release candidate of bash-4.2 is now available with the URL ftp://ftp.cwru.edu/pub/bash/bash-4.2-rc2.tar.gz - braces.c:mkseq() is using an intmax_t type for the length in the asprintf call when it needs to be an int. a quick check of a 32bit system shows that sizeof(intmax_t) is 8 bytes which means the output most likely will get screwed up (since it'll be interpreted in the C library as 2 arguments). Thanks. There was actually an int variable there, already assigned, but I never changed the argument to asprintf. - lib/glob/smatch.c needs externs.h for mbsmbchar. seems like externs.h could do with including bashtypes.h/command.h/general.h too since it needs basic types from all of those. Or an extern declaration for mbsmbchar, to avoid having to include other files. Chet -- ``The lyf so short, the craft so long to lerne.'' - Chaucer ``Ars longa, vita brevis'' - Hippocrates Chet Ramey, ITS, CWRUc...@case.eduhttp://cnswww.cns.cwru.edu/~chet/
