[Bug binutils/9769] New: [Build failure] tm struct tm_gmtoff field build error
This is a copy of the email I posted on binutils mailing list
http://sourceware.org/ml/binutils/2009-01/msg00252.html
Trying to compile a --enable-targets=all GDB on current cvs HEAD on cygwin,
I found a new error in src/bfd:
libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../../purecvs/bfd -I. -I. -I../../p
urecvs/bfd -I../../purecvs/bfd/../include -W -Wall -Wstrict-prototypes -Wmissing
-prototypes -Werror -g -O2 -c ../../purecvs/bfd/vmsutil.c -o vmsutil.o
../../purecvs/bfd/vmsutil.c: In function `vms_file_stats_name':
../../purecvs/bfd/vmsutil.c:249: error: structure has no member named
`tm_gmtoff '
make[3]: *** [vmsutil.lo] Error 1
245-
246- if (cdt)
247-{
248- ts = localtime (buff.st_mtime);
249: gmtoff = ts-tm_gmtoff;
250- *cdt = (long long) (((buff.st_mtim.tv_sec + gmtoff) *
VMS_GRANULARITY_FACTOR)
251- + (buff.st_mtim.tv_nsec / 100))
252- + VMS_EPOCH_OFFSET;
253-}
The failure is related to a commit by Nick Clifton dated January 15. 2009 adding
vmsutils.c file.
tm_gmtoff seems to be an optional field according to:
http://www.delorie.com/gnu/docs/glibc/libc_435.html
and some configure script do check for its presence before using it, for
instance
src/config/tcl.m4
AC_CACHE_CHECK([tm_gmtoff in struct tm], tcl_cv_member_tm_gmtoff, [
AC_TRY_COMPILE([#include time.h], [struct tm tm; tm.tm_gmtoff;],
tcl_cv_member_tm_gmtoff=yes, tcl_cv_member_tm_gmtoff=no)])
if test $tcl_cv_member_tm_gmtoff = yes ; then
AC_DEFINE(HAVE_TM_GMTOFF)
fi
Could this test be added and vmsutils.c
be updated accordingly?
Thanks in advance,
Pierre Muller
Pascal language support maintainer for GDB
--
Summary: [Build failure] tm struct tm_gmtoff field build error
Product: binutils
Version: 2.20 (HEAD)
Status: NEW
Severity: normal
Priority: P2
Component: binutils
AssignedTo: unassigned at sources dot redhat dot com
ReportedBy: muller at ics dot u-strasbg dot fr
CC: bug-binutils at gnu dot org
GCC build triplet: i686-pc-cygwin
GCC host triplet: i686-pc-cygwin
GCC target triplet: i686-pc-cygwin
http://sourceware.org/bugzilla/show_bug.cgi?id=9769
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug binutils/9769] [Build failure] tm struct tm_gmtoff field build error
--- Additional Comments From nickc at redhat dot com 2009-01-21 11:57 --- Hi Pierre, Actually I can see no good reason for using this unsupported field, so I am going to check in the attached patch to remove its use. Cheers Nick bfd/ChangeLog 2009-01-21 Nick Clifton ni...@redhat.com PR 9769 * vmsutil.c (vms_file_stats_name): Remove use of unsupported tm_gmtoff field in struct tm. -- What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED http://sourceware.org/bugzilla/show_bug.cgi?id=9769 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug binutils/9769] [Build failure] tm struct tm_gmtoff field build error
--- Additional Comments From cvs-commit at gcc dot gnu dot org 2009-01-21 11:58 --- Subject: Bug 9769 CVSROOT:/cvs/src Module name:src Changes by: ni...@sourceware.org2009-01-21 11:58:05 Modified files: bfd: ChangeLog vmsutil.c Log message: PR 9769 * vmsutil.c (vms_file_stats_name): Remove use of unsupported tm_gmtoff field in struct tm. Patches: http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/bfd/ChangeLog.diff?cvsroot=srcr1=1.4431r2=1.4432 http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/bfd/vmsutil.c.diff?cvsroot=srcr1=1.1r2=1.2 -- http://sourceware.org/bugzilla/show_bug.cgi?id=9769 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug binutils/9766] --kill-at results in wrong export names
--- Additional Comments From nickc at redhat dot com 2009-01-21 12:01 --- Created an attachment (id=3677) -- (http://sourceware.org/bugzilla/attachment.cgi?id=3677action=view) Use strrchr and check for a following digit. -- http://sourceware.org/bugzilla/show_bug.cgi?id=9766 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug binutils/9766] --kill-at results in wrong export names
--- Additional Comments From nickc at redhat dot com 2009-01-21 12:02 --- Hi Christoph, Please could you try out the uploaded patch and let me know if it works for you. Cheers Nick -- What|Removed |Added Status|NEW |WAITING http://sourceware.org/bugzilla/show_bug.cgi?id=9766 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug binutils/9743] --stub-group-size=1 does not help when linking stage1 GCC
--- Additional Comments From nickc at redhat dot com 2009-01-21 12:29 --- Hi Laurent, Since --stub-group-size=1 is the default, it is not surprising that it made no difference. --stup-group-size=1024 tells the linker to process 1024 input sections before trying to insert a stub section, which is very unlikely to help you given that you problem is that the input sections are so large. Please could you try --stub-group-size=-1, which tells the linker to place stub sections before the sections that need them. If that does not work, please try --stub-group-size=2 which tells the linker to place stub sections both before and after input sections that need them, and to group the input sections into units of 2. If neither of those options work, you could try some larger positive values (eg 4, 8, 16) but in the end this is a heuristic to find a sweet spot to place branch stubs, not a guarantee of successful linking. Cheers Nick PS. Did you try compiling your stage 1 boostrap with -mlong-calls ? This should work around the 32Mbyte offset limit of the BL instruction by making gcc load the address of a function to be called into a register first. -- What|Removed |Added Status|NEW |WAITING http://sourceware.org/bugzilla/show_bug.cgi?id=9743 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
Re: [Bug binutils/9769] [Build failure] tm struct tm_gmtoff field build error
nickc at redhat dot com sourceware-bugzi...@sourceware.org writes: Actually I can see no good reason for using this unsupported field, so I am going to check in the attached patch to remove its use. The result of localtime is now unused. Also, the use of st_mtim is nonportable, too. Andreas. -- Andreas Schwab, SuSE Labs, sch...@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 And now for something completely different. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug binutils/9769] [Build failure] tm struct tm_gmtoff field build error
--- Additional Comments From schwab at suse dot de 2009-01-21 12:43 --- Subject: Re: [Build failure] tm struct tm_gmtoff field build error nickc at redhat dot com sourceware-bugzi...@sourceware.org writes: Actually I can see no good reason for using this unsupported field, so I am going to check in the attached patch to remove its use. The result of localtime is now unused. Also, the use of st_mtim is nonportable, too. Andreas. -- http://sourceware.org/bugzilla/show_bug.cgi?id=9769 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug binutils/9769] [Build failure] tm struct tm_gmtoff field build error
--- Additional Comments From nickc at redhat dot com 2009-01-21 11:56 --- Created an attachment (id=3676) -- (http://sourceware.org/bugzilla/attachment.cgi?id=3676action=view) Remoev use of tm_gmtoff -- http://sourceware.org/bugzilla/show_bug.cgi?id=9769 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug binutils/9743] --stub-group-size=1 does not help when linking stage1 GCC
--- Additional Comments From laurent at guerby dot net 2009-01-21 13:22 --- STAGE1_CFLAGS=-O1 or --enable-stage1-checking=release are enough to workaround the linker limitation for GCC stage1. I'll try your suggestions when I get my ARM machine back online. -- http://sourceware.org/bugzilla/show_bug.cgi?id=9743 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug binutils/9743] --stub-group-size=1 does not help when linking stage1 GCC
--- Additional Comments From christophe dot lyon at st dot com 2009-01-21 16:15 --- I think there is a bug in the code that inserts the stubs: it skips .plt entries, but it seems it should not. Once your ARM machine is back, I'll try to fix it. -- http://sourceware.org/bugzilla/show_bug.cgi?id=9743 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug binutils/9769] [Build failure] tm struct tm_gmtoff field build error
--- Additional Comments From rupp at gnat dot com 2009-01-21 17:11 --- Subject: Re: [Build failure] tm struct tm_gmtoff field build error nickc at redhat dot com wrote: --- Additional Comments From nickc at redhat dot com 2009-01-21 11:57 --- Hi Pierre, Actually I can see no good reason for using this unsupported field, so I am going to check in the attached patch to remove its use. The reason for the field was so that code cross compiled on a Unix filesytem NFS mounted on VMS, could be debugged using the native VMS debugger. I'll try to rework it. -- http://sourceware.org/bugzilla/show_bug.cgi?id=9769 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
Re: [Bug binutils/9769] [Build failure] tm struct tm_gmtoff field build error
nickc at redhat dot com wrote: --- Additional Comments From nickc at redhat dot com 2009-01-21 11:57 --- Hi Pierre, Actually I can see no good reason for using this unsupported field, so I am going to check in the attached patch to remove its use. The reason for the field was so that code cross compiled on a Unix filesytem NFS mounted on VMS, could be debugged using the native VMS debugger. I'll try to rework it. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug binutils/9774] New: objdump -d loops infinitely
With the attached testcase on mips64-elf toolchain when disassambling a o32 application which crosses addresses from 0x7fff to 0x8000 objdump goes haywire and keep on disassmbling symbol at 0x800. Debugging it a bit I figured that the symbol values which are unsigned long long are read in as signed long long at bfd_elf32_swap_symbol_in() function because sign_extend_vma is set for mips in bfd. All the address calculations in objdump are done unsigned for addresses and when it encounters a symbol with value 0x8000 bfd sign extends it before putting this value into the asymbol structure and it becomes 0x8000 which is a large unsigned number and all adress comparsions which involve the sybmol value start to fail. -- Summary: objdump -d loops infinitely Product: binutils Version: 2.17 Status: NEW Severity: normal Priority: P2 Component: binutils AssignedTo: unassigned at sources dot redhat dot com ReportedBy: raj dot khem at gmail dot com CC: bug-binutils at gnu dot org GCC build triplet: i386-redhat-linux GCC host triplet: i386-redhat-linux GCC target triplet: mips64-elf http://sourceware.org/bugzilla/show_bug.cgi?id=9774 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug binutils/9774] objdump -d loops infinitely
--- Additional Comments From raj dot khem at gmail dot com 2009-01-21 19:29 --- Created an attachment (id=3678) -- (http://sourceware.org/bugzilla/attachment.cgi?id=3678action=view) shell script, generates the testcase and executes it. -- http://sourceware.org/bugzilla/show_bug.cgi?id=9774 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
