[Bug binutils/11014] New: PAGE_SIZE redefined in dlltool.c

2009-11-24 Thread jerker dot back at gmail dot com
dlltool.c(244) defines PAGE_SIZE

The PAGE_SIZE symbol is/should be defined in limits.h on a POSIX system (see
http://www.opengroup.org). NT POSIX subsystem (SUA) defines it to 0x1
(10*0x1000). In my headers PAGE_SIZE is defined as an enum and dlltool.c
generates a compiler error due to PAGE_SIZE is defined before including system
headers.

I need advise how to fix this. 
Assuming setting PAGE_SIZE to 0x1000 is preferable, we can let dlltool.c set an
explicit value after including the system headers, like this:

Index: dlltool.c
===
RCS file: /cvs/src/src/binutils/dlltool.c,v
retrieving revision 1.97
diff -d -u -p -r1.97 dlltool.c
--- dlltool.c   28 Oct 2009 17:21:36 -  1.97
+++ dlltool.c   24 Nov 2009 17:27:50 -
@@ -241,9 +241,6 @@
 
 #define show_allnames 0
 
-#define PAGE_SIZE ((bfd_vma) 4096)
-#define PAGE_MASK ((bfd_vma) (-4096))
-
 #include sysdep.h
 #include bfd.h
 #include libiberty.h
@@ -259,6 +256,9 @@
 #include stdarg.h
 #include assert.h
 
+#define PAGE_SIZE ((bfd_vma) 4096)
+#define PAGE_MASK ((bfd_vma) (-4096))
+

-- 
   Summary: PAGE_SIZE redefined in dlltool.c
   Product: binutils
   Version: 2.21 (HEAD)
Status: NEW
  Severity: normal
  Priority: P2
 Component: binutils
AssignedTo: unassigned at sources dot redhat dot com
ReportedBy: jerker dot back at gmail dot com
CC: bug-binutils at gnu dot org
 GCC build triplet: x86_64-unknown-interix6.1
  GCC host triplet: x86_64-unknown-interix6.1
GCC target triplet: x86_64-unknown-interix6.1


http://sourceware.org/bugzilla/show_bug.cgi?id=11014

--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/10144] mips/ld: non-dynamic relocations refer to dynamic symbol

2009-11-24 Thread rsandifo at nildram dot co dot uk

--- Additional Comments From rsandifo at nildram dot co dot uk  2009-11-24 
19:34 ---
The problem is that the .debug_info section in thr-objc_gc.o references
thread_cancel.  How did you compile that file?

-- 
   What|Removed |Added

 CC||rsandifo at nildram dot co
   ||dot uk


http://sourceware.org/bugzilla/show_bug.cgi?id=10144

--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug binutils/11017] New: PAGE_SIZE redefined in dlltool.c

2009-11-24 Thread jerker dot back at gmail dot com
dlltool.c(244) defines PAGE_SIZE

The PAGE_SIZE symbol is/should be defined in limits.h on a POSIX system (see
http://www.opengroup.org). NT POSIX subsystem (SUA) defines it to 0x1
(10*0x1000). In my headers PAGE_SIZE is defined as an enum and dlltool.c
generates a compiler error due to PAGE_SIZE is defined before including system
headers.

I need advise how to fix this. 
Assuming setting PAGE_SIZE to 0x1000 is preferable, we can let dlltool.c set an
explicit value after including the system headers, like this:

Index: dlltool.c
===
RCS file: /cvs/src/src/binutils/dlltool.c,v
retrieving revision 1.97
diff -d -u -p -r1.97 dlltool.c
--- dlltool.c   28 Oct 2009 17:21:36 -  1.97
+++ dlltool.c   24 Nov 2009 17:27:50 -
@@ -241,9 +241,6 @@
 
 #define show_allnames 0
 
-#define PAGE_SIZE ((bfd_vma) 4096)
-#define PAGE_MASK ((bfd_vma) (-4096))
-
 #include sysdep.h
 #include bfd.h
 #include libiberty.h
@@ -259,6 +256,9 @@
 #include stdarg.h
 #include assert.h
 
+#define PAGE_SIZE ((bfd_vma) 4096)
+#define PAGE_MASK ((bfd_vma) (-4096))
+

-- 
   Summary: PAGE_SIZE redefined in dlltool.c
   Product: binutils
   Version: 2.21 (HEAD)
Status: NEW
  Severity: normal
  Priority: P2
 Component: binutils
AssignedTo: unassigned at sources dot redhat dot com
ReportedBy: jerker dot back at gmail dot com
CC: bug-binutils at gnu dot org
 GCC build triplet: x86_64-unknown-interix6.1
  GCC host triplet: x86_64-unknown-interix6.1
GCC target triplet: x86_64-unknown-interix6.1


http://sourceware.org/bugzilla/show_bug.cgi?id=11017

--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug binutils/11017] PAGE_SIZE redefined in dlltool.c

2009-11-24 Thread hp at sourceware dot org

--- Additional Comments From hp at sourceware dot org  2009-11-24 21:39 
---
Random comment coming out of the woodwork:
I can't help thinking that you should change this and all uses to
TARGET_PAGE_SIZE and TARGET_PAGE_MASK, and the problem would probably be solved.
If you *really* need the host page size...no you don't.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=11017

--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug binutils/11016] PAGE_SIZE redefined in dlltool.c

2009-11-24 Thread hp at sourceware dot org

--- Additional Comments From hp at sourceware dot org  2009-11-24 21:41 
---


*** This bug has been marked as a duplicate of 11017 ***

-- 
   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE


http://sourceware.org/bugzilla/show_bug.cgi?id=11016

--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug binutils/11017] PAGE_SIZE redefined in dlltool.c

2009-11-24 Thread hp at sourceware dot org

--- Additional Comments From hp at sourceware dot org  2009-11-24 21:41 
---
*** Bug 11016 has been marked as a duplicate of this bug. ***

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=11017

--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug binutils/11014] PAGE_SIZE redefined in dlltool.c

2009-11-24 Thread schwab at linux-m68k dot org

--- Additional Comments From schwab at linux-m68k dot org  2009-11-24 21:42 
---


*** This bug has been marked as a duplicate of 11017 ***

-- 
   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE


http://sourceware.org/bugzilla/show_bug.cgi?id=11014

--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug binutils/11017] PAGE_SIZE redefined in dlltool.c

2009-11-24 Thread schwab at linux-m68k dot org

--- Additional Comments From schwab at linux-m68k dot org  2009-11-24 21:42 
---
*** Bug 11014 has been marked as a duplicate of this bug. ***

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=11017

--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils