Re: Untranslated strings in readelf.c
Hi Frédéric,
Several untranlated strings exist in binutils 2.20 in function
process_mips_specific of readelf.c.
Actually there seems to be a lot of places in the binutils code that
need translation macros added. I am going to check in the attached
patch in order to address this problem.
Cheers
Nick
binutils/ChangeLog
2010-04-20 Nick Clifton ni...@redhat.com
* readelf.c: Add _() macros to constant strings that are
translatable.
Index: binutils/readelf.c
===
RCS file: /cvs/src/src/binutils/readelf.c,v
retrieving revision 1.493
diff -c -3 -p -r1.493 readelf.c
*** binutils/readelf.c 15 Apr 2010 10:56:36 - 1.493
--- binutils/readelf.c 20 Apr 2010 07:11:11 -
*** static void (* byte_put) (unsigned char
*** 263,272
#define UNKNOWN -1
! #define SECTION_NAME(X) \
! ((X) == NULL ? none \
! : string_table == NULL ? no-name \
! : ((X)-sh_name = string_table_length ? corrupt \
: string_table + (X)-sh_name))
#define DT_VERSIONTAGIDX(tag) (DT_VERNEEDNUM - (tag)) /* Reverse order! */
--- 263,272
#define UNKNOWN -1
! #define SECTION_NAME(X) \
! ((X) == NULL ? _(none) \
!: string_table == NULL ? _(no-name) \
!: ((X)-sh_name = string_table_length ? _(corrupt) \
: string_table + (X)-sh_name))
#define DT_VERSIONTAGIDX(tag) (DT_VERNEEDNUM - (tag)) /* Reverse order! */
*** dump_relocations (FILE * file,
*** 1302,1308
else if (symtab_index)
{
if (symtab == NULL || symtab_index = nsyms)
! printf ( bad symbol index: %08lx, (unsigned long) symtab_index);
else
{
Elf_Internal_Sym * psym;
--- 1302,1308
else if (symtab_index)
{
if (symtab == NULL || symtab_index = nsyms)
! printf (_( bad symbol index: %08lx), (unsigned long) symtab_index);
else
{
Elf_Internal_Sym * psym;
*** decode_ARM_machine_flags (unsigned e_fla
*** 2200,2206
}
if (unknown)
! strcat (buf,, unknown);
}
static char *
--- 2200,2206
}
if (unknown)
! strcat (buf,_(, unknown));
}
static char *
*** get_machine_flags (unsigned e_flags, uns
*** 2326,2335
strcat (buf, , emb);
if (e_flags EF_PPC_RELOCATABLE)
! strcat (buf, , relocatable);
if (e_flags EF_PPC_RELOCATABLE_LIB)
! strcat (buf, , relocatable-lib);
break;
case EM_V850:
--- 2326,2335
strcat (buf, , emb);
if (e_flags EF_PPC_RELOCATABLE)
! strcat (buf, _(, relocatable));
if (e_flags EF_PPC_RELOCATABLE_LIB)
! strcat (buf, _(, relocatable-lib));
break;
case EM_V850:
*** get_machine_flags (unsigned e_flags, uns
*** 2346,2352
strcat (buf, , v850);
break;
default:
! strcat (buf, , unknown v850 architecture variant);
break;
}
break;
--- 2346,2352
strcat (buf, , v850);
break;
default:
! strcat (buf, _(, unknown v850 architecture variant));
break;
}
break;
*** get_machine_flags (unsigned e_flags, uns
*** 2402,2408
MIPS ELF does not specify EF_MIPS_MACH, it is a GNU
extension. */
break;
! default: strcat (buf, , unknown CPU); break;
}
switch ((e_flags EF_MIPS_ABI))
--- 2402,2408
MIPS ELF does not specify EF_MIPS_MACH, it is a GNU
extension. */
break;
! default: strcat (buf, _(, unknown CPU)); break;
}
switch ((e_flags EF_MIPS_ABI))
*** get_machine_flags (unsigned e_flags, uns
*** 2417,2423
This means it is likely to be an o32 file, but not for
sure. */
break;
! default: strcat (buf, , unknown ABI); break;
}
if (e_flags EF_MIPS_ARCH_ASE_MDMX)
--- 2417,2423
This means it is likely to be an o32 file, but not for
sure. */
break;
! default: strcat (buf, _(, unknown ABI)); break;
}
if (e_flags EF_MIPS_ARCH_ASE_MDMX)
*** get_machine_flags (unsigned e_flags, uns
*** 2437,2443
case E_MIPS_ARCH_32R2: strcat (buf, , mips32r2); break;
case E_MIPS_ARCH_64: strcat (buf, , mips64); break;
case E_MIPS_ARCH_64R2: strcat (buf, , mips64r2); break;
! default: strcat (buf, , unknown ISA); break;
}
break;
--- 2437,2443
case E_MIPS_ARCH_32R2: strcat (buf, , mips32r2); break;
case E_MIPS_ARCH_64: strcat (buf, , mips64); break;
case E_MIPS_ARCH_64R2: strcat (buf, , mips64r2); break;
! default: strcat (buf, _(, unknown ISA)); break;
}
break;
*** get_machine_flags (unsigned e_flags, uns
*** 2466,2472
case EF_SH2A_SH3_NOFPU: strcat (buf, , sh2a-nofpu-or-sh3-nommu); break;
case
[Bug gas/11517] Fatal error assembling ldgp for Alpha ECOFF
--- Additional Comments From nickc at redhat dot com 2010-04-20 14:33 --- Created an attachment (id=4736) -- (http://sourceware.org/bugzilla/attachment.cgi?id=4736action=view) Make GPDISP relocs non-PC-relative -- http://sourceware.org/bugzilla/show_bug.cgi?id=11517 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gas/11517] Fatal error assembling ldgp for Alpha ECOFF
--- Additional Comments From nickc at redhat dot com 2010-04-20 14:34 --- Hi Rainer, The uploaded patch fixes this problem for me, but since I no expert on this particular architecture I am not sure if it is the right solution. What do you think ? Cheers Nick -- What|Removed |Added Status|NEW |WAITING http://sourceware.org/bugzilla/show_bug.cgi?id=11517 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gas/11507] altmacro: wrong string interpretation
--- Additional Comments From nickc at redhat dot com 2010-04-20 15:53 --- Created an attachment (id=4737) -- (http://sourceware.org/bugzilla/attachment.cgi?id=4737action=view) Fix parsing of LOCAL inside a string -- http://sourceware.org/bugzilla/show_bug.cgi?id=11507 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug binutils/11512] addr2line displays frong filename for GCC app compiled with -gcoff option
--- Additional Comments From nickc at redhat dot com 2010-04-20 17:10 --- Created an attachment (id=4740) -- (http://sourceware.org/bugzilla/attachment.cgi?id=4740action=view) Add section address to symbol's value when looking up filenames -- http://sourceware.org/bugzilla/show_bug.cgi?id=11512 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug binutils/11512] addr2line displays frong filename for GCC app compiled with -gcoff option
--- Additional Comments From nickc at redhat dot com 2010-04-20 17:12 --- Hi dvidvitop, I have uploaded a patch that *might* resolve the problem for you. Please try it out and let me know how you get on. If the patch does not work, please could you include some more detailed information on how to reproduce the problem. A small working example, based on object files not C++ source files, would be ideal. Cheers Nick -- What|Removed |Added Status|NEW |WAITING http://sourceware.org/bugzilla/show_bug.cgi?id=11512 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug binutils/11512] addr2line displays frong filename for GCC app compiled with -gcoff option
--- Additional Comments From dzidzitop at lavabit dot com 2010-04-20 17:32 --- Thanks Nick, but the patch is unlikely to help. The bug is in the other binutils program - addr2line. This patch changes something within the objdump program. Actually, the bug is somewhere inside the BFD library. I see now how to create attachments here. I will submit the executable with reveals the bug. Addresses to test the behaviour of the addr2line are in the list below (function names are obtained by means of custom manipulating with BFD): afc::backtrace(void**, unsigned int) 0x402c97 at dyncast.cc:491 afc::StackTrace::StackTrace() 0x402e92at dyncast.cc:527 f() 0x401613 at dyncast.cc:23 g() 0x401675 at dyncast.cc:30 main 0x4016f8 at dyncast.cc:34 _onexit 0x4010db at dyncast.cc mainCRTStartup 0x401178 at dyncast.cc unknown 0x7c817077 at unknown source Correct file names contain stack_trace_win32.cpp and StackTrace.cpp in the path. -- What|Removed |Added Status|WAITING |NEW http://sourceware.org/bugzilla/show_bug.cgi?id=11512 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug binutils/11512] addr2line displays frong filename for GCC app compiled with -gcoff option
--- Additional Comments From dzidzitop at lavabit dot com 2010-04-20 18:05 --- Created an attachment (id=4741) -- (http://sourceware.org/bugzilla/attachment.cgi?id=4741action=view) A file to demonstrate the bug Forget about previous application. It is too large to be sumbited here. Attached is a tiny program with itself displays the address of a function f(). It is: 004013C0 When I use addr2line to obtain the filename and the line number for it I get: C:\Projects\AFC\bbb\Debugaddr2line -e bbb.exe 0x004013C0 cygming-crtend.c:0 -- http://sourceware.org/bugzilla/show_bug.cgi?id=11512 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug binutils/11512] addr2line displays frong filename for GCC app compiled with -gcoff option
-- What|Removed |Added Attachment #4741 is|0 |1 obsolete|| http://sourceware.org/bugzilla/show_bug.cgi?id=11512 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug binutils/11512] addr2line displays frong filename for GCC app compiled with -gcoff option
--- Additional Comments From dzidzitop at lavabit dot com 2010-04-20 18:08 --- Created an attachment (id=4742) -- (http://sourceware.org/bugzilla/attachment.cgi?id=4742action=view) A file to demonstrate the bug -- http://sourceware.org/bugzilla/show_bug.cgi?id=11512 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug binutils/11512] addr2line displays frong filename for GCC app compiled with -gcoff option
-- What|Removed |Added Attachment #4742|A file to demonstrate the |A file to demonstrate the description|bug |bug (the name of the file ||displayed by addr2line ||should be bbb.cpp) http://sourceware.org/bugzilla/show_bug.cgi?id=11512 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gas/11509] Strange evaluation of symbol containing register
--- Additional Comments From hjl dot tools at gmail dot com 2010-04-20 21:17 --- This test failed: [...@gnu-6 pr11509]$ cat 1.s .intel_syntax noprefix .eqv param, ebp-4 [...@gnu-6 pr11509]$ ./as --32 -o 1.o 1.s 1.s: Assembler messages: 1.s:3: Error: can't make global register symbol `param' [...@gnu-6 pr11509]$ I think it is a bad idea to use .eqv param, ebp-4. -- http://sourceware.org/bugzilla/show_bug.cgi?id=11509 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
