[Bug gold/14309] New: gold doesn't build with gcc 4.1.3

2012-06-29 Thread jakub at redhat dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=14309

 Bug #: 14309
   Summary: gold doesn't build with gcc 4.1.3
   Product: binutils
   Version: unspecified
Status: NEW
  Severity: normal
  Priority: P2
 Component: gold
AssignedTo: i...@airs.com
ReportedBy: ja...@redhat.com
CC: ccout...@google.com
Classification: Unclassified


gold/README says:
The gold source code uses templates heavily.  Building it requires a
recent version of g++.  g++ 4.0.3 and 4.1.3 are known to work.  g++
3.2, 3.4.3, and 4.1.2 are known to fail.
and I used to be able to build 2.22.52.0.1 just fine with gcc-4.1.2-RH (which
is based on 137441 of FSF branches/gcc-4_1-branch (no libstdc++ changes on that
branch after that revision).  But 2.22.52.0.4 no longer builds with it:

/usr/lib/gcc/i386-redhat-linux/4.1.2/../../../../include/c++/4.1.2/tr1/hashtable:
In instantiation of 'Internal::hash_code_baselong long int, std::pairconst
long long int, gold::Gdb_index_info_reader::Declaration_pair,
Internal::extract1ststd::pairconst long long int,
gold::Gdb_index_info_reader::Declaration_pair , std::equal_tolong long int,
std::tr1::hashlong long int, Internal::mod_range_hashing,
Internal::default_ranged_hash, false':
/usr/lib/gcc/i386-redhat-linux/4.1.2/../../../../include/c++/4.1.2/tr1/hashtable:1014:
  instantiated from 'std::tr1::hashtablelong long int, std::pairconst long
long int, gold::Gdb_index_info_reader::Declaration_pair,
std::allocatorstd::pairconst long long int,
gold::Gdb_index_info_reader::Declaration_pair ,
Internal::extract1ststd::pairconst long long int,
gold::Gdb_index_info_reader::Declaration_pair , std::equal_tolong long int,
std::tr1::hashlong long int, Internal::mod_range_hashing,
Internal::default_ranged_hash, Internal::prime_rehash_policy, false, false,
true'
/usr/lib/gcc/i386-redhat-linux/4.1.2/../../../../include/c++/4.1.2/tr1/unordered_map:63:
  instantiated from 'std::tr1::unordered_maplong long int,
gold::Gdb_index_info_reader::Declaration_pair, std::tr1::hashlong long int,
std::equal_tolong long int, std::allocatorstd::pairconst long long int,
gold::Gdb_index_info_reader::Declaration_pair , false'
gdb-index.cc:292:   instantiated from here
/usr/lib/gcc/i386-redhat-linux/4.1.2/../../../../include/c++/4.1.2/tr1/hashtable:863:
error: 'Internal::hash_code_baseKey, Value, ExtractKey, Equal, H1, H2,
Internal::default_ranged_hash, false::m_h1' has incomplete type
/usr/lib/gcc/i386-redhat-linux/4.1.2/../../../../include/c++/4.1.2/tr1/functional:1101:
error: declaration of 'struct std::tr1::hashlong long int'
gdb-index.cc: In constructor 'std::tr1::unordered_mapKey, T, Hash, Pred,
Alloc, cache_hash_code::unordered_map(typename std::tr1::hashtableKey,
std::pairconst Key, T, Alloc, Internal::extract1ststd::pairconst Key, T ,
Pred, Hash, Internal::mod_range_hashing, Internal::default_ranged_hash,
Internal::prime_rehash_policy, cache_hash_code, false, true::size_type, const
typename std::tr1::hashtableKey, std::pairconst Key, T, Alloc,
Internal::extract1ststd::pairconst Key, T , Pred, Hash,
Internal::mod_range_hashing, Internal::default_ranged_hash,
Internal::prime_rehash_policy, cache_hash_code, false, true::hasher, const
typename std::tr1::hashtableKey, std::pairconst Key, T, Alloc,
Internal::extract1ststd::pairconst Key, T , Pred, Hash,
Internal::mod_range_hashing, Internal::default_ranged_hash,
Internal::prime_rehash_policy, cache_hash_code, false, true::key_equal, const
typename std::tr1::hashtableKey, std::pairconst Key, T, Alloc,
Internal::extract1ststd::pairconst Key, T , Pred, Hash,
Internal::mod_range_hashing, Internal::default_ranged_hash,
Internal::prime_rehash_policy, cache_hash_code, false, true::allocator_type)
[with Key = long long int, T = gold::Gdb_index_info_reader::Declaration_pair,
Hash = std::tr1::hashlong long int, Pred = std::equal_tolong long int,
Alloc = std::allocatorstd::pairconst long long int,
gold::Gdb_index_info_reader::Declaration_pair , bool cache_hash_code =
false]':
gdb-index.cc:189: error: invalid use of undefined type 'struct
std::tr1::hashlong long int'
/usr/lib/gcc/i386-redhat-linux/4.1.2/../../../../include/c++/4.1.2/tr1/functional:1101:
error: declaration of 'struct std::tr1::hashlong long int'
/usr/lib/gcc/i386-redhat-linux/4.1.2/../../../../include/c++/4.1.2/tr1/hashtable:
In member function 'size_t Internal::hash_code_baseKey, Value, ExtractKey,
Equal, H1, H2, Internal::default_ranged_hash, false::m_hash_code(const Key)
const [with Key = long long int, Value = std::pairconst long long int,
gold::Gdb_index_info_reader::Declaration_pair, ExtractKey =
Internal::extract1ststd::pairconst long long int,
gold::Gdb_index_info_reader::Declaration_pair , Equal = std::equal_tolong
long int, H1 = std::tr1::hashlong long int, H2 =
Internal::mod_range_hashing]':
/usr/lib/gcc/i386-redhat-linux/4.1.2/../../../../include/c++/4.1.2/tr1/hashtable:1541:
  instantiated from 'typename 

[Bug binutils/14302] ar mishandles 4GB files

2012-06-29 Thread nickc at redhat dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=14302

Nick Clifton nickc at redhat dot com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||nickc at redhat dot com
 Resolution||FIXED

--- Comment #5 from Nick Clifton nickc at redhat dot com 2012-06-29 13:02:52 
UTC ---
Hi Francois,

  Thanks for the bug report and patch, and please accept my apologies in
getting round to reviewing it.  The patch itself is fine, although there are a
couple of places where a comment needs to be updated, and a couple of places
where there are now redundant type cases.  I have taken care of both of these
things and applied your patch.

Cheers
  Nick

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug binutils/14302] ar mishandles 4GB files

2012-06-29 Thread cvs-commit at gcc dot gnu.org
http://sourceware.org/bugzilla/show_bug.cgi?id=14302

--- Comment #4 from cvs-commit at gcc dot gnu.org cvs-commit at gcc dot 
gnu.org 2012-06-29 12:59:54 UTC ---
CVSROOT:/cvs/src
Module name:src
Changes by:ni...@sourceware.org2012-06-29 12:59:49

Modified files:
binutils   : ChangeLog ar.c bucomm.c 

Log message:
PR binutils/14302
* bucomm.c (print_arelt_descr): Correctly report the archive size
field (for 'ar tv').
* ar.c (print_contents): Use correct types for archive element
sizes (for 'ar p').
(extract_file): Likewise (for 'ar x').

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/binutils/ChangeLog.diff?cvsroot=srcr1=1.1918r2=1.1919
http://sourceware.org/cgi-bin/cvsweb.cgi/src/binutils/ar.c.diff?cvsroot=srcr1=1.84r2=1.85
http://sourceware.org/cgi-bin/cvsweb.cgi/src/binutils/bucomm.c.diff?cvsroot=srcr1=1.45r2=1.46

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/14189] --gc-sections doesn't work

2012-06-29 Thread nickc at redhat dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=14189

--- Comment #5 from Nick Clifton nickc at redhat dot com 2012-06-29 13:23:13 
UTC ---
Created attachment 6496
  -- http://sourceware.org/bugzilla/attachment.cgi?id=6496
Do not increment refcount for locally bound symbols.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/14189] --gc-sections doesn't work

2012-06-29 Thread nickc at redhat dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=14189

Nick Clifton nickc at redhat dot com changed:

   What|Removed |Added

 Status|NEW |WAITING
 CC||nickc at redhat dot com

--- Comment #6 from Nick Clifton nickc at redhat dot com 2012-06-29 13:26:16 
UTC ---
Hi Michael, Hi Ronald,

  Please could you try out the uploaded patch and let me know if it works for
you ?

Cheers
  Nick

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


gas patch for non-octet processors

2012-06-29 Thread jnielsen
The attached patches correct an issue that exists in gas. The problem is 
general but only manifests itself when OCTETS_PER_BYTE  1. I have found 
the problem in binutils 2.22 in connection with TI C4x (i.e. ./configure 
--target=c4x-coff).

Function frag_offset_fixed_p in frags.[ch] returns an offset through its 
last parameter. The parameter type is bfd_vma which is unsigned. The only 
calls to the function are in expr.c; the offset is returned to local 
variables frag_off which are also of type bfd_vma. The variables frag_off 
are divided by OCTETS_PER_BYTE; the problem is that these divisions are 
unsigned as a result of the use of bfd_vma. Dividing these offsets must be 
done signed. No actual division takes place when OCTETS_PER_BYTE = 1 so 
this problem only manifests itself when OCTETS_PER_BYTE  1.

These uses of bfd_vma are the only ones in the three sources expr.c, 
frags.c, frags.h. I believe all these uses of bfd_vma should be changed to 
offsetT. This will be more consistent with the definitions of the struct 
members used in frag_offset_fixed_p and the fact that the returned value 
is supposed to be an offset; it also makes the divisions produce the 
correct values when OCTETS_PER_BYTE  1.

Please consider these patches for future binutils releases. The revisions 
of the original expr.c, frags.c, and frags.h are respectively 1.90, 
1.30.2.1, and 1.24.4.1.

Thanks,
Johan Olmutz Nielsen

--- expr.1.90.c 2011-03-17 11:59:29.0 +0100
+++ expr.c  2012-06-22 12:33:40.531010600 +0200
@@ -1746,7 +1746,7 @@
   while (op_left != O_illegal  op_rank[(int) op_left]  rank)
 {
   segT rightseg;
-  bfd_vma frag_off;
+  offsetT frag_off;
 
   input_line_pointer += op_chars;  /* - after operator.  */
 
@@ -2030,7 +2030,7 @@
   valueT left, right;
   segT seg_left, seg_right;
   fragS *frag_left, *frag_right;
-  bfd_vma frag_off;
+  offsetT frag_off;
 
   switch (op)
 {

--- frags.1.30.2.1.c2011-11-21 10:29:28.0 +0100
+++ frags.c 2012-06-22 12:23:46.886766700 +0200
@@ -394,10 +394,10 @@
not already accounted for in the frag FR_ADDRESS.  */
 
 bfd_boolean
-frag_offset_fixed_p (const fragS *frag1, const fragS *frag2, bfd_vma 
*offset)
+frag_offset_fixed_p (const fragS *frag1, const fragS *frag2, offsetT 
*offset)
 {
   const fragS *frag;
-  bfd_vma off;
+  offsetT off;
 
   /* Start with offset initialised to difference between the two frags.
  Prior to assigning frag addresses this will be zero.  */

--- frags.1.24.4.1.h2011-11-21 10:29:28.0 +0100
+++ frags.h 2012-06-22 12:23:02.655089200 +0200
@@ -151,6 +151,6 @@
offsetT offset,
char *opcode);
 
-bfd_boolean frag_offset_fixed_p (const fragS *, const fragS *, bfd_vma 
*);
+bfd_boolean frag_offset_fixed_p (const fragS *, const fragS *, offsetT 
*);
 
 #endif /* FRAGS_H */

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/14189] --gc-sections doesn't work

2012-06-29 Thread michael.tremer at ipfire dot org
http://sourceware.org/bugzilla/show_bug.cgi?id=14189

--- Comment #7 from Michael Tremer michael.tremer at ipfire dot org 
2012-06-29 14:59:46 UTC ---
Hi Nick,

I can confirm that the patch fixes the problem over here. The build of systemd
runs through without any assertion errors.

Thank you very much.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug gas/14263] »val« may be used uninitialized in this function tc-arm.c parse_operands()

2012-06-29 Thread bruck.michael at googlemail dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=14263

--- Comment #3 from Michael Bruck bruck.michael at googlemail dot com 
2012-06-29 15:00:39 UTC ---
(In reply to comment #2)
 Hi Michael,
 
   I am unable to reproduce this problem locally, but the fix seems obvious. 
 Please could you confirm that the uploaded patch allows you to build the
 toolchain and if it does then I will check it in.
 
 Cheers
   Nick

Yes, this fixes it. (Same change I made to get around it.)

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug gas/14263] »val« may be used uninitialized in this function tc-arm.c parse_operands()

2012-06-29 Thread cvs-commit at gcc dot gnu.org
http://sourceware.org/bugzilla/show_bug.cgi?id=14263

--- Comment #4 from cvs-commit at gcc dot gnu.org cvs-commit at gcc dot 
gnu.org 2012-06-29 15:15:53 UTC ---
CVSROOT:/cvs/src
Module name:src
Changes by:ni...@sourceware.org2012-06-29 15:15:48

Modified files:
gas: ChangeLog 
gas/config : tc-arm.c 

Log message:
PR gas/14263
* config/tc-arm.c (parse_operands): Initialise val.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/ChangeLog.diff?cvsroot=srcr1=1.4759r2=1.4760
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/config/tc-arm.c.diff?cvsroot=srcr1=1.521r2=1.522

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug gas/14263] »val« may be used uninitialized in this function tc-arm.c parse_operands()

2012-06-29 Thread nickc at redhat dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=14263

Nick Clifton nickc at redhat dot com changed:

   What|Removed |Added

 Status|WAITING |RESOLVED
 Resolution||FIXED

--- Comment #4 from cvs-commit at gcc dot gnu.org cvs-commit at gcc dot 
gnu.org 2012-06-29 15:15:53 UTC ---
CVSROOT:/cvs/src
Module name:src
Changes by:ni...@sourceware.org2012-06-29 15:15:48

Modified files:
gas: ChangeLog 
gas/config : tc-arm.c 

Log message:
PR gas/14263
* config/tc-arm.c (parse_operands): Initialise val.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/ChangeLog.diff?cvsroot=srcr1=1.4759r2=1.4760
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/config/tc-arm.c.diff?cvsroot=srcr1=1.521r2=1.522

--- Comment #5 from Nick Clifton nickc at redhat dot com 2012-06-29 15:16:39 
UTC ---
Patch applied.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug gas/14263] »val« may be used uninitialized in this function tc-arm.c parse_operands()

2012-06-29 Thread cvs-commit at gcc dot gnu.org
http://sourceware.org/bugzilla/show_bug.cgi?id=14263

Nick Clifton nickc at redhat dot com changed:

   What|Removed |Added

 Status|WAITING |RESOLVED
 Resolution||FIXED

--- Comment #5 from Nick Clifton nickc at redhat dot com 2012-06-29 15:16:39 
UTC ---
Patch applied.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/14189] --gc-sections doesn't work

2012-06-29 Thread cvs-commit at gcc dot gnu.org
http://sourceware.org/bugzilla/show_bug.cgi?id=14189

--- Comment #8 from cvs-commit at gcc dot gnu.org cvs-commit at gcc dot 
gnu.org 2012-06-29 15:20:44 UTC ---
CVSROOT:/cvs/src
Module name:src
Changes by:ni...@sourceware.org2012-06-29 15:20:31

Modified files:
bfd: ChangeLog elf32-arm.c 

Log message:
PR ld/14189
* elf32-arm.c (elf32_arm_check_relocs): Do not increment refcount
for locally bound symbols.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/ChangeLog.diff?cvsroot=srcr1=1.5737r2=1.5738
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elf32-arm.c.diff?cvsroot=srcr1=1.295r2=1.296

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/14189] --gc-sections doesn't work

2012-06-29 Thread nickc at redhat dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=14189

Nick Clifton nickc at redhat dot com changed:

   What|Removed |Added

 Status|WAITING |RESOLVED
 Resolution||FIXED

--- Comment #8 from cvs-commit at gcc dot gnu.org cvs-commit at gcc dot 
gnu.org 2012-06-29 15:20:44 UTC ---
CVSROOT:/cvs/src
Module name:src
Changes by:ni...@sourceware.org2012-06-29 15:20:31

Modified files:
bfd: ChangeLog elf32-arm.c 

Log message:
PR ld/14189
* elf32-arm.c (elf32_arm_check_relocs): Do not increment refcount
for locally bound symbols.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/ChangeLog.diff?cvsroot=srcr1=1.5737r2=1.5738
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elf32-arm.c.diff?cvsroot=srcr1=1.295r2=1.296

--- Comment #9 from Nick Clifton nickc at redhat dot com 2012-06-29 15:21:53 
UTC ---
Patch applied.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/14189] --gc-sections doesn't work

2012-06-29 Thread cvs-commit at gcc dot gnu.org
http://sourceware.org/bugzilla/show_bug.cgi?id=14189

Nick Clifton nickc at redhat dot com changed:

   What|Removed |Added

 Status|WAITING |RESOLVED
 Resolution||FIXED

--- Comment #9 from Nick Clifton nickc at redhat dot com 2012-06-29 15:21:53 
UTC ---
Patch applied.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/14189] --gc-sections doesn't work

2012-06-29 Thread ronald.wahl at raritan dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=14189

--- Comment #10 from Ronald Wahl ronald.wahl at raritan dot com 2012-06-29 
15:31:57 UTC ---
The patch works here as well. Thanks!

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug gas/14315] New: Inconsistent .weak and .comm directives

2012-06-29 Thread hjl.tools at gmail dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=14315

 Bug #: 14315
   Summary: Inconsistent .weak and .comm directives
   Product: binutils
   Version: 2.23 (HEAD)
Status: NEW
  Severity: normal
  Priority: P2
 Component: gas
AssignedTo: unassig...@sourceware.org
ReportedBy: hjl.to...@gmail.com
Classification: Unclassified


[hjl@gnu-6 secondary-1]$ cat w1.s
.weak foobar
.comm foobar,30
[hjl@gnu-6 secondary-1]$ make w1.o
./as   -o w1.o w1.s
[hjl@gnu-6 secondary-1]$ cat w2.s
.comm foobar,30
.weak foobar
[hjl@gnu-6 secondary-1]$ make w2.o
./as   -o w2.o w2.s
w2.s: Assembler messages:
w2.s: Error: symbol `foobar' can not be both weak and common
make: *** [w2.o] Error 1
[hjl@gnu-6 secondary-1]$

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug gas/14315] Inconsistent .weak and .comm directives

2012-06-29 Thread hjl.tools at gmail dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=14315

--- Comment #1 from H.J. Lu hjl.tools at gmail dot com 2012-06-30 00:34:13 
UTC ---
This works for me:

diff --git a/gas/config/obj-elf.c b/gas/config/obj-elf.c
index f9da1ee..08d337a 100644
--- a/gas/config/obj-elf.c
+++ b/gas/config/obj-elf.c
@@ -350,6 +350,11 @@ elf_common_parse (int ignore ATTRIBUTE_UNUSED, symbolS
*symbolP, addressT size)
 }
 }

+  /* Double check weak symbols.  */
+  if (S_IS_WEAK (symbolP))
+as_bad (_(symbol `%s' can not be both weak and common),
+S_GET_NAME (symbolP));
+
   if (is_local)
 {
   bss_alloc (symbolP, size, align);

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug binutils/14302] ar mishandles 4GB files

2012-06-29 Thread fgouget at codeweavers dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=14302

--- Comment #6 from Francois Gouget fgouget at codeweavers dot com 2012-06-30 
00:54:00 UTC ---
Thanks for tweaking the patch so it could be committed.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug gold/14316] New: gold build failure with recent GCC trunk because of -Werror=unused-local-typedefs

2012-06-29 Thread ai.azuma at gmail dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=14316

 Bug #: 14316
   Summary: gold build failure with recent GCC trunk because of
-Werror=unused-local-typedefs
   Product: binutils
   Version: unspecified
Status: NEW
  Severity: normal
  Priority: P2
 Component: gold
AssignedTo: i...@airs.com
ReportedBy: ai.az...@gmail.com
CC: ccout...@google.com
Classification: Unclassified


Recently, GCC has introduced a new kind of warning flags
`-Werror=unused-local-typedefs'
(http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33255), which warns about unused
local typedefs. And since GCC 4.8 (2012-05-04) it is enabled by `-Wall'. So,
warnings are treated as errors during the build of gold because some of gold
sources have unused local typedefs, and `-Wall' and `-Werror' are enabled.

Offending lines (of 2012-06-29 daily snapshot) are
  -gold/common.cc, line 225
  -gold/common.cc, line 226
  -gold/dwarf_reader.cc, line 824
  -gold/ehframe.cc, line 634
  -gold/incremental.cc, line 2731
  -gold/powerpc.cc, line 1974
  -gold/arm.cc, line 3256
  -gold/arm.cc, line 5212
  -gold/arm.cc, line 10993

If all the offending lines are just commented out, gold is successfully built.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils