[Bug gas/14837] New: Variable passed to printf-like function without format argument

2012-11-13 Thread agarcia at igalia dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=14837

 Bug #: 14837
   Summary: Variable passed to printf-like function without format
argument
   Product: binutils
   Version: 2.23
Status: NEW
  Severity: minor
  Priority: P2
 Component: gas
AssignedTo: unassig...@sourceware.org
ReportedBy: agar...@igalia.com
Classification: Unclassified


gcc complains because as_warn() is receiving a variable without a format
argument.

In this case none of the 3 possible values of the variable is dangerous
(they're set a few lines earlier in the same function) but gcc complains
anyway:

config/tc-z80.c: In function 'wrong_mach':
config/tc-z80.c:470:5: error: format not a string literal and no format
arguments [-Werror=format-security]

This patch fixes the warning:

--- tc-z80.c.orig   2012-11-13 15:20:18.0 +
+++ tc-z80.c2012-11-13 15:21:49.0 +
@@ -467,7 +467,7 @@
   if (ins_type  ins_err)
 error (_(p));
   else
-as_warn (_(p));
+as_warn (%s, _(p));
 }

 static void

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/14272] gold links, but bfd fails with: hidden symbol `.LTHUNK116.32732' isn't defined

2012-11-13 Thread hjl.tools at gmail dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=14272

--- Comment #17 from H.J. Lu hjl.tools at gmail dot com 2012-11-13 18:07:03 
UTC ---
Please checkout hjl/lto/master branch at

http://git.kernel.org/?p=linux/kernel/git/hjl/binutils.git;a=summary

with GCC 4.7 and run LTO tests. If this fix is reverted, I got

Executing on host: sh -c {gcc
-B/export/build/gnu/binutils-lto/build-x86_64-linux/ld/tmpdir/gas/
-B/export/build/gnu/binutils-lto/build-x86_64-linux/ld/tmpdir/ld/
-L/usr/local/x86_64-unknown-linux-gnu/lib64 -L/usr/local/lib64 -L/lib64
-L/usr/lib64 -L/usr/local/x86_64-unknown-linux-gnu/lib -L/usr/local/lib -L/lib
-L/usr/lib -O2 -flto -fuse-linker-plugin tmpdir/pr12365a.o tmpdir/pr12365b.o
tmpdir/pr12365c.o 21}  /dev/null ld.tmp (timeout = 300)
spawn [open ...]^M
`my_bcopy' referenced in section `.text.startup' of
/tmp/ccg9NqSw.ltrans0.ltrans.o: defined in discarded section `.text' of
tmpdir/pr12365c.o (symbol from plugin)
collect2: error: ld returned 1 exit status
`my_bcopy' referenced in section `.text.startup' of
/tmp/ccg9NqSw.ltrans0.ltrans.o: defined in discarded section `.text' of
tmpdir/pr12365c.o (symbol from plugin)
collect2: error: ld returned 1 exit status
FAIL: PR ld/12365

The testcase is

http://git.kernel.org/?p=linux/kernel/git/hjl/binutils.git;a=patch;h=89f3af62899b5527f08a491ec9297578d7f8b032

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/14272] gold links, but bfd fails with: hidden symbol `.LTHUNK116.32732' isn't defined

2012-11-13 Thread hjl.tools at gmail dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=14272

--- Comment #18 from H.J. Lu hjl.tools at gmail dot com 2012-11-13 18:11:59 
UTC ---
After the fix, the error message becomes:

Executing on host: sh -c {gcc
-B/export/build/gnu/binutils-lto/build-x86_64-linux/ld/tmpdir/gas/
-B/export/build/gnu/binutils-lto/build-x86_64-linux/ld/tmpdir/ld/
-L/usr/local/x86_64-unknown-linux-gnu/lib64 -L/usr/local/lib64 -L/lib64
-L/usr/lib64 -L/usr/local/x86_64-unknown-linux-gnu/lib -L/usr/local/lib -L/lib
-L/usr/lib -O2 -flto -fuse-linker-plugin tmpdir/pr12365a.o tmpdir/pr12365b.o
tmpdir/pr12365c.o 21}  /dev/null ld.tmp (timeout = 300)
spawn [open ...]^M
/tmp/cc6BNJK9.ltrans0.ltrans.o: In function `main':
cc6BNJK9.ltrans0.o:(.text.startup+0x197): undefined reference to `my_bcopy'
collect2: error: ld returned 1 exit status
/tmp/cc6BNJK9.ltrans0.ltrans.o: In function `main':
cc6BNJK9.ltrans0.o:(.text.startup+0x197): undefined reference to `my_bcopy'
collect2: error: ld returned 1 exit status
PASS: PR ld/12365

The difference is my_bcopy should be simply undefined, not defined in
a discarded section.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/13557] Undef. ref. err. when linking with slim LTO obj. in static lib. (mingw32 target)

2012-11-13 Thread d.g.gorbachev at gmail dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=13557

--- Comment #2 from Dmitry Gorbachev d.g.gorbachev at gmail dot com 
2012-11-13 18:42:31 UTC ---
Created attachment 6731
  -- http://sourceware.org/bugzilla/attachment.cgi?id=6731
Another testcase

/tmp/cc8ikw6t.ltrans0.ltrans.o:cc8ikw6t.ltrans0.o:(.text+0xc): undefined
reference to `foo'

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/12548] anonymous version scripts no longer working with binutils 2.21

2012-11-13 Thread pashev.igor at gmail dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=12548

--- Comment #14 from Igor Pashev pashev.igor at gmail dot com 2012-11-13 
21:10:32 UTC ---
I think I've fixed this.

The root of the problem is equivalent to this version script:


= 8 
# Builtin:
base name {
global:
_PROCEDURE_LINKAGE_TABLE_;
_edata;
...
}

# Real mapfile:
{
...
}
= 8 

So for anonymous version tag we just set base version: (See patch)



Test:


# cat test.c
int foo()
{
return 17;
}

const char *bar()
{
return bar;
}
# cat map
{
global:
foo;
local:
bar;
};
# gcc -fpic -c test.c -o lib.o -O0
# ld/ld-new -o lib.so lib.o -shared --version-script=map
# objdump -T lib.so 

lib.so: file format elf64-x86-64-sol2

DYNAMIC SYMBOL TABLE:
0294 ld  .text   .text
00200308 gDO .dynamic    _DYNAMIC
 gDO .text   _PROCEDURE_LINKAGE_TABLE_
002003b8 lDO .dynamic    _END_
0294 lDO .text   _START_
002003b8 gD  .dynamic    __bss_start
0294 gDF .text  000b foo
002003b8 gD  .dynamic    _edata
 gDO .dynamic    _GLOBAL_OFFSET_TABLE_
002003b8 gD  .dynamic    _end

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/12548] anonymous version scripts no longer working with binutils 2.21

2012-11-13 Thread pashev.igor at gmail dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=12548

--- Comment #15 from Igor Pashev pashev.igor at gmail dot com 2012-11-13 
21:11:20 UTC ---
Created attachment 6734
  -- http://sourceware.org/bugzilla/attachment.cgi?id=6734
proposed patch

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/12548] anonymous version scripts no longer working with binutils 2.21

2012-11-13 Thread pashev.igor at gmail dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=12548

--- Comment #16 from Igor Pashev pashev.igor at gmail dot com 2012-11-13 
21:23:26 UTC ---
*** Bug 13406 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/13406] version script: please allow anonymous tag to be combined with other tags

2012-11-13 Thread pashev.igor at gmail dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=13406

Igor Pashev pashev.igor at gmail dot com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE

--- Comment #5 from Igor Pashev pashev.igor at gmail dot com 2012-11-13 
21:23:26 UTC ---
Bug #12548 has some real fix.

*** This bug has been marked as a duplicate of bug 12548 ***

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/12548] anonymous version scripts no longer working with binutils 2.21

2012-11-13 Thread lionel at mamane dot lu
http://sourceware.org/bugzilla/show_bug.cgi?id=12548

--- Comment #17 from Lionel Elie Mamane lionel at mamane dot lu 2012-11-13 
22:50:34 UTC ---
I confirm that patch in attachment 6734 solves bug 13406 for me (testcase:
attachment 6057)

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug binutils/14840] New: Fix typos in source code

2012-11-13 Thread agarcia at igalia dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=14840

 Bug #: 14840
   Summary: Fix typos in source code
   Product: binutils
   Version: 2.23
Status: NEW
  Severity: minor
  Priority: P2
 Component: binutils
AssignedTo: unassig...@sourceware.org
ReportedBy: agar...@igalia.com
Classification: Unclassified


Created attachment 6735
  -- http://sourceware.org/bugzilla/attachment.cgi?id=6735
Patch

There are a few typos in the source code. Changeset 90a70212 already fixed many
of them, but others are still there.

Patch attached.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils