[Bug gold/18106] error: TLS relocation against invalid instruction

2015-03-22 Thread ccoutant at google dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=18106

--- Comment #5 from Cary Coutant  ---
Created attachment 8204
  --> https://sourceware.org/bugzilla/attachment.cgi?id=8204&action=edit
Proposed gold patch

HJ, can you try this patch? I think it should work, but I'm at home right now,
and my Ubuntu VM doesn't have 32-bit libraries. The non-SIB form of
lea;call;nop was listed as a FIXME, and thus resulted in the "invalid
instruction" error.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug gold/18106] error: TLS relocation against invalid instruction

2015-03-22 Thread hjl.tools at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=18106

--- Comment #6 from H.J. Lu  ---
(In reply to Cary Coutant from comment #5)
> Created attachment 8204 [details]
> Proposed gold patch
> 
> HJ, can you try this patch? I think it should work, but I'm at home right
> now, and my Ubuntu VM doesn't have 32-bit libraries. The non-SIB form of
> lea;call;nop was listed as a FIXME, and thus resulted in the "invalid
> instruction" error.

It linked and generated working executable.  Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug gold/18106] error: TLS relocation against invalid instruction

2015-03-22 Thread cvs-commit at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=18106

--- Comment #7 from cvs-commit at gcc dot gnu.org  ---
The master branch has been updated by Cary Coutant :

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=152f702439a34bf20b74f472695490edb42ad56f

commit 152f702439a34bf20b74f472695490edb42ad56f
Author: Cary Coutant 
Date:   Sun Mar 22 11:59:21 2015 -0700

Fix support for i386 TLS GD-to-IE optimization.

There are two cases to support, one with an SIB-form (6-byte) LEA,
the other with a 5-byte LEA and a NOP after the call __tls_get_addr.
Gold did not yet support the second case. This patch adds that
support.

gold/
PR gold/18106
* i386.cc (Target_i386::Relocate::tls_gd_to_ie): Fix support for
non-SIB form of lea, with nop after the call.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug gold/18106] error: TLS relocation against invalid instruction

2015-03-22 Thread ccoutant at google dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=18106

Cary Coutant  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #8 from Cary Coutant  ---
Fixed on trunk.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug gold/18147] gold should not issue relocation overflow error with --unresolved-symbols=ignore-all

2015-03-22 Thread amodra at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=18147

--- Comment #5 from Alan Modra  ---
It might be reasonable to not report relocation overflow for strong undefined
symbols, but I don't think that a linker should ignore all weak undefined
symbol overflow.  For example, this
  if (foo)
foo ();
should report overflows in any relocation used to implement "if (foo)".

Normally of course any relocations involved are absolute and zero works fine in
an absolute relocation, but suppose a pc-relative address calculation is used
to implement "if (foo)".  That might overflow when foo is undefined if you use
-Ttext (or have an extremely large binary).

-- 
You are receiving this mail because:
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils