[Bug gas/16109] Incorrect listing (single line comment after multiline one causes line mis-alignment)

2013-11-09 Thread makhaloff at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=16109

Alexey Makhalov makhaloff at gmail dot com changed:

   What|Removed |Added

 Status|NEW |UNCONFIRMED
 CC||makhaloff at gmail dot com
   Assignee|unassigned at sourceware dot org   |makhaloff at gmail dot 
com
 Ever confirmed|1   |0

--- Comment #1 from Alexey Makhalov makhaloff at gmail dot com ---
Created attachment 7272
  -- https://sourceware.org/bugzilla/attachment.cgi?id=7272action=edit
patch to fix that problem

Multiline comment increases add_newlines counter by each newline. And after
*/\n app inserts necessary amount of \n. But it didn't happen after
*/#some comment\n sequence.
This patch fixes that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug gas/16109] Incorrect listing (single line comment after multiline one causes line mis-alignment)

2013-11-09 Thread makhaloff at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=16109

Alexey Makhalov makhaloff at gmail dot com changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #2 from Alexey Makhalov makhaloff at gmail dot com ---
I've checked on some tests.
It works for me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug gas/16109] New: Incorrect listing (single line comment after multiline one causes line mis-alignment)

2013-10-31 Thread makhaloff at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=16109

Bug ID: 16109
   Summary: Incorrect listing (single line comment after multiline
one causes line mis-alignment)
   Product: binutils
   Version: 2.23
Status: NEW
  Severity: normal
  Priority: P2
 Component: gas
  Assignee: unassigned at sourceware dot org
  Reporter: makhaloff at gmail dot com

I have a simple example:

/*
*/#
nop
nop

There are some assembler outputs:

$ arm-linux-gnueabi-as -ahl 1.s
ARM GAS  1.spage 1


   1/*
   2  A0E1  */#
   3nop
   4 0004 A0E1  nop
   5 


$ mips-linux-as -ahl 1.s
GAS LISTING 1.s page 1


   1/*
   2    */#
   3nop
   4 0004   nop
   5 0008  
   5   


After some modification:


/*
*/
nop
nop

listing is corect.

$ arm-linux-gnueabi-as -ahl 1.s
ARM GAS  1.spage 1


   1/*
   2*/
   3  A0E1  nop
   4 0004 A0E1  nop
   5

-- 
You are receiving this mail because:
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug gas/14017] New: Bug in symbol arithmetic

2012-04-24 Thread makhaloff at gmail dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=14017

 Bug #: 14017
   Summary: Bug in symbol arithmetic
   Product: binutils
   Version: 2.23 (HEAD)
Status: NEW
  Severity: normal
  Priority: P2
 Component: gas
AssignedTo: unassig...@sourceware.org
ReportedBy: makhal...@gmail.com
Classification: Unclassified


Created attachment 6364
  -- http://sourceware.org/bugzilla/attachment.cgi?id=6364
Patch to fix this bug

I got error on this code:

.text
NULL:
PS_8K = 0x40   
OFFSET = (System1 - NULL)
S = (OFFSET + PS_8K)
movl $2,S
 .org 0x2000
System1:

S will be equal 0x40. But actual value should be 0x2040.

The reason is as follows:
* gas/read.c (pseudo_set): Fixed x=undef+const case (expr_sections is undefined
at this time also)

Example and patch are attached.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug gas/14017] Bug in symbol arithmetic

2012-04-24 Thread makhaloff at gmail dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=14017

--- Comment #1 from Alexey Makhalov makhaloff at gmail dot com 2012-04-24 
22:26:50 UTC ---
Created attachment 6365
  -- http://sourceware.org/bugzilla/attachment.cgi?id=6365
Example to test this bug

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug gas/14019] New: Potential bug with on stack allocated variable

2012-04-24 Thread makhaloff at gmail dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=14019

 Bug #: 14019
   Summary: Potential bug with on stack allocated variable
   Product: binutils
   Version: 2.23 (HEAD)
Status: NEW
  Severity: normal
  Priority: P2
 Component: gas
AssignedTo: unassig...@sourceware.org
ReportedBy: makhal...@gmail.com
Classification: Unclassified


gas/read.c:1771

  if (line_label != NULL)
{
  expressionS exp;
  exp.X_op = O_symbol;
  exp.X_add_symbol = sym;
  exp.X_add_number = 0;
  symbol_set_value_expression (line_label, exp);
  symbol_set_frag (line_label, zero_address_frag);
  S_SET_SEGMENT (line_label, expr_section);
}

line_label is global, exp is local on stack allocated.
I might be reason of bug later.

Perhaps I wrong?

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug gas/845] GAS .rept pseudo op-code

2012-01-25 Thread makhaloff at gmail dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=845

Alexey Makhalov makhaloff at gmail dot com changed:

   What|Removed |Added

 CC||makhaloff at gmail dot com

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug gas/13624] New: Unpredictable behavior in the directives .rept, .macro and perhaps in some other

2012-01-25 Thread makhaloff at gmail dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=13624

 Bug #: 13624
   Summary: Unpredictable behavior in the directives .rept, .macro
and perhaps in some other
   Product: binutils
   Version: 2.23 (HEAD)
Status: NEW
  Severity: normal
  Priority: P2
 Component: gas
AssignedTo: unassig...@sourceware.org
ReportedBy: makhal...@gmail.com
Classification: Unclassified


Created attachment 6176
  -- http://sourceware.org/bugzilla/attachment.cgi?id=6176
Patch to fix this bug

Hello.

I got the same error as described in the bug #845.
I got it on my target KVARC (http://km211.biz/en/kvarc-32bit), which is not
present in official sources of binutils.
My case. I have a big .s file, size 65K bytes. There is a code fragment in the
middle of file

.rept   (0x100 - 0x20)
 .long TrapAll
 .long 0x0
.endr

It generates error

interrupt.s: Assembler messages:
interrupt.s:3120: Error: unknown pseudo-op: `.lon'

If I add new line before this code fragment then get another error

interrupt.s: Assembler messages:
interrupt.s:3121: Error: unknown pseudo-op: `.l'


The reason is as follows:
* gas/app.c (app_push): Variable add_newlines should be set to zero after
saving. 

Patch is attached.

Sorry, It's hard to reproduce for you. But I can tell you how it leads to the
error, if necessary

Thanks.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug gas/13624] Unpredictable behavior in the directives .rept, .macro and perhaps in some others

2012-01-25 Thread makhaloff at gmail dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=13624

Alexey Makhalov makhaloff at gmail dot com changed:

   What|Removed |Added

Summary|Unpredictable behavior in   |Unpredictable behavior in
   |the directives .rept,   |the directives .rept,
   |.macro and perhaps in some  |.macro and perhaps in some
   |other   |others

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils