[Bug binutils/13482] inaccurate documentation

2012-02-01 Thread nickc at redhat dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=13482

Nick Clifton  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||nickc at redhat dot com
 Resolution||FIXED

--- Comment #2 from Nick Clifton  2012-02-01 15:47:42 
UTC ---
Hi Dave,

  Thanks for reporting this problem.  It is not a documentation error - spaces
are allowed in the strings in .note sections.  Rather it was a couple of
off-by-one errors in readelf which were being triggered because "Version 1.0"
is exactly 12 bytes long.  If you had tried "Version 1.09" it would have
worked...

  Anyway I have checked in a patch to fix the problem, and to add a test to the
binutils testsuite to make sure that this issue does not reoccur.

Cheers
  Nick

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug binutils/13482] inaccurate documentation

2012-02-01 Thread cvs-commit at gcc dot gnu.org
http://sourceware.org/bugzilla/show_bug.cgi?id=13482

--- Comment #1 from cvs-commit at gcc dot gnu.org  2012-02-01 15:44:36 UTC ---
CVSROOT:/cvs/src
Module name:src
Changes by:ni...@sourceware.org2012-02-01 15:44:30

Modified files:
binutils   : ChangeLog readelf.c 
binutils/testsuite: ChangeLog 
binutils/testsuite/binutils-all: readelf.exp 

Log message:
PR binutils/13482
* readelf.c (process_corefile_note_segment): Fix off-by-one errors
verifying the contents of a note.

* binutils-all/version.s: New test source file.
* binutils-all/readelf.n: New file: expected readelf output.
* binutils-all/readelf.exp: Add test of .note section contents.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/binutils/ChangeLog.diff?cvsroot=src&r1=1.1874&r2=1.1875
http://sourceware.org/cgi-bin/cvsweb.cgi/src/binutils/readelf.c.diff?cvsroot=src&r1=1.566&r2=1.567
http://sourceware.org/cgi-bin/cvsweb.cgi/src/binutils/testsuite/ChangeLog.diff?cvsroot=src&r1=1.248&r2=1.249
http://sourceware.org/cgi-bin/cvsweb.cgi/src/binutils/testsuite/binutils-all/readelf.exp.diff?cvsroot=src&r1=1.31&r2=1.32

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils