[Bug binutils/20814] DLLTool Put Wrong Hint Value In Lib Archieve (IDATA6 Section)

2024-06-26 Thread nickc at redhat dot com 
https://sourceware.org/bugzilla/show_bug.cgi?id=20814

--- Comment #11 from Nick Clifton  ---
Done

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug binutils/20814] DLLTool Put Wrong Hint Value In Lib Archieve (IDATA6 Section)

2024-06-26 Thread cvs-commit at gcc dot gnu.org 
https://sourceware.org/bugzilla/show_bug.cgi?id=20814

--- Comment #10 from Sourceware Commits  ---
The master branch has been updated by Nick Clifton :

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=057a2b4c4b57ef495dd32c9087e4af28bda41737

commit 057a2b4c4b57ef495dd32c9087e4af28bda41737
Author: Nick Clifton 
Date:   Wed Jun 26 13:17:25 2024 +0100

Revert: 35fd2ddeb1d90f1750401cfb6d01fe055656b88d

  PR 20814

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug binutils/20814] DLLTool Put Wrong Hint Value In Lib Archieve (IDATA6 Section)

2024-06-25 Thread pali at kernel dot org 
https://sourceware.org/bugzilla/show_bug.cgi?id=20814

--- Comment #9 from Pali Rohár  ---
Nick, the commit 35fd2ddeb1d90f1750401cfb6d01fe055656b88d should be reverted
too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug binutils/20814] DLLTool Put Wrong Hint Value In Lib Archieve (IDATA6 Section)

2024-05-13 Thread pali at kernel dot org 
https://sourceware.org/bugzilla/show_bug.cgi?id=20814

Pali Rohár  changed:

   What|Removed |Added

 CC||pali at kernel dot org

--- Comment #8 from Pali Rohár  ---
This change in commit 35fd2ddeb1d90f1750401cfb6d01fe055656b88d broke generating
hint indexes in import libraries from DEF file via dlltool.

I filled a new bug #31728 for this issue.

After applying revert of that commit on top of the current git branch of
binutils, dlltool started generating correct hints indexes. I verified it by MS
DUMPBIN tool and also by my changes to binutils objdump, which I put into the
new bug #31738.

The information here in this bug #20814 is on the wrong premise: In the
attachment #9639 is comparision of **ordinals** from export library with the
**hints** from the executable. Ordinals and hints are two different things
without any relation between them and trying to match hints to ordinal is just
an incorrect thing. In simple cases, which means that all symbols in input DEF
files are lexicographically sorted, no symbol has explicit ordinal assigned
then the symbols's ordinal == hint + 1. But in all other cases there is no
relation at all.

Seems that the MS "Properties" dialog shows only ordinal number. But MS tool
"DUMPBIN.EXE /exports" shows both ordinal number and hint number.

Executable can import symbol either by ordinal or by name+hint. Not both. So if
the symbol is imported by name then the number is hint, not the ordinal. I
explained it a bit more in the bug #31728.

So based on the information in bug #31728 and improved objdump -p (#bug 31738)
I would propose to revert the commit 35fd2ddeb1d90f1750401cfb6d01fe055656b88d.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug binutils/20814] DLLTool Put Wrong Hint Value In Lib Archieve (IDATA6 Section)

2017-02-25 Thread rudyy.id at gmail dot com 
https://sourceware.org/bugzilla/show_bug.cgi?id=20814

Rudy Y.  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #7 from Rudy Y.  ---
Duplicate.

*** This bug has been marked as a duplicate of bug 20880 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils

[Bug binutils/20814] DLLTool Put Wrong Hint Value In Lib Archieve (IDATA6 Section)

2016-11-16 Thread jacky.chouchou at yandex dot ru 
https://sourceware.org/bugzilla/show_bug.cgi?id=20814

--- Comment #6 from Rudy  ---
Hopely, with this, mingw generate def file with @ordinal in it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils

[Bug binutils/20814] DLLTool Put Wrong Hint Value In Lib Archieve (IDATA6 Section)

2016-11-16 Thread jacky.chouchou at yandex dot ru 
https://sourceware.org/bugzilla/show_bug.cgi?id=20814

--- Comment #5 from Rudy  ---
Created attachment 9639
  --> https://sourceware.org/bugzilla/attachment.cgi?id=9639&action=edit
An image comparing msvcr100.dll export table and gendef.exe import table with
new dlltool.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils

[Bug binutils/20814] DLLTool Put Wrong Hint Value In Lib Archieve (IDATA6 Section)

2016-11-16 Thread jacky.chouchou at yandex dot ru 
https://sourceware.org/bugzilla/show_bug.cgi?id=20814

--- Comment #4 from Rudy  ---
Created attachment 9638
  --> https://sourceware.org/bugzilla/attachment.cgi?id=9638&action=edit
msvcr100.def and objdump for libmsvcr100.a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils

[Bug binutils/20814] DLLTool Put Wrong Hint Value In Lib Archieve (IDATA6 Section)

2016-11-14 Thread cvs-commit at gcc dot gnu.org 
https://sourceware.org/bugzilla/show_bug.cgi?id=20814

--- Comment #2 from cvs-commit at gcc dot gnu.org  ---
The master branch has been updated by Nick Clifton :

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=35fd2ddeb1d90f1750401cfb6d01fe055656b88d

commit 35fd2ddeb1d90f1750401cfb6d01fe055656b88d
Author: Rudy 
Date:   Mon Nov 14 16:30:45 2016 +

Generate correct hint value for IDATA6.

PR binutils/20814
* dlltool.c (struct export): Remove hint field.
(make_one_lib_file): Store the ordinal value for IDATA6 not the
hint.
(gen_lib_file): Delete reference to hint field.
(mangle_defs): Delete computation of hint field.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils

[Bug binutils/20814] DLLTool Put Wrong Hint Value In Lib Archieve (IDATA6 Section)

2016-11-14 Thread nickc at redhat dot com 
https://sourceware.org/bugzilla/show_bug.cgi?id=20814

Nick Clifton  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
   Last reconfirmed||2016-11-14
 CC||nickc at redhat dot com
 Ever confirmed|0   |1

--- Comment #3 from Nick Clifton  ---
Hi Rudy,

  Thanks for the bug report and patch details.  I have applied the changes that
you suggested.  Please could you confirm that the dlltool now works properly ?

Cheers
  Nick

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils

[Bug binutils/20814] DLLTool Put Wrong Hint Value In Lib Archieve (IDATA6 Section)

2016-11-13 Thread jacky.chouchou at yandex dot ru 
https://sourceware.org/bugzilla/show_bug.cgi?id=20814

--- Comment #1 from Rudy  ---
{struct}export->hint.
"mangle_defs" function.
Always sequential (hint++).

{struct}export->ordinal.
"fill_ordinals" function.
Sequential IF there is no @ordinal in DEF file, not sequential IF there is
@ordinal. Mix both if there is or there aren't.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils