[Bug binutils/21659] strings behaviour when called on a directory

[jg at jguk dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=21659

--- Comment #8 from Jon Grant  ---
ok, yes, great to just have a message.
Regards, Jon

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils

[Bug binutils/21659] strings behaviour when called on a directory

[nickc at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21659

--- Comment #7 from Nick Clifton  ---
Hi Jon,

> Do you think okay to be a Warning as opposed to Error? the "gold" linker
> calls it a fatal error.

Meh - I am really not that bothered by this discrepancy.  The tools are now
producing reasonable error/warning messages, and anyone using them should be
able to cope with the differences in severity.  Well IMHO anyway.

Cheers
  Nick

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils

[Bug binutils/21659] strings behaviour when called on a directory

[jg at jguk dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=21659

--- Comment #6 from Jon Grant  ---
Hi Nick

Great!

Yes, maybe mine is too old. I'm on Ubuntu LTS binutils 2.26.1

Do you think okay to be a Warning as opposed to Error? the "gold" linker calls
it a fatal error.


$ gold mydir
gold: fatal error: mydir: pread failed: Is a directory

Regards, Jon

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils

[Bug binutils/21659] strings behaviour when called on a directory

[nickc at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21659

--- Comment #5 from Nick Clifton  ---
Hi Jon,

  I could not reproduce the behaviour you describe for ld and ar - they
  both say "Is a directory" for me.  This is with the latest mainline
  sources however.  Objcopy did behave as you said, so I have checked in
  a small patch to make it also generate an "Is a directory" message.

Cheers
  Nick

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils

[Bug binutils/21659] strings behaviour when called on a directory

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=21659

--- Comment #4 from cvs-commit at gcc dot gnu.org  ---
The master branch has been updated by Nick Clifton :

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=0602cdad745472ed2561d8096a4bb021c8d0301d

commit 0602cdad745472ed2561d8096a4bb021c8d0301d
Author: Nick Clifton 
Date:   Mon Jun 26 13:25:41 2017 +0100

Produce a consistent warning message when attempting to run a tool on a
directory.

PR binutils/21659
* bucomm.c (get_file_size): Explicitly warn if the file is a
directory.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils

[Bug binutils/21659] strings behaviour when called on a directory

[jg at jguk dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=21659

--- Comment #3 from Jon Grant  ---
Great Nick!

$ ld mydir
ld: cannot find mydir: File format not recognised

$ ar p mydir
ar: mydir: File format not recognised

I had a look at the others, I saw they have this kind of output below. Perhaps
"ar" and "ld" could be updated to say it is a directory, or not an ordinary
file.

$ objcopy mydir
objcopy: Warning: 'mydir' is not an ordinary file


Let me know if you prefer I create a separate ticket.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils

[Bug binutils/21659] strings behaviour when called on a directory

[nickc at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21659

Nick Clifton  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||nickc at redhat dot com
 Resolution|--- |FIXED

--- Comment #2 from Nick Clifton  ---
Hi Jon,

  Thanks for reporting this problem.  I have applied a small patch to fix 
  the issue, so I am going to close this PR.

Cheers
  Nick

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils

[Bug binutils/21659] strings behaviour when called on a directory

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=21659

--- Comment #1 from cvs-commit at gcc dot gnu.org  ---
The master branch has been updated by Nick Clifton :

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=0e158763b0c5671cd40cdd2faee48d6659489ddd

commit 0e158763b0c5671cd40cdd2faee48d6659489ddd
Author: Nick Clifton 
Date:   Fri Jun 23 10:22:36 2017 +0100

Make the strings utility reject directories.

PR binutils/21659
* strings.c (strings_file): Warn about attempts to run strings on
a directory.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils