[Bug gas/11509] Strange evaluation of symbol containing register

2010-04-24 Thread theorizer at freemail dot hu

--- Additional Comments From theorizer at freemail dot hu  2010-04-24 17:19 
---
Thanks that you convinced yourself that it is a bug and fixed it :-). I tested
your patch with 2.20.51.20100424 and it is working fine. Thanks again.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=11509

--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug gas/11509] Strange evaluation of symbol containing register

2010-04-21 Thread hjl dot tools at gmail dot com

--- Additional Comments From cvs-commit at gcc dot gnu dot org  2010-04-21 
18:10 ---
Subject: Bug 11509

CVSROOT:/cvs/src
Module name:src
Changes by: h...@sourceware.org 2010-04-21 18:09:53

Modified files:
gas: ChangeLog read.c 
gas/config : tc-i386-intel.c tc-i386.c 
gas/testsuite  : ChangeLog 
gas/testsuite/gas/i386: equ.d equ.s 

Log message:
Properly handle ".equ symbol, reg + NUM" in x86 Intel syntax.

gas/

2010-04-21  H.J. Lu  

PR gas/11509
* config/tc-i386-intel.c (i386_intel_simplify_register): New.
(i386_intel_simplify): Use i386_is_register and
i386_intel_simplify_register. Set X_md for O_register and
check X_md for O_constant.
(i386_intel_operand): Use i386_is_register.

* config/tc-i386.c (i386_is_register): New.
(x86_cons): Initialize the X_md field.  Use i386_is_register.
(parse_register): Use i386_is_register.
(tc_x86_parse_to_dw2regnum): Likewise.

gas/testsuite/

2010-04-21  H.J. Lu  

PR gas/11509
* gas/i386/equ.s: Add tests for ".equ symbol, reg + NUM".
* gas/i386/equ.d: Updated.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/ChangeLog.diff?cvsroot=src&r1=1.4136&r2=1.4137
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/read.c.diff?cvsroot=src&r1=1.162&r2=1.163
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/config/tc-i386-intel.c.diff?cvsroot=src&r1=1.9&r2=1.10
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/config/tc-i386.c.diff?cvsroot=src&r1=1.431&r2=1.432
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/testsuite/ChangeLog.diff?cvsroot=src&r1=1.1657&r2=1.1658
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/testsuite/gas/i386/equ.d.diff?cvsroot=src&r1=1.3&r2=1.4
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/testsuite/gas/i386/equ.s.diff?cvsroot=src&r1=1.4&r2=1.5


--- Additional Comments From hjl dot tools at gmail dot com  2010-04-21 
18:26 ---
Fixed.

-- 
   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=11509

--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug gas/11509] Strange evaluation of symbol containing register

2010-04-20 Thread hjl dot tools at gmail dot com

--- Additional Comments From hjl dot tools at gmail dot com  2010-04-20 
21:17 ---
This test failed:

[...@gnu-6 pr11509]$ cat 1.s
.intel_syntax noprefix

.eqv param, ebp-4
[...@gnu-6 pr11509]$ ./as --32 -o 1.o 1.s
1.s: Assembler messages:
1.s:3: Error: can't make global register symbol `param'
[...@gnu-6 pr11509]$ 

I think it is a bad idea to use ".eqv param, ebp-4".

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=11509

--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug gas/11509] Strange evaluation of symbol containing register

2010-04-19 Thread hjl dot tools at gmail dot com

--- Additional Comments From hjl dot tools at gmail dot com  2010-04-19 
14:37 ---
I don't think we should support ".eqv param, ebp-4"
since it is evaluated and fully resolved at the first
use. We got ".eqv param, -4" starting from the
second use.

-- 
   What|Removed |Added

  GCC build triplet|x86_64-gentoo-linux, x86_32-|
   |gentoo-linux, cygwin|
   GCC host triplet|x86_64-gentoo-linux, x86_32-|
   |gentoo-linux, cygwin|
 GCC target triplet|x86_64-gentoo-linux, x86_32-|i386/x86-64
   |gentoo-linux, cygwin|
Version|2.20|2.21 (HEAD)


http://sourceware.org/bugzilla/show_bug.cgi?id=11509

--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils