[Bug gold/10708] "out of file descriptors and couldn't close any" -- probably fd leak
https://sourceware.org/bugzilla/show_bug.cgi?id=10708 Andreas Schwab changed: What|Removed |Added CC|jackie.rosen at hushmail dot com | -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/10708] "out of file descriptors and couldn't close any" -- probably fd leak
https://sourceware.org/bugzilla/show_bug.cgi?id=10708 ismail at donmez dot ws changed: What|Removed |Added CC|ismail at donmez dot ws| -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/10708] "out of file descriptors and couldn't close any" -- probably fd leak
https://sourceware.org/bugzilla/show_bug.cgi?id=10708 Jackie Rosen changed: What|Removed |Added CC||jackie.rosen at hushmail dot com --- Comment #15 from Jackie Rosen --- *** Bug 260998 has been marked as a duplicate of this bug. *** Seen from the domain http://volichat.com Page where seen: http://volichat.com/adult-chat-rooms Marked for reference. Resolved as fixed @bugzilla. -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/10708] "out of file descriptors and couldn't close any" -- probably fd leak
http://sourceware.org/bugzilla/show_bug.cgi?id=10708 Ian Lance Taylor changed: What|Removed |Added Status|WAITING |RESOLVED Resolution||FIXED --- Comment #14 from Ian Lance Taylor 2011-02-27 15:23:15 UTC --- Seems to be fixed on mainline and in the upcoming 2.21.1 release. -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/10708] "out of file descriptors and couldn't close any" -- probably fd leak
http://sourceware.org/bugzilla/show_bug.cgi?id=10708 --- Comment #13 from cvs-commit at gcc dot gnu.org 2011-02-27 15:17:32 UTC --- CVSROOT:/cvs/src Module name:src Branch: binutils-2_21-branch Changes by:i...@sourceware.org2011-02-27 15:17:29 Modified files: gold : ChangeLog copy-relocs.cc gold.cc icf.cc mapfile.cc plugin.cc Log message: Backport from mainline: 2010-11-05 Cary Coutant PR gold/10708 * copy-relocs.cc (Copy_relocs::emit_copy_reloc): Hold a lock on the object when reading from the file. * gold.cc (queue_middle_tasks): Hold a lock on the object when doing second layout pass. * icf.cc (preprocess_for_unique_sections): Hold a lock on the object when reading section contents. (get_section_contents): Likewise. (icf::find_identical_sections): Likewise. * mapfile.cc (Mapfile::print_discarded_sections): Hold a lock on the object when reading from the file. * plugin.cc (Plugin_manager::layout_deferred_objects): Hold a lock on the object when doing deferred section layout. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/src/gold/ChangeLog.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.664.2.15&r2=1.664.2.16 http://sourceware.org/cgi-bin/cvsweb.cgi/src/gold/copy-relocs.cc.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.11&r2=1.11.2.1 http://sourceware.org/cgi-bin/cvsweb.cgi/src/gold/gold.cc.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.85&r2=1.85.2.1 http://sourceware.org/cgi-bin/cvsweb.cgi/src/gold/icf.cc.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.15.2.1&r2=1.15.2.2 http://sourceware.org/cgi-bin/cvsweb.cgi/src/gold/mapfile.cc.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.6&r2=1.6.2.1 http://sourceware.org/cgi-bin/cvsweb.cgi/src/gold/plugin.cc.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.40.2.1&r2=1.40.2.2 -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/10708] "out of file descriptors and couldn't close any" -- probably fd leak
http://sourceware.org/bugzilla/show_bug.cgi?id=10708 --- Comment #12 from Bengt-Erik Soderstrom 2011-02-26 18:58:27 UTC --- The patch as proposed in comment #10 works. I can now again build Chromium on my 32-bit machine. -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/10708] "out of file descriptors and couldn't close any" -- probably fd leak
http://sourceware.org/bugzilla/show_bug.cgi?id=10708 Bengt-Erik Soderstrom changed: What|Removed |Added CC||bes.wll at telia dot com --- Comment #11 from Bengt-Erik Soderstrom 2011-02-26 17:40:37 UTC --- (In reply to comment #10) > I found another leak that will explain the problem -- if you're using the > --no-keep-files-mapped option (or a 32-bit build of gold, for which that's the > default) and --gc-sections and/or --icf. > > Can you try the patch below and let me know if it fixes the problem for you? > > -cary > > > Index: gold.cc > === > RCS file: /cvs/src/src/gold/gold.cc,v > retrieving revision 1.85 > diff -u -p -r1.85 gold.cc > --- gold.cc 14 Oct 2010 22:10:22 - 1.85 > +++ gold.cc 3 Nov 2010 23:39:44 - > @@ -359,6 +359,7 @@ queue_middle_tasks(const General_options >p != input_objects->relobj_end(); >++p) > { > + Task_lock_obj tlo(task, *p); > (*p)->layout(symtab, layout, NULL); > } > } I just found this behaviour when building Chromium on a 32 bit machine using Gold (binutils 2.21) and Fedora 14. Building from the same source, but in a 64 bit environment was OK. (Ubuntu 10.10 binutils 2.21). Chromium was OK some week ago with the Gold linker with the Fedora 14 (32-bit). I tried again, but this time linking with the normal ld, that is, not using Gold, and then, the build was successful. I did not yet try your patch, but I will, and let you know. -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/10708] "out of file descriptors and couldn't close any" -- probably fd leak
http://sourceware.org/bugzilla/show_bug.cgi?id=10708 --- Comment #10 from Cary Coutant 2010-11-04 00:08:46 UTC --- I found another leak that will explain the problem -- if you're using the --no-keep-files-mapped option (or a 32-bit build of gold, for which that's the default) and --gc-sections and/or --icf. Can you try the patch below and let me know if it fixes the problem for you? -cary Index: gold.cc === RCS file: /cvs/src/src/gold/gold.cc,v retrieving revision 1.85 diff -u -p -r1.85 gold.cc --- gold.cc 14 Oct 2010 22:10:22 - 1.85 +++ gold.cc 3 Nov 2010 23:39:44 - @@ -359,6 +359,7 @@ queue_middle_tasks(const General_options p != input_objects->relobj_end(); ++p) { + Task_lock_obj tlo(task, *p); (*p)->layout(symtab, layout, NULL); } } -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/10708] "out of file descriptors and couldn't close any" -- probably fd leak
http://sourceware.org/bugzilla/show_bug.cgi?id=10708 --- Comment #9 from Cary Coutant 2010-10-23 01:05:41 UTC --- I've been trying to track down possible sources of file descriptor leakage. I've found one: In copy_relocs.cc, Copy_relocs::emit_copy_reloc(): typename elfcpp::Elf_types::Elf_WXword addralign = sym->object()->section_addralign(shndx); This, and probably other similar places where we go back to an ELF file for some info, seems to be leaking file descriptors. The call to section_addralign() creates an Object::View, and reopens the file descriptor, but never releases it. Also, at least in this particular case, we're accessing a different file from the one we currently have locked (the shared library that contains the definition of the symbol), and we haven't locked the file. If we had locked the file here, the descriptor would have been released, but I'm not sure it's safe to lock the shared library at this point -- we're in a Scan_relocs task, which isn't necessarily single threaded. I'm wondering whether it would be better to just find and eradicate places where we need to read a file outside of the times we normally have the file open. I have no idea whether this is the cause of the problem reported here, but a good way to tell is if you can rerun the link with -Wl,--debug=task. That would give us an idea of where it is when you finally run out of file descriptors. For this leakage to cause real problems, you'll need lots of shared libraries, and COPY relocations into lots of them. It seems unlikely, but it's worth a shot. It's also possible that there are other leakages similar to this that would trigger under different conditions. -cary -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/10708] "out of file descriptors and couldn't close any" -- probably fd leak
http://sourceware.org/bugzilla/show_bug.cgi?id=10708 Cary Coutant changed: What|Removed |Added CC||ccoutant at google dot com -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/10708] "out of file descriptors and couldn't close any" -- probably fd leak
--- Additional Comments From ismail at namtrac dot org 2010-07-21 09:11 --- This is still reproducable while linking QtWebKit; GNU gold (GNU Binutils for Ubuntu 2.20.51-system.20100710) 1.9 Supported targets: elf32-i386 elf32-i386-freebsd elf64-x86-64 elf64-x86-64-freebsd It tries to link ~1800 object files btw. -- What|Removed |Added CC||ismail at namtrac dot org http://sourceware.org/bugzilla/show_bug.cgi?id=10708 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/10708] "out of file descriptors and couldn't close any" -- probably fd leak
-- What|Removed |Added CC||kovarththanan dot rajaratnam ||at gmail dot com http://sourceware.org/bugzilla/show_bug.cgi?id=10708 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/10708] "out of file descriptors and couldn't close any" -- probably fd leak
--- Additional Comments From ian at airs dot com 2010-02-04 03:45 --- Bernhard, are you still seeing the problem? -- http://sourceware.org/bugzilla/show_bug.cgi?id=10708 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/10708] "out of file descriptors and couldn't close any" -- probably fd leak
--- Additional Comments From ahartmetz at gmail dot com 2010-02-03 15:46 --- I could reproduce the problem (also when linking QtWebKit) until a few months ago. I'm always using the latest CVS version. At the time I simply used the old ld when linking Qt instead of increasing the appropriate ulimit. So it looks like this is fixed now. -- http://sourceware.org/bugzilla/show_bug.cgi?id=10708 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/10708] "out of file descriptors and couldn't close any" -- probably fd leak
--- Additional Comments From bero at arklinux dot org 2009-10-01 08:31 --- ulimit -n 65536 fixes it, but using > 1024 FDs still seems somewhat excessive -- http://sourceware.org/bugzilla/show_bug.cgi?id=10708 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/10708] "out of file descriptors and couldn't close any" -- probably fd leak
--- Additional Comments From bero at arklinux dot org 2009-09-30 13:43 --- Yes, this is on a fairly current build: $ ld --version GNU gold (Linux/GNU Binutils 2.20.51.0.1.20090905) 1.9 Copyright 2008 Free Software Foundation, Inc. This program is free software; you may redistribute it under the terms of the GNU General Public License version 3 or (at your option) a later version. This program has absolutely no warranty. ulimit -n is 1024, will try again after increasing it to 65536. It is 100% reproducible, I can do a bit of debugging but don't have a lot of time right now (insane day job schedule right now). -- http://sourceware.org/bugzilla/show_bug.cgi?id=10708 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/10708] "out of file descriptors and couldn't close any" -- probably fd leak
--- Additional Comments From ian at airs dot com 2009-09-30 13:20 --- Can you confirm that this was with the development version of gold? There were some bugs in this area fixed back February. Otherwise, as far as I can see, this can only happen if open returns -1 with errno set to ENFILE or EMFILE. Please check ulimit -n. If this is repeatable, is there any chance that you can debug it a bit? -- What|Removed |Added Status|NEW |ASSIGNED http://sourceware.org/bugzilla/show_bug.cgi?id=10708 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/10708] "out of file descriptors and couldn't close any" -- probably fd leak
--- Additional Comments From bero at arklinux dot org 2009-09-30 09:18 --- Actually this is not caused by a shortage of system FDs, so something else is causing gold to believe it's out of FDs: # cat /proc/sys/fs/file-nr 64961037 370804 -- http://sourceware.org/bugzilla/show_bug.cgi?id=10708 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils