[Bug gold/15660] out of file descriptors and couldn't close any
https://sourceware.org/bugzilla/show_bug.cgi?id=15660 Markus Trippelsdorf changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #17 from Markus Trippelsdorf --- Fixed. Thank you. See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64837#c19 -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/15660] out of file descriptors and couldn't close any
https://sourceware.org/bugzilla/show_bug.cgi?id=15660 --- Comment #16 from cvs-commit at gcc dot gnu.org --- The master branch has been updated by Cary Coutant : https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=2cfbf2fece582c29df348104b28677c38a8301f4 commit 2cfbf2fece582c29df348104b28677c38a8301f4 Author: Cary Coutant Date: Tue Feb 3 19:54:57 2015 -0800 Fix a file descriptor leak in gold. When an LTO linker plugin claims an external member of a thin archive, gold does not properly unlock the file and make its file descriptor available for reuse. This patch fixes the problem by modifying Archive::include_member to unlock the object file via an RAII class instance, ensuring that it will be unlocked no matter what path is taken through the function. gold/ PR gold/15660 * archive.cc (Thin_archive_object_unlocker): New class. (Archive::include_member): Unlock external members of thin archives. * testsuite/Makefile.am (plugin_test_1): Rename .syms files. (plugin_test_2): Likewise. (plugin_test_3): Likewise. (plugin_test_4): Likewise. (plugin_test_5): Likewise. (plugin_test_6): Likewise. (plugin_test_7): Likewise. (plugin_test_8): Likewise. (plugin_test_9): Likewise. (plugin_test_10): Likewise. (plugin_test_11): New test case. * testsuite/Makefile.in: Regenerate. * testsuite/plugin_test.c (claim_file_hook): Check for parallel .syms file to decide whether to claim file. (all_symbols_read_hook): Likewise. * testsuite/plugin_test_1.sh: Adjust expected output. * testsuite/plugin_test_2.sh: Likewise. * testsuite/plugin_test_3.sh: Likewise. * testsuite/plugin_test_6.sh: Likewise. * testsuite/plugin_test_tls.sh: Likewise. * testsuite/plugin_test_11.sh: New testcase. -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/15660] out of file descriptors and couldn't close any
https://sourceware.org/bugzilla/show_bug.cgi?id=15660 Cary Coutant changed: What|Removed |Added Depends on|17896 | -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/15660] out of file descriptors and couldn't close any
https://sourceware.org/bugzilla/show_bug.cgi?id=15660 Cary Coutant changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|DUPLICATE |--- --- Comment #15 from Cary Coutant --- Not a duplicate. PR 17896 is not a bug, and the leakage of file descriptors is unrelated to the use of the release_input_file plugin API. Thanks to Peter Collingbourne, I'm now fairly certain that this bug is due to the failure to unlock an external member of a thin archive after claiming it via the plugin interface. I have a patch ready. -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/15660] out of file descriptors and couldn't close any
https://sourceware.org/bugzilla/show_bug.cgi?id=15660 H.J. Lu changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |DUPLICATE --- Comment #14 from H.J. Lu --- Since https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64837 has been fixed, now it becomes a dup. *** This bug has been marked as a duplicate of bug 17896 *** -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/15660] out of file descriptors and couldn't close any
https://sourceware.org/bugzilla/show_bug.cgi?id=15660 H.J. Lu changed: What|Removed |Added CC||hjl.tools at gmail dot com -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/15660] out of file descriptors and couldn't close any
https://sourceware.org/bugzilla/show_bug.cgi?id=15660 --- Comment #13 from H.J. Lu --- This is related to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64837 -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/15660] out of file descriptors and couldn't close any
https://sourceware.org/bugzilla/show_bug.cgi?id=15660 H.J. Lu changed: What|Removed |Added Depends on||17896 -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/15660] out of file descriptors and couldn't close any
https://sourceware.org/bugzilla/show_bug.cgi?id=15660 Cary Coutant changed: What|Removed |Added Status|WAITING |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/15660] out of file descriptors and couldn't close any
https://sourceware.org/bugzilla/show_bug.cgi?id=15660 --- Comment #12 from Martin Liška --- Created attachment 7476 --> https://sourceware.org/bugzilla/attachment.cgi?id=7476&action=edit ld args and liblto plugin -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/15660] out of file descriptors and couldn't close any
https://sourceware.org/bugzilla/show_bug.cgi?id=15660 --- Comment #11 from Martin Liška --- There's my out/Release build folder: https://drive.google.com/file/d/0B0pisUJ80pO1UzFGNGJhaW1xbVE/edit?usp=sha ring It's ~3.4GB tar with bzip2 (~6GB extracted). ld --version: GNU gold (GNU Binutils 2.24.51.20140304) 1.11 liblto plugin and command line argument for ld are attached in the tar I wi ll upload. -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/15660] out of file descriptors and couldn't close any
https://sourceware.org/bugzilla/show_bug.cgi?id=15660 Cary Coutant changed: What|Removed |Added Status|NEW |WAITING Assignee|ian at airs dot com|ccoutant at google dot com --- Comment #10 from Cary Coutant --- Waiting for a tarball for repro. -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/15660] out of file descriptors and couldn't close any
https://sourceware.org/bugzilla/show_bug.cgi?id=15660 Rafael Ávila de Espíndola cha nged: What|Removed |Added CC||rafael.espindola at gmail dot com -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/15660] out of file descriptors and couldn't close any
https://sourceware.org/bugzilla/show_bug.cgi?id=15660 --- Comment #9 from Markus Trippelsdorf --- In my case, I just had to increase the limits. Gold has 18718 files open during the final Chromium link: % lsof -c ld |wc -l 18718 -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/15660] out of file descriptors and couldn't close any
https://sourceware.org/bugzilla/show_bug.cgi?id=15660 Markus Trippelsdorf changed: What|Removed |Added CC||markus at trippelsdorf dot de --- Comment #8 from Markus Trippelsdorf --- Also happens during clang lto build of chromium. -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/15660] out of file descriptors and couldn't close any
http://sourceware.org/bugzilla/show_bug.cgi?id=15660 --- Comment #7 from Martin Liška --- I'll try to link it without -flto, but I used -fno-fat-lto-objects. It will take me some time to recompile chromium. Weird is that ld.bfd is able to link the binary with -flto (aside gcc relat ed errors). -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/15660] out of file descriptors and couldn't close any
http://sourceware.org/bugzilla/show_bug.cgi?id=15660 --- Comment #6 from Cary Coutant --- Does the problem only happen with -flto? I wonder if the plugin is keeping files open. Can you tar up the build directory so I can try to repro the problem? -cary On Thu, Jun 20, 2013 at 1:43 PM, marxin.liska at gmail dot com wrote: > http://sourceware.org/bugzilla/show_bug.cgi?id=15660 > > Bug ID: 15660 >Summary: out of file descriptors and couldn't close any >Product: binutils >Version: 2.23 > Status: NEW > Severity: normal > Priority: P2 > Component: gold > Assignee: ian at airs dot com > Reporter: marxin.liska at gmail dot com > CC: ccoutant at google dot com > > I've encountered similar bug to: > http://sourceware.org/bugzilla/show_bug.cgi?id=10708 during linking of > chromium > binary. > > ld --version > GNU gold (GNU Binutils 2.23.52.20130526) 1.11 > > Command line: > FAILED: flock linker.lock g++ -Wl,-z,now -Wl,-z,relro -pthread > -Wl,-z,noexecstack -fPIC -pie -L. -flto=9 -fno-fat-lto-objects -O2 --param > lto-partitions=64 -o chrome -Wl,--start-group > obj/chrome/app/chrome.chrome_exe_main_gtk.o > obj/chrome/app/chrome.chrome_main.o > obj/chrome/app/chrome.chrome_main_delegate.o obj/chrome/libinstaller_util.a > obj/media/libmedia_sse.a obj/third_party/icu/libicuuc.a > obj/third_party/libjingle/libjingle.a obj/skia/libskia_opts.a > obj/third_party/icu/libicudata.a > obj/device/libdevice_media_transfer_protocol.a > obj/native_client/src/trusted/service_runtime/arch/x86/libservice_runtime_x86_common.a > obj/chrome/libservice.a obj/chrome/librenderer.a obj/webkit/support/libglue.a > obj/content/libcontent_worker.a obj/third_party/libwebp/libwebp_utils.a > obj/third_party/zlib/libminizip.a > obj/chrome/browser/performance_monitor/libperformance_monitor.a > obj/third_party/leveldatabase/libleveldatabase.a > obj/native_client/src/trusted/service_runtime/libenv_cleanser.a > obj/sandbox/libc_urandom_override.a obj/chrome/libbrowser.a > obj/ppapi/libppapi_host.a obj/sync/libsync_core.a > obj/gpu/libgles2_cmd_helper.a > obj/third_party/smhasher/libcityhash.a > obj/third_party/libphonenumber/libphonenumber.a > obj/chrome/app/policy/libpolicy.a obj/webkit/support/libplugins_common.a > obj/native_client/src/trusted/validator_x86/libnccopy_x86_64.a > obj/webkit/support/libglue_common.a > obj/webkit/renderer/compositor_bindings/libwebkit_compositor_support.a > obj/third_party/smhasher/libmurmurhash3.a obj/content/libcontent_gpu.a > obj/native_client/src/trusted/threading/libthread_interface.a > obj/media/libmedia_mmx.a obj/ipc/libipc.a obj/third_party/libxslt/libxslt.a > obj/remoting/libremoting_client.a obj/third_party/ots/libots.a > obj/base/libsymbolize.a > obj/native_client/src/trusted/validator/libvalidators.a > obj/chrome/libbrowser_extensions.a obj/skia/libskia_opts_ssse3.a > obj/third_party/protobuf/libprotobuf_lite.a > obj/third_party/WebKit/Source/core/core.gyp/libwebcore_platform.a > obj/ui/surface/libsurface.a > obj/third_party/WebKit/Source/WebKit/chromium/libwebkit.a > obj/native_client/src/trusted/validator/x86/64/libncvalidate_x86_64.a > obj/third_party/jsoncpp/libjsoncpp.a obj/google_apis/libgoogle_apis.a > obj/chrome/libnacl.a > obj/third_party/libphonenumber/libphonenumber_without_metadata.a > obj/chrome/libdebugger.a obj/v8/tools/gyp/libv8_snapshot.a > obj/ui/native_theme/libnative_theme.a obj/third_party/libusb/libusb.a > obj/content/libcontent_common_child.a > obj/native_client/src/trusted/nacl_base/libnacl_base.a > obj/base/libbase_static.a obj/native_client/src/shared/imc/libimc.a > obj/chrome/libfeedback_proto.a > obj/components/libbrowser_context_keyed_service.a > obj/components/libweb_modal.a > obj/chrome/libapps.a > obj/third_party/WebKit/Source/core/core.gyp/libwebcore_platform_geometry.a > obj/components/libuser_prefs.a obj/content/libcontent_utility.a > obj/third_party/libevent/libevent.a obj/sandbox/libseccomp_bpf.a > obj/build/linux/libpci.a obj/ui/gl/libgl_wrapper.a > obj/third_party/mt19937ar/libmt19937ar.a > obj/third_party/angle/src/libtranslator_common.a > obj/ui/message_center/libmessage_center.a obj/third_party/libpng/libpng.a > obj/components/libwebdata_common.a obj/third_party/opus/libopus.a > obj/sync/libsync_notifier.a obj/ui/snapshot/libsnapshot.a > obj/native_client/src/trusted/validator/x86/libncval_base_x86_64.a > obj/webkit/support/libwebkit_media.a obj/third_party/libwebp/libwebp_dsp.a > obj/third_party/harfbuzz-ng/libharfbuzz-ng.a > obj/chrome/app/policy/libcloud_policy_proto_generated_compile.a > obj/base/allocator/liballocator_extension_thunks.a > obj/remoting/libremoting_jingle_glue.a > obj/native_client/src/trusted/service_runtime/libnacl_error_code.a > obj/third_party/snappy/libsnappy.a obj/cc/libcc.a > obj/third_party/libjingle/libjingle_p2p_constants.a > obj/third_party/cld/libcld.a obj/third_party/libxml/libxml2.a > obj/webkit/supp
[Bug gold/15660] out of file descriptors and couldn't close any
http://sourceware.org/bugzilla/show_bug.cgi?id=15660 --- Comment #5 from Martin Liška --- I did so, thin library was created, but linker is still complaining about f ile descriptors: g++ -Wl,-z,now -Wl,-z,relro -pthread -Wl,-z,noexecstack -fPIC -pie -L. -flt o=9 -fno-fat-lto-objects -O2 --param lto-partitions=64 -o chrome obj/chrome/app/chrome.chrome_exe_main_gtk.o obj/chrome/app/chrome.chrome_ma in.o obj/chrome/app/chrome.chrome_main_delegate.o lib.a -lX11 -lXcursor -lXrandr -lXrender -lXss -lXext -lrt -ldl -lgmodule-2.0 -lgobject-2.0 -lgthread-2.0 -lglib-2.0 -lXtst -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgio-2.0 -lpangoft2-1.0 -lpangocairo-1.0 -lgdk_pixbuf-2.0 -lcairo -lpango-1.0 -lfree type -lfontconfig -lXi -lsmime3 -lnssutil3 -lnss3 -lplds4 -lplc4 -lnspr4 -lgconf -2 -lresolv -lXcomposite -lasound -lXdamage -lXfixes -lcups -lgnutls -lgcrypt -lgpg-error -lz -lpthread -lcrypt -lm -L/usr/lib64 -lexpat -ldbus-1 -ludev -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/15660] out of file descriptors and couldn't close any
http://sourceware.org/bugzilla/show_bug.cgi?id=15660 --- Comment #4 from Cary Coutant --- > Next step was to create one large archive, so: > > ar r [list of all *.a] /tmp/lib.a > > g++ -Wl,-z,now -Wl,-z,relro -pthread -Wl,-z,noexecstack -fPIC -pie -L. -flto=9 > -fno-fat-lto-objects -O2 --param lto-partitions=64 -o chrome > obj/chrome/app/chrome.chrome_exe_main_gtk.o > obj/chrome/app/chrome.chrome_main.o > obj/chrome/app/chrome.chrome_main_delegate.o /tmp/lib.a -lX11 -lXcursor > -lXrandr -lXrender -lXss -lXext -lrt -ldl -lgmodule-2.0 -lgobject-2.0 > -lgthread-2.0 -lglib-2.0 -lXtst -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 > -lgio-2.0 > -lpangoft2-1.0 -lpangocairo-1.0 -lgdk_pixbuf-2.0 -lcairo -lpango-1.0 > -lfreetype > -lfontconfig -lXi -lsmime3 -lnssutil3 -lnss3 -lplds4 -lplc4 -lnspr4 -lgconf-2 > -lresolv -lXcomposite -lasound -lXdamage -lXfixes -lcups -lgnutls -lgcrypt > -lgpg-error -lz -lpthread -lcrypt -lm -L/usr/lib64 -lexpat -ldbus-1 -ludev > > I was shown big amount of undefined symbols, did I use the correct way how to > create the archive? You need the 'T' option to make a thin archive. Otherwise an archive of other archives makes a plain non-library archive file. -cary -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/15660] out of file descriptors and couldn't close any
http://sourceware.org/bugzilla/show_bug.cgi?id=15660 --- Comment #3 from Martin Liška --- ulimit -n 1024 I tried same command line without --start-group/--end-group, but didn't hel p. Next step was to create one large archive, so: ar r [list of all *.a] /tmp/lib.a g++ -Wl,-z,now -Wl,-z,relro -pthread -Wl,-z,noexecstack -fPIC -pie -L. -flt o=9 -fno-fat-lto-objects -O2 --param lto-partitions=64 -o chrome obj/chrome/app/chrome.chrome_exe_main_gtk.o obj/chrome/app/chrome.chrome_ma in.o obj/chrome/app/chrome.chrome_main_delegate.o /tmp/lib.a -lX11 -lXcursor -lXrandr -lXrender -lXss -lXext -lrt -ldl -lgmodule-2.0 -lgobject-2.0 -lgthread-2.0 -lglib-2.0 -lXtst -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgio -2.0 -lpangoft2-1.0 -lpangocairo-1.0 -lgdk_pixbuf-2.0 -lcairo -lpango-1.0 -lfree type -lfontconfig -lXi -lsmime3 -lnssutil3 -lnss3 -lplds4 -lplc4 -lnspr4 -lgconf -2 -lresolv -lXcomposite -lasound -lXdamage -lXfixes -lcups -lgnutls -lgcrypt -lgpg-error -lz -lpthread -lcrypt -lm -L/usr/lib64 -lexpat -ldbus-1 -ludev I was shown big amount of undefined symbols, did I use the correct way how to create the archive? Thanks, Martin -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/15660] out of file descriptors and couldn't close any
http://sourceware.org/bugzilla/show_bug.cgi?id=15660 --- Comment #2 from Cary Coutant --- Is there any way that you can shrink the extent of the --start-group/--end-group options? My first guess is that it's related to having all those files inside the library group. In particular, .o files do not need to be inside the group. It might be better to build a thin archive from all those .a files, then just link against the thin archive (the linker will treat all the nested member libraries as one giant archive library). -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/15660] out of file descriptors and couldn't close any
http://sourceware.org/bugzilla/show_bug.cgi?id=15660 --- Comment #1 from Ian Lance Taylor --- What does "ulimit -n" display? -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
