[Bug gold/17432] internal error in relocate_tls, at gold/x86_64.cc:3829
https://sourceware.org/bugzilla/show_bug.cgi?id=17432 --- Comment #6 from cvs-commit at gcc dot gnu.org cvs-commit at gcc dot gnu.org --- This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project gdb and binutils. The branch, master has been updated via db4c959472b3a8f82cfb67d2532ba22f44ab98da (commit) from cd6da0366dc6684d32f349b729b5558258fc3af4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=db4c959472b3a8f82cfb67d2532ba22f44ab98da commit db4c959472b3a8f82cfb67d2532ba22f44ab98da Author: Cary Coutant ccout...@google.com Date: Tue Sep 30 16:06:50 2014 -0700 Fix error from previous patch where tosize and tovalue were redefined in a block, shadowing the declarations outside the block. gold/ PR gold/17432 * resolve.cc (Symbol_table::resolve): Fix local shadowing error. --- Summary of changes: gold/ChangeLog |5 + gold/resolve.cc |4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/17432] internal error in relocate_tls, at gold/x86_64.cc:3829
https://sourceware.org/bugzilla/show_bug.cgi?id=17432 --- Comment #2 from Markus Trippelsdorf markus at trippelsdorf dot de --- Honza posted a disassembly: https://gcc.gnu.org/ml/gcc-patches/2014-09/msg02208.html -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/17432] internal error in relocate_tls, at gold/x86_64.cc:3829
https://sourceware.org/bugzilla/show_bug.cgi?id=17432 --- Comment #3 from Cary Coutant ccoutant at google dot com --- When we add the placeholder symbol from the claimed file handler, it's not marked as a TLS symbol (the API doesn't provide a way). We're supposed to override the placeholder symbol with the real symbol when we see the real ELF file, but we don't do that for COMMON symbols. Shouldn't be too hard to fix. -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/17432] internal error in relocate_tls, at gold/x86_64.cc:3829
https://sourceware.org/bugzilla/show_bug.cgi?id=17432 --- Comment #4 from cvs-commit at gcc dot gnu.org cvs-commit at gcc dot gnu.org --- This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project gdb and binutils. The branch, master has been updated via 1707f183446fae9aca8523c1ebf721bcf2472008 (commit) from d7ac9d81bb1a177264187efc51c9cc0479cdd09c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=1707f183446fae9aca8523c1ebf721bcf2472008 commit 1707f183446fae9aca8523c1ebf721bcf2472008 Author: Cary Coutant ccout...@google.com Date: Thu Sep 25 21:47:10 2014 -0700 Fix problem where TLS common symbols are not allocated properly during LTO. The plugin API doesn't provide a way for the claimed file handler to identify a TLS symbol, so when adding a common TLS symbol, gold mistakenly places the symbol in the non-TLS commons list, and does not override it when we see the replacement symbol that is marked as TLS. Consequently, we allocate the TLS common symbol as a regular common, and, if it's the only TLS in the program, we'll give an internal error because we haven't allocated a TLS segment. This patch fixes the problem by removing an exclusion where common symbols would not override the placeholder symbols, but checking to see if the size needs adjusting (the original reason for the exclusion). Furthermore, we need to avoid putting placeholder symbols in the common list, and wait until we see a real common symbol with a type we can trust. gold/ PR gold/17432 * resolve.cc (Symbol_table::resolve): Override common placeholder symbols, but adjust sizes. * symtab.cc (Symbol_table::add_from_object): Don't add placeholder symbols to common lists. --- Summary of changes: gold/ChangeLog |8 gold/resolve.cc | 23 +++ gold/symtab.cc | 12 3 files changed, 35 insertions(+), 8 deletions(-) -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/17432] internal error in relocate_tls, at gold/x86_64.cc:3829
https://sourceware.org/bugzilla/show_bug.cgi?id=17432 Cary Coutant ccoutant at google dot com changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #5 from Cary Coutant ccoutant at google dot com --- Fixed on trunk. -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/17432] internal error in relocate_tls, at gold/x86_64.cc:3829
https://sourceware.org/bugzilla/show_bug.cgi?id=17432 Cary Coutant ccoutant at google dot com changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/17432] internal error in relocate_tls, at gold/x86_64.cc:3829
https://sourceware.org/bugzilla/show_bug.cgi?id=17432 --- Comment #1 from Ian Lance Taylor ian at airs dot com --- Can you show how gold is invoked? Can you show the input files? -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
