[Bug ld/25210] aarch64: -fix-cortex-a53-835769 --fix-cortex-a53-843419 lead to invalid operation
https://sourceware.org/bugzilla/show_bug.cgi?id=25210 Tamar Christina changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #7 from Tamar Christina --- Fixed on master and backported -- You are receiving this mail because: You are on the CC list for the bug.
[Bug ld/25210] aarch64: -fix-cortex-a53-835769 --fix-cortex-a53-843419 lead to invalid operation
https://sourceware.org/bugzilla/show_bug.cgi?id=25210
--- Comment #6 from cvs-commit at gcc dot gnu.org ---
The binutils-2_33-branch branch has been updated by Tamar Christina
:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=69a29b6e0642a98df15e65c0d5acfcb9c9cad2cb
commit 69a29b6e0642a98df15e65c0d5acfcb9c9cad2cb
Author: Tamar Christina
Date: Thu Jan 2 14:06:01 2020 +
AArch64: Revert SEC_LINKER_CREATED for AArch64 stubs (PR/25210)
The SEC_LINKER_CREATED flag was added as a fix for PR 24753. I believe
that
part of the fix in compress.c to still be correct as linker created
sections
don't have a size on disk and it fixes the Arm bootstrap regression.
So I'm partially revert this change so that we don't have to manage the
section
manually as implied by SEC_LINKER_CREATED as it's causing an error when
both
errata workarounds are used together and it wasn't needed. This can also
be
seen from that the arm bootstrap was fixed and no flag was added to it's
stubs.
ld/ChangeLog:
PR 25210
PR 24753
* emultempl/aarch64elf.em (elf${ELFSIZE}_aarch64_add_stub_section):
Remove SEC_LINKER_CREATED.
* testsuite/ld-aarch64/aarch64-elf.exp: Add erratum835769-843419.
* testsuite/ld-aarch64/erratum835769-843419.d: New test.
(cherry picked from commit 0db131fb835e4c4f6a024e86743467e7e01c965e)
Signed-off-by: Tamar Christina
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug ld/25210] aarch64: -fix-cortex-a53-835769 --fix-cortex-a53-843419 lead to invalid operation
https://sourceware.org/bugzilla/show_bug.cgi?id=25210 --- Comment #5 from cvs-commit at gcc dot gnu.org --- The master branch has been updated by Tamar Christina : https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8cd0e5e93145699736a370b271ff03f3f41670b0 commit 8cd0e5e93145699736a370b271ff03f3f41670b0 Author: Tamar Christina Date: Fri Jan 10 13:48:57 2020 + AArch64: Revert setting of elf class in linker stub. This changes the fix to PR 25210 by removing the ELF class change. As it turns out the correct change was only the change in compress.c. Everything else is unneeded and setting the elf class is making the linker behave very oddly under LTO. The first stub is correctly written out but for the rest the suddenly don't have a pointer to the stub section anymore. This caused SPEC to fail as the program would branch to the stub and it wouldn't be filled in. Committed to master under the trivial rule as this is partially reverting a previous commit. bfd/ChangeLog: PR 25210 * elfnn-aarch64.c (_bfd_aarch64_create_stub_section): Remove elfclass. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug ld/25210] aarch64: -fix-cortex-a53-835769 --fix-cortex-a53-843419 lead to invalid operation
https://sourceware.org/bugzilla/show_bug.cgi?id=25210
--- Comment #4 from cvs-commit at gcc dot gnu.org ---
The master branch has been updated by Tamar Christina
:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=0db131fb835e4c4f6a024e86743467e7e01c965e
commit 0db131fb835e4c4f6a024e86743467e7e01c965e
Author: Tamar Christina
Date: Thu Jan 2 14:06:01 2020 +
AArch64: Set the correct ELF class for AArch64 stubs (PR/25210)
This fixes PR 25210 by specifying the the correct ELF class for AArch64
stubs.
After doing this the stub section starts behaving like a normal object file
loaded from disk. That is SEC_LINKER_CREATED causes us to have to write
the
section manually.
This flag was added as a fix for PR 24753. I believe that
fix to still be correct as linker created sections don't have a size on
disk
and it fixes the Arm bootstrap regression. But in this case specifying the
correct section class also makes the stub section not be considered by
compress.c.
So I'm partially revert this change so that we don't have to manage the
section
manually as implied by SEC_LINKER_CREATED.
bfd/ChangeLog:
PR 25210
PR 24753
* elfnn-aarch64.c (_bfd_aarch64_create_stub_section): Set ELF class.
ld/ChangeLog:
PR 25210
PR 24753
* emultempl/aarch64elf.em (elf${ELFSIZE}_aarch64_add_stub_section):
Remove SEC_LINKER_CREATED.
* testsuite/ld-aarch64/aarch64-elf.exp: Add erratum835769-843419.
* testsuite/ld-aarch64/erratum835769-843419.d: New test.
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug ld/25210] aarch64: -fix-cortex-a53-835769 --fix-cortex-a53-843419 lead to invalid operation
https://sourceware.org/bugzilla/show_bug.cgi?id=25210 Tamar Christina changed: What|Removed |Added CC||tnfchris at sourceware dot org Assignee|unassigned at sourceware dot org |tnfchris at sourceware dot org -- You are receiving this mail because: You are on the CC list for the bug.
[Bug ld/25210] aarch64: -fix-cortex-a53-835769 --fix-cortex-a53-843419 lead to invalid operation
https://sourceware.org/bugzilla/show_bug.cgi?id=25210 Christophe Lyon changed: What|Removed |Added CC||clyon at gcc dot gnu.org -- You are receiving this mail because: You are on the CC list for the bug.
[Bug ld/25210] aarch64: -fix-cortex-a53-835769 --fix-cortex-a53-843419 lead to invalid operation
https://sourceware.org/bugzilla/show_bug.cgi?id=25210 Icenowy Zheng changed: What|Removed |Added CC||icenowy at aosc dot io --- Comment #3 from Icenowy Zheng --- By bisecting, I found this in fact related to the fix of PR24753 , which introduced an external SEC_LINKER_CREATED flag to the stub section. This change seems bogus (at least not related to the problem reported in PR24753 ). -- You are receiving this mail because: You are on the CC list for the bug.
[Bug ld/25210] aarch64: -fix-cortex-a53-835769 --fix-cortex-a53-843419 lead to invalid operation
https://sourceware.org/bugzilla/show_bug.cgi?id=25210 Peter Robinson changed: What|Removed |Added CC||pbrobinson at gmail dot com -- You are receiving this mail because: You are on the CC list for the bug.
[Bug ld/25210] aarch64: -fix-cortex-a53-835769 --fix-cortex-a53-843419 lead to invalid operation
https://sourceware.org/bugzilla/show_bug.cgi?id=25210 Alan Modra changed: What|Removed |Added CC||amodra at gmail dot com --- Comment #2 from Alan Modra --- > ./ld-new: linker stubs: file class ELFCLASSNONE incompatible with ELFCLASS64 See bfd/elf64ppc.c ppc64_elf_init_stub_bfd. elf64-ppc.c size_stubs avoids looking at the stub bfd by excluding any bfd with symtab_hdr->sh_info zero. No symbols, not even locals, is generally an uninteresting file. Also, I'd say elfNN_aarch64_size_stubs ought to be checking that the input bfds are aarch64-elf. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug ld/25210] aarch64: -fix-cortex-a53-835769 --fix-cortex-a53-843419 lead to invalid operation
https://sourceware.org/bugzilla/show_bug.cgi?id=25210 --- Comment #1 from Michael Matz --- FWIW, master still has the same problem and the same patch helps. -- You are receiving this mail because: You are on the CC list for the bug.
