[Bug ld/25327] FAIL: Run pr20276
https://sourceware.org/bugzilla/show_bug.cgi?id=25327 Nick Clifton changed: What|Removed |Added CC||nickc at redhat dot com --- Comment #1 from Nick Clifton --- Created attachment 12163 --> https://sourceware.org/bugzilla/attachment.cgi?id=12163&action=edit Proposed patch Hi John, Please could you try out the attached patch and let me know if it works ? Cheers Nick -- You are receiving this mail because: You are on the CC list for the bug.
[Bug ld/25327] FAIL: Run pr20276
https://sourceware.org/bugzilla/show_bug.cgi?id=25327 Nick Clifton changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug.
[Bug ld/25327] FAIL: Run pr20276
https://sourceware.org/bugzilla/show_bug.cgi?id=25327 Nick Clifton changed: What|Removed |Added Assignee|unassigned at sourceware dot org |nickc at redhat dot com -- You are receiving this mail because: You are on the CC list for the bug.
[Bug ld/25327] FAIL: Run pr20276
https://sourceware.org/bugzilla/show_bug.cgi?id=25327 --- Comment #2 from dave.anglin at bell dot net --- On 2020-01-03 6:33 a.m., nickc at redhat dot com wrote: > Please could you try out the attached patch and let me know if it works ? Hi Nick, The patch resolves the fail. Happy New Year, Dave -- You are receiving this mail because: You are on the CC list for the bug.
[Bug ld/25327] FAIL: Run pr20276
https://sourceware.org/bugzilla/show_bug.cgi?id=25327 --- Comment #3 from dave.anglin at bell dot net --- On 2020-01-04 3:56 p.m., dave.anglin at bell dot net wrote: > https://sourceware.org/bugzilla/show_bug.cgi?id=25327 > > --- Comment #2 from dave.anglin at bell dot net --- > On 2020-01-03 6:33 a.m., nickc at redhat dot com wrote: >> Please could you try out the attached patch and let me know if it works ? > Hi Nick, > > The patch resolves the fail. There's something wierd going on. I did a full build and check with patches for ld/25326 and ld/25327 and the following teats failed: FAIL: Run with libfunc1.so comm1.o FAIL: Run pr20267a FAIL: Run pr20267b I then reran the testsuite and these tests didn't fail. In my first check, I just reran testsuite with patches. Dave -- You are receiving this mail because: You are on the CC list for the bug.
[Bug ld/25327] FAIL: Run pr20276
https://sourceware.org/bugzilla/show_bug.cgi?id=25327 --- Comment #4 from Nick Clifton --- (In reply to dave.anglin from comment #3) Hi Dave, > There's something wierd going on. I did a full build and check with patches > for ld/25326 and ld/25327 > and the following teats failed: > > FAIL: Run with libfunc1.so comm1.o > FAIL: Run pr20267a > FAIL: Run pr20267b > > I then reran the testsuite and these tests didn't fail. In my first check, > I just reran testsuite with patches. OK - that is strange. Do you still have the ld.log file for the failing tests ? If so, please can you inspect it and see if the "-fcommon" option added by the patch is present on the command lines used to build pr20267a and pr20267b ? Is it possible that different versions of gcc are being used for the failing and passing versions of the tests ? Uh - not sure how else this could happen... :-( Cheers Nick -- You are receiving this mail because: You are on the CC list for the bug.
[Bug ld/25327] FAIL: Run pr20276
https://sourceware.org/bugzilla/show_bug.cgi?id=25327 --- Comment #5 from dave.anglin at bell dot net --- On 2020-01-06 5:14 a.m., nickc at redhat dot com wrote: > Is it possible that different versions of gcc are being used for the failing > and passing versions of the tests ? That's it. The fails are with gcc-10 experimental. The tests pass with Debian gcc-9. Dave -- You are receiving this mail because: You are on the CC list for the bug.
[Bug ld/25327] FAIL: Run pr20276
https://sourceware.org/bugzilla/show_bug.cgi?id=25327 --- Comment #6 from cvs-commit at gcc dot gnu.org --- The master branch has been updated by Nick Clifton : https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=0e1f1593bc441863d0e5dc586ca3dd8945d36782 commit 0e1f1593bc441863d0e5dc586ca3dd8945d36782 Author: Nick Clifton Date: Mon Jan 6 16:24:23 2020 + Add -fcommon compiler command line option to linker tests that need common symbols. PR 25327 * testsuite/ld-elf/shared.exp: Add -fcommon option to compiler command line when building libcomm1.o and pr13250 tests. * testsuite/ld-plugin/lto.exp: Likewise for pr20267 tests. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug ld/25327] FAIL: Run pr20276
https://sourceware.org/bugzilla/show_bug.cgi?id=25327 Nick Clifton changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #7 from Nick Clifton --- Hi Dave, Right - I have gone ahead and built my own gcc-10 compiler, built a toolchain with it, and then run the linker testsuite. Sure enough I encountered the failures that you have mentioned. So I add some more "-fcommon" options to the linker tests, (possibly too many, but the extras should not hurt), and verified that the results should now be correct. At least for the x86_64-linux-gnu target Cheers Nick -- You are receiving this mail because: You are on the CC list for the bug.
[Bug ld/25327] FAIL: Run pr20276
https://sourceware.org/bugzilla/show_bug.cgi?id=25327 Andrew Pinski changed: What|Removed |Added CC||pinskia at gcc dot gnu.org --- Comment #8 from Andrew Pinski --- *** Bug 25285 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug.
