Re: Untranslated strings in readelf.c

2010-04-20 Thread Nick Clifton

Hi Frédéric,


Several untranlated strings exist in binutils 2.20 in function
process_mips_specific of readelf.c.


Actually there seems to be a lot of places in the binutils code that 
need translation macros added.  I am going to check in the attached 
patch in order to address this problem.


Cheers
  Nick

binutils/ChangeLog
2010-04-20  Nick Clifton  ni...@redhat.com

* readelf.c: Add _() macros to constant strings that are
translatable.
Index: binutils/readelf.c
===
RCS file: /cvs/src/src/binutils/readelf.c,v
retrieving revision 1.493
diff -c -3 -p -r1.493 readelf.c
*** binutils/readelf.c	15 Apr 2010 10:56:36 -	1.493
--- binutils/readelf.c	20 Apr 2010 07:11:11 -
*** static void (* byte_put) (unsigned char 
*** 263,272 
  
  #define UNKNOWN -1
  
! #define SECTION_NAME(X)	\
!   ((X) == NULL ? none \
!   : string_table == NULL ? no-name \
!   : ((X)-sh_name = string_table_length ? corrupt \
: string_table + (X)-sh_name))
  
  #define DT_VERSIONTAGIDX(tag)	(DT_VERNEEDNUM - (tag))	/* Reverse order!  */
--- 263,272 
  
  #define UNKNOWN -1
  
! #define SECTION_NAME(X)		\
!   ((X) == NULL ? _(none)	\
!: string_table == NULL ? _(no-name)			\
!: ((X)-sh_name = string_table_length ? _(corrupt)	\
: string_table + (X)-sh_name))
  
  #define DT_VERSIONTAGIDX(tag)	(DT_VERNEEDNUM - (tag))	/* Reverse order!  */
*** dump_relocations (FILE * file,
*** 1302,1308 
else if (symtab_index)
  	{
  	  if (symtab == NULL || symtab_index = nsyms)
! 	printf ( bad symbol index: %08lx, (unsigned long) symtab_index);
  	  else
  	{
  	  Elf_Internal_Sym * psym;
--- 1302,1308 
else if (symtab_index)
  	{
  	  if (symtab == NULL || symtab_index = nsyms)
! 	printf (_( bad symbol index: %08lx), (unsigned long) symtab_index);
  	  else
  	{
  	  Elf_Internal_Sym * psym;
*** decode_ARM_machine_flags (unsigned e_fla
*** 2200,2206 
  }
  
if (unknown)
! strcat (buf,, unknown);
  }
  
  static char *
--- 2200,2206 
  }
  
if (unknown)
! strcat (buf,_(, unknown));
  }
  
  static char *
*** get_machine_flags (unsigned e_flags, uns
*** 2326,2335 
  	strcat (buf, , emb);
  
  	  if (e_flags  EF_PPC_RELOCATABLE)
! 	strcat (buf, , relocatable);
  
  	  if (e_flags  EF_PPC_RELOCATABLE_LIB)
! 	strcat (buf, , relocatable-lib);
  	  break;
  
  	case EM_V850:
--- 2326,2335 
  	strcat (buf, , emb);
  
  	  if (e_flags  EF_PPC_RELOCATABLE)
! 	strcat (buf, _(, relocatable));
  
  	  if (e_flags  EF_PPC_RELOCATABLE_LIB)
! 	strcat (buf, _(, relocatable-lib));
  	  break;
  
  	case EM_V850:
*** get_machine_flags (unsigned e_flags, uns
*** 2346,2352 
  	  strcat (buf, , v850);
  	  break;
  	default:
! 	  strcat (buf, , unknown v850 architecture variant);
  	  break;
  	}
  	  break;
--- 2346,2352 
  	  strcat (buf, , v850);
  	  break;
  	default:
! 	  strcat (buf, _(, unknown v850 architecture variant));
  	  break;
  	}
  	  break;
*** get_machine_flags (unsigned e_flags, uns
*** 2402,2408 
  	   MIPS ELF does not specify EF_MIPS_MACH, it is a GNU
  	   extension.  */
  	  break;
! 	default: strcat (buf, , unknown CPU); break;
  	}
  
  	  switch ((e_flags  EF_MIPS_ABI))
--- 2402,2408 
  	   MIPS ELF does not specify EF_MIPS_MACH, it is a GNU
  	   extension.  */
  	  break;
! 	default: strcat (buf, _(, unknown CPU)); break;
  	}
  
  	  switch ((e_flags  EF_MIPS_ABI))
*** get_machine_flags (unsigned e_flags, uns
*** 2417,2423 
  	   This means it is likely to be an o32 file, but not for
  	   sure.  */
  	  break;
! 	default: strcat (buf, , unknown ABI); break;
  	}
  
  	  if (e_flags  EF_MIPS_ARCH_ASE_MDMX)
--- 2417,2423 
  	   This means it is likely to be an o32 file, but not for
  	   sure.  */
  	  break;
! 	default: strcat (buf, _(, unknown ABI)); break;
  	}
  
  	  if (e_flags  EF_MIPS_ARCH_ASE_MDMX)
*** get_machine_flags (unsigned e_flags, uns
*** 2437,2443 
  	case E_MIPS_ARCH_32R2: strcat (buf, , mips32r2); break;
  	case E_MIPS_ARCH_64: strcat (buf, , mips64); break;
  	case E_MIPS_ARCH_64R2: strcat (buf, , mips64r2); break;
! 	default: strcat (buf, , unknown ISA); break;
  	}
  
  	  break;
--- 2437,2443 
  	case E_MIPS_ARCH_32R2: strcat (buf, , mips32r2); break;
  	case E_MIPS_ARCH_64: strcat (buf, , mips64); break;
  	case E_MIPS_ARCH_64R2: strcat (buf, , mips64r2); break;
! 	default: strcat (buf, _(, unknown ISA)); break;
  	}
  
  	  break;
*** get_machine_flags (unsigned e_flags, uns
*** 2466,2472 
  	case EF_SH2A_SH3_NOFPU: strcat (buf, , sh2a-nofpu-or-sh3-nommu); break;
  	case 

Untranslated strings in readelf.c

2010-04-16 Thread Frédéric Marchal
Hello,

Several untranlated strings exist in binutils 2.20 in function 
process_mips_specific of readelf.c. In particular around this place:

  10048   printf (_( Reserved entries:\n));
  10049   printf (_(  %*s %10s %*s Purpose\n),
  10050   addr_size * 2, Address, Access,
  10051   addr_size * 2, Initial);
  10052   entry = print_mips_got_entry (data, pltgot, entry);
  10053   printf ( Lazy resolver\n);
  10054   if (data
  10055(byte_get (data + entry - pltgot, addr_size)
  10056(addr_size * 8 - 1)) != 0)
  10057 {
  10058   entry = print_mips_got_entry (data, pltgot, entry);
  10059   printf ( Module pointer (GNU extension)\n);
  10060 }
  10061   printf (\n);
  10062
  10063   if (entry  local_end)
  10064 {
  10065   printf (_( Local entries:\n));
  10066   printf (_(  %*s %10s %*s\n),
  10067   addr_size * 2, Address, Access,
  10068   addr_size * 2, Initial);

Note the missing _() around Address, Access and Initial in the two 
printf.

Frederic


___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils