bug#60620: [PATCH] copy.c: replace set_acl() with chmod_or_fchmod()
> The "at least in Linux" qualification worries me. > Having a very quick look at the qset_acl() code suggests it clears ACLs on > some platforms at least, which chmod_or_fchmod() does not. > Am I reading that wrong? You are right. The question is - why do we need to clear ACLs? The only real example the code in question used is via "cp --no-preserve=mode" where I can't think of a reason why we intentionally clear ACLs
bug#61035: [PATCH] cp: improve help regarding ACLs
Improve help to clarify ACL handling --- src/cp.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/cp.c b/src/cp.c index 016ae8988..73ffd34e9 100644 --- a/src/cp.c +++ b/src/cp.c @@ -239,6 +239,11 @@ When --reflink[=always] is specified, perform a lightweight copy, where the\n\ data blocks are copied only when modified. If this is not possible the copy\n\ fails, or if --reflink=auto is specified, fall back to a standard copy.\n\ Use --reflink=never to ensure a standard copy is performed.\n\ +"), stdout); + fputs (_("\ +\n\ +--preserve=mode also copies ACLs but only if the destination filesystem\n\ +supports ACLs of the same type (i.e. no Posix <> NFSv4 ACLs conversion)\n\ "), stdout); emit_backup_suffix_note (); fputs (_("\ -- 2.39.0
bug#61035: [PATCH] cp: improve help regarding ACLs
On 1/24/23 00:42, Ondrej Valousek wrote: +"), stdout); + fputs (_("\ +\n\ +--preserve=mode also copies ACLs but only if the destination filesystem\n\ +supports ACLs of the same type (i.e. no Posix <> NFSv4 ACLs conversion)\n\ Doesn't the earlier part of the --help output already say something similar when it mentions xattr? It's OK for the --help output to be somewhat terse, with longwinded details in the manual.
bug#61050: mv: add support for --one-file-system
mv will automatically use rename, but if that fails (e.g. with EXDEV), it falls back to copying files. i'd like to require that the mv be atomic when relocating a directory, and if it isn't, fallback to other logic. to that end, it'd be nice if mv supported --one-file-system and would return an error when hitting EXDEV rather than copying. -mike signature.asc Description: PGP signature