Re: [Bug 294348] Re: ubuntu directing users to coreutils mailing list for general problems
Hi, Jim Meyering wrote: James Youngman [EMAIL PROTECTED] wrote: Perhaps something like the attached patch to the usage message might be worthwhile (though I think it is probably too wordy). How about this? From 1ae69757c63e2d0d7e1103f7d17d7d256d625e55 Mon Sep 17 00:00:00 2001 From: James Youngman [EMAIL PROTECTED] Date: Sat, 8 Nov 2008 21:55:50 + Subject: [PATCH] install: indicate clearly it's not for installing packages * src/install.c (usage): Indicate the program copies files, as opposed to installing packages. ... program_name, program_name, program_name, program_name); fputs (_(\ +\n\ +This install program copies files (often just compiled) into destination\n\ +locations you choose. If you want to download and install a ready-to-use\n\ +package on a GNU/Linux system, you should be using a package manager\n\ +like yum(1) or apt-get(1).\n\ +\n\ In the first three forms, copy SOURCE to DEST or multiple SOURCE(s) to\n\ the existing DIRECTORY, while setting permission modes and owner/group.\n\ In the 4th form, create all components of the given DIRECTORY(ies).\n\ -- 1.6.0.3.866.gc189b Just two ideas: 1) I guess program_name variable should be used instead of install in the first added sentence... although it is no-difference change on almost every system and could be meant This install program generally and not just This 'install' program. 2 (heretical)) What about shipping ginstall (and ginstall.1) with install/install.1 just as symlinks pointing there ... Then you will get pointer to ginstall manpage even for man install and such change should not break anything ... In report bugs section will be something like Report ginstall bugs to bug-coreutils@gnu.org which could be more clear for everyone (ginstall word is simply not install word and could not cause confusion). Greetings, Ondřej Vašík signature.asc Description: Toto je digitálně podepsaná část zprávy ___ Bug-coreutils mailing list Bug-coreutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-coreutils
Re: [Bug 294348] Re: ubuntu directing users to coreutils mailing list for general problems
Ondřej Vašík [EMAIL PROTECTED] wrote: +This install program copies files (often just compiled) into destinatio= n\n\ +locations you choose. If you want to download and install a ready-to-u= se\n\ +package on a GNU/Linux system, you should be using a package manager\n\ +like yum(1) or apt-get(1).\n\ +\n\ In the first three forms, copy SOURCE to DEST or multiple SOURCE(s) to\= n\ the existing DIRECTORY, while setting permission modes and owner/group.= \n\ In the 4th form, create all components of the given DIRECTORY(ies).\n\ -- 1.6.0.3.866.gc189b Just two ideas: 1) I guess program_name variable should be used instead of install in the first added sentence... although it is no-difference change on almost every system and could be meant This install program generally and not just This 'install' program. I prefer not to say This ginstall program..., and think the use of the generic install is actually desirable here. 2 (heretical)) What about shipping ginstall (and ginstall.1) with install/install.1 just as symlinks pointing there ... Then you will get pointer to ginstall manpage even for man install and such change should not break anything ... In report bugs section will be something like Report ginstall bugs to bug-coreutils@gnu.org which could be more clear for everyone (ginstall word is simply not install word and could not cause confusion). You're right. That's heretical ;-) ___ Bug-coreutils mailing list Bug-coreutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-coreutils
Re: [Bug 294348] Re: ubuntu directing users to coreutils mailing list for general problems
On Sun, Nov 9, 2008 at 7:57 AM, Jim Meyering [EMAIL PROTECTED] wrote: James Youngman [EMAIL PROTECTED] wrote: Perhaps something like the attached patch to the usage message might be worthwhile (though I think it is probably too wordy). Thank you. I agree. How about this? I like that, thanks. +This install program copies files (often just compiled) into destination\n\ +locations you choose. If you want to download and install a ready-to-use\n\ +package on a GNU/Linux system, you should be using a package manager\n\ +like yum(1) or apt-get(1).\n\ Maybe we could squeeze instead into that sentence, either at the end or just before be using? Thanks, James. ___ Bug-coreutils mailing list Bug-coreutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-coreutils
Re: [Bug 294348] Re: ubuntu directing users to coreutils mailing list for general problems
James Youngman [EMAIL PROTECTED] wrote: On Sun, Nov 9, 2008 at 7:57 AM, Jim Meyering [EMAIL PROTECTED] wrote: James Youngman [EMAIL PROTECTED] wrote: Perhaps something like the attached patch to the usage message might be worthwhile (though I think it is probably too wordy). Thank you. I agree. How about this? I like that, thanks. +This install program copies files (often just compiled) into destination\n\ +locations you choose. If you want to download and install a ready-to-use\n\ +package on a GNU/Linux system, you should be using a package manager\n\ +like yum(1) or apt-get(1).\n\ Maybe we could squeeze instead into that sentence, either at the end or just before be using? Sure. That's better still. I've pushed the result. ___ Bug-coreutils mailing list Bug-coreutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-coreutils
Re: [Bug 294348] Re: ubuntu directing users to coreutils mailing list for general problems
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 11/8/2008 11:51 AM: - /* TRANSLATORS: The placeholder indicates the bug-reporting address - for this package. Please add _another line_ saying - Report translation bugs to ...\n with the address for translation + /* TRANSLATORS: The second placeholder indicates the bug-reporting + address for this package. Please add _another line_ saying + Report %s translation bugs to ...\n with the address for translation bugs (typically your translation team's web or email address). */ - printf (_(\nReport bugs to %s.\n), PACKAGE_BUGREPORT); + printf (_(\nReport %s bugs to %s.\n), last_component (program_name), + PACKAGE_BUGREPORT); And where would the second line's %s be filled in from? You would need to add another last_component call as an additional printf argument before you could suggest that. Doesn't it just suffice to have the text read: Report ls bugs to bug-coreutils@gnu.org. Report translation bugs to - -- Don't work too hard, make some time for fun as well! Eric Blake [EMAIL PROTECTED] -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkkW7xkACgkQ84KuGfSFAYDhFgCeLs35DadjooKGcmjf6eS3UFew THAAnjNpejHeDELucFc6fn709STjLZ4z =v3Xr -END PGP SIGNATURE- ___ Bug-coreutils mailing list Bug-coreutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-coreutils
Re: [Bug 294348] Re: ubuntu directing users to coreutils mailing list for general problems
Eric Blake [EMAIL PROTECTED] wrote: According to Jim Meyering on 11/8/2008 11:51 AM: - /* TRANSLATORS: The placeholder indicates the bug-reporting address - for this package. Please add _another line_ saying - Report translation bugs to ...\n with the address for translation + /* TRANSLATORS: The second placeholder indicates the bug-reporting + address for this package. Please add _another line_ saying + Report %s translation bugs to ...\n with the address for translation bugs (typically your translation team's web or email address). */ - printf (_(\nReport bugs to %s.\n), PACKAGE_BUGREPORT); + printf (_(\nReport %s bugs to %s.\n), last_component (program_name), + PACKAGE_BUGREPORT); And where would the second line's %s be filled in from? You would need to add another last_component call as an additional printf argument before you could suggest that. Doesn't it just suffice to have the text read: Report ls bugs to bug-coreutils@gnu.org. Report translation bugs to Good catch. I started to write the first patch below, but then saw that very few translators have heeded the instructions. diff --git a/src/system.h b/src/system.h index 8577d44..e839d7e 100644 --- a/src/system.h +++ b/src/system.h @@ -614,10 +614,13 @@ ptr_align (void const *ptr, size_t alignment) static inline void emit_bug_reporting_address (void) { - /* TRANSLATORS: The second placeholder indicates the bug-reporting - address for this package. Please add _another line_ saying - Report %s translation bugs to ...\n with the address for translation - bugs (typically your translation team's web or email address). */ + /* TRANSLATORS: The second placeholder indicates the bug-reporting address + for this package. Please append a line saying Report translation bugs + to ...\n with the address for translation bugs (typically your + translation team's web or email address). E.g., in French, + ls --help will print the translation of these two lines: + Report ls bugs to bug-coreutils@gnu.org. + Report translation bugs to http://translationproject.org/team/af.html. printf (_(\nReport %s bugs to %s.\n), last_component (program_name), PACKAGE_BUGREPORT); } So here's a slightly more invasive change: Print the Report translation bugs to diagnostic for all but the C/POSIX locale. Though I'm not sure I want to print such a line in an English locale. In spite of that, I have a slight preference for this approach. Note: if I go that route, then I'll have to remove all other hard-locale.h inclusions to get past make syntax-check. Opinions? diff --git a/src/system.h b/src/system.h index ee0d25c..6e4be48 100644 --- a/src/system.h +++ b/src/system.h @@ -611,15 +611,19 @@ ptr_align (void const *ptr, size_t alignment) ? false : (((Accum) = (Accum) * 10 + (Digit_val)), true)) \ ) +#include hard-locale.h static inline void emit_bug_reporting_address (void) { - /* TRANSLATORS: The second placeholder indicates the bug-reporting - address for this package. Please add _another line_ saying - Report %s translation bugs to ...\n with the address for translation - bugs (typically your translation team's web or email address). */ printf (_(\nReport %s bugs to %s.\n), last_component (program_name), PACKAGE_BUGREPORT); + /* TRANSLATORS: Replace LANG_CODE in this URL with your language code + http://translationproject.org/team/LANG_CODE.html to form one of + the URLs at http://translationproject.org/team/. Otherwise, replace + the entire URL with your team's email address. */ + if (hard_locale (LC_MESSAGES)) +fputs (_(Report translation bugs to +http://translationproject.org/team/\n), stdout); } #include inttostr.h ___ Bug-coreutils mailing list Bug-coreutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-coreutils
Re: [Bug 294348] Re: ubuntu directing users to coreutils mailing list for general problems
HggdH [EMAIL PROTECTED] wrote: A run with 'LC_ALL=fr_FR.utf8 chown --help' produced the 'report a bug' as: Signaler un bug à bug-coreutils@gnu.org. This is, literally, report a bug to Perhaps it might be another option to ask distributions to replace the string with a report a bug to distribution BTS. Thanks, but I think that's not needed -- at least not so far. This foray into --help diagnostics is to avoid reports of totally-unrelated-to-coreutils problems to the bug-coreutils mailing list. ___ Bug-coreutils mailing list Bug-coreutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-coreutils
Re: [Bug 294348] Re: ubuntu directing users to coreutils mailing list for general problems
Eric Blake [EMAIL PROTECTED] wrote: According to Jim Meyering on 11/9/2008 9:09 AM: - printf (_(\nReport bugs to %s.\n), PACKAGE_BUGREPORT); + printf (_(\nReport %s bugs to %s.\n), last_component (program_name), +PACKAGE_BUGREPORT); And where would the second line's %s be filled in from? You would need to add another last_component call as an additional printf argument before you could suggest that. I stand corrected; with $1 notation, you can reuse a printf argument in more than one % specifier. So we could possibly suggest: Report %$1s bugs to %$2s. Report %$1s translation bugs to Good to know, in case we ever go back. Making it a separate diagnostic would indeed make it more obvious that it needs to be translated; but unless all projects adopt this approach, the translated --help strings are not common between projects. I could also go either way on this. Converting coreutils' 100+ programs is a good start, and the untranslated URL (without LANG_CODE) should be useful. So I'm going ahead. + /* TRANSLATORS: Replace LANG_CODE in this URL with your language code + http://translationproject.org/team/LANG_CODE.html to form one of + the URLs at http://translationproject.org/team/. Otherwise, replace + the entire URL with your team's email address. */ + if (hard_locale (LC_MESSAGES)) +fputs (_(Report translation bugs to + http://translationproject.org/team/\n), stdout); Do you want LANG_CODE in the string and not just the comment, to make it more obvious when the string has not been translated? I did that at first, but chose to make it so the default URL will be usable, while we wait for translations to catch up. ___ Bug-coreutils mailing list Bug-coreutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-coreutils
Re: [Bug 294348] Re: ubuntu directing users to coreutils mailing list for general problems
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 11/9/2008 9:09 AM: - printf (_(\nReport bugs to %s.\n), PACKAGE_BUGREPORT); + printf (_(\nReport %s bugs to %s.\n), last_component (program_name), + PACKAGE_BUGREPORT); And where would the second line's %s be filled in from? You would need to add another last_component call as an additional printf argument before you could suggest that. I stand corrected; with $1 notation, you can reuse a printf argument in more than one % specifier. So we could possibly suggest: Report %$1s bugs to %$2s. Report %$1s translation bugs to Doesn't it just suffice to have the text read: Report ls bugs to bug-coreutils@gnu.org. Report translation bugs to Good catch. I started to write the first patch below, but then saw that very few translators have heeded the instructions. Indeed; but that seems like a generic problem where the translation project needs to do a better job of instructing all the teams, as it affects more than just coreutils. Print the Report translation bugs to diagnostic for all but the C/POSIX locale. Though I'm not sure I want to print such a line in an English locale. In spite of that, I have a slight preference for this approach. Note: if I go that route, then I'll have to remove all other hard-locale.h inclusions to get past make syntax-check. Opinions? Making it a separate diagnostic would indeed make it more obvious that it needs to be translated; but unless all projects adopt this approach, the translated --help strings are not common between projects. I could also go either way on this. + /* TRANSLATORS: Replace LANG_CODE in this URL with your language code + http://translationproject.org/team/LANG_CODE.html to form one of + the URLs at http://translationproject.org/team/. Otherwise, replace + the entire URL with your team's email address. */ + if (hard_locale (LC_MESSAGES)) +fputs (_(Report translation bugs to + http://translationproject.org/team/\n), stdout); Do you want LANG_CODE in the string and not just the comment, to make it more obvious when the string has not been translated? - -- Don't work too hard, make some time for fun as well! Eric Blake [EMAIL PROTECTED] -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkkXTpAACgkQ84KuGfSFAYAFHACfWKzEoktxyzfiVnYdxWmLQtxq YYIAnimT+3Vjsw+2X7hHw245ZHMlbVEO =V2K1 -END PGP SIGNATURE- ___ Bug-coreutils mailing list Bug-coreutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-coreutils
Re: [Bug 294348] Re: ubuntu directing users to coreutils mailing list for general problems
Ondřej Vašík [EMAIL PROTECTED] wrote: I googled a bit about that french issue, it was already reported to translation team. Answer was that it could be caused by translation like report all bugs to [EMAIL PROTECTED] instead of report bugs to [EMAIL PROTECTED] . I don't think so, I guess it is too similar to cause such confusion, I would prefer formulation like report bugs related to programname utility to bug-coreutils@gnu.org anyway ... will check if it is acceptable by upstream... Thanks for pursuing that. I like the idea and will probably address it with a change like this: diff --git a/src/system.h b/src/system.h index e88b1bb..8577d44 100644 --- a/src/system.h +++ b/src/system.h @@ -614,11 +614,12 @@ ptr_align (void const *ptr, size_t alignment) static inline void emit_bug_reporting_address (void) { - /* TRANSLATORS: The placeholder indicates the bug-reporting address - for this package. Please add _another line_ saying - Report translation bugs to ...\n with the address for translation + /* TRANSLATORS: The second placeholder indicates the bug-reporting + address for this package. Please add _another line_ saying + Report %s translation bugs to ...\n with the address for translation bugs (typically your translation team's web or email address). */ - printf (_(\nReport bugs to %s.\n), PACKAGE_BUGREPORT); + printf (_(\nReport %s bugs to %s.\n), last_component (program_name), + PACKAGE_BUGREPORT); } #include inttostr.h ___ Bug-coreutils mailing list Bug-coreutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-coreutils
Re: [Bug 294348] Re: ubuntu directing users to coreutils mailing list for general problems
On Sat, 2008-11-08 at 19:51 +0100, Jim Meyering wrote: Ondřej Vašík [EMAIL PROTECTED] wrote: I googled a bit about that french issue, it was already reported to translation team. Answer was that it could be caused by translation like report all bugs to [EMAIL PROTECTED] instead of report bugs to [EMAIL PROTECTED] . I don't think so, I guess it is too similar to cause such confusion, I would prefer formulation like report bugs related to programname utility to bug-coreutils@gnu.org anyway ... will check if it is acceptable by upstream... Thanks for pursuing that. I like the idea and will probably address it with a change like this: diff --git a/src/system.h b/src/system.h index e88b1bb..8577d44 100644 --- a/src/system.h +++ b/src/system.h @@ -614,11 +614,12 @@ ptr_align (void const *ptr, size_t alignment) static inline void emit_bug_reporting_address (void) { - /* TRANSLATORS: The placeholder indicates the bug-reporting address - for this package. Please add _another line_ saying - Report translation bugs to ...\n with the address for translation + /* TRANSLATORS: The second placeholder indicates the bug-reporting + address for this package. Please add _another line_ saying + Report %s translation bugs to ...\n with the address for translation bugs (typically your translation team's web or email address). */ - printf (_(\nReport bugs to %s.\n), PACKAGE_BUGREPORT); + printf (_(\nReport %s bugs to %s.\n), last_component (program_name), + PACKAGE_BUGREPORT); } #include inttostr.h A run with 'LC_ALL=fr_FR.utf8 chown --help' produced the 'report a bug' as: Signaler un bug à bug-coreutils@gnu.org. This is, literally, report a bug to Perhaps it might be another option to ask distributions to replace the string with a report a bug to distribution BTS. Regards, signature.asc Description: This is a digitally signed message part ___ Bug-coreutils mailing list Bug-coreutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-coreutils
Re: [Bug 294348] Re: ubuntu directing users to coreutils mailing list for general problems
Perhaps something like the attached patch to the usage message might be worthwhile (though I think it is probably too wordy). James. From 54614d88bc91d0c188108b467fb518c7d3de7c06 Mon Sep 17 00:00:00 2001 From: James Youngman [EMAIL PROTECTED] Date: Sat, 8 Nov 2008 21:55:50 + Subject: [PATCH] install: indicate clearly it's not for installing packages. To: bug-coreutils@gnu.org * src/instrall.c (usage): Indicate the program copies binary files, as opposed to installing packages. --- src/install.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/src/install.c b/src/install.c index a7c3b3d..a320868 100644 --- a/src/install.c +++ b/src/install.c @@ -816,6 +816,14 @@ Usage: %s [OPTION]... [-T] SOURCE DEST\n\ ), program_name, program_name, program_name, program_name); fputs (_(\ +\n\ +The install utility copies files (which you will normally have recently\n\ +compiled) into the location you decided to install them. If in fact you\n\ +want to download and install a ready-to-use package instead of compiling it\n\ +yourself, you should probably be using different program. The right choice\n\ +of program depends on your operating system. Popular choices for GNU/Linux\n\ +systems are yum(1) and apt-get(1).\n\ +\n\ In the first three forms, copy SOURCE to DEST or multiple SOURCE(s) to\n\ the existing DIRECTORY, while setting permission modes and owner/group.\n\ In the 4th form, create all components of the given DIRECTORY(ies).\n\ -- 1.5.6.5 ___ Bug-coreutils mailing list Bug-coreutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-coreutils
Re: [Bug 294348] Re: ubuntu directing users to coreutils mailing list for general problems
James Youngman [EMAIL PROTECTED] wrote: Perhaps something like the attached patch to the usage message might be worthwhile (though I think it is probably too wordy). Thank you. I agree. How about this? From 1ae69757c63e2d0d7e1103f7d17d7d256d625e55 Mon Sep 17 00:00:00 2001 From: James Youngman [EMAIL PROTECTED] Date: Sat, 8 Nov 2008 21:55:50 + Subject: [PATCH] install: indicate clearly it's not for installing packages * src/install.c (usage): Indicate the program copies files, as opposed to installing packages. --- src/install.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/install.c b/src/install.c index a7c3b3d..3f085af 100644 --- a/src/install.c +++ b/src/install.c @@ -816,6 +816,12 @@ Usage: %s [OPTION]... [-T] SOURCE DEST\n\ ), program_name, program_name, program_name, program_name); fputs (_(\ +\n\ +This install program copies files (often just compiled) into destination\n\ +locations you choose. If you want to download and install a ready-to-use\n\ +package on a GNU/Linux system, you should be using a package manager\n\ +like yum(1) or apt-get(1).\n\ +\n\ In the first three forms, copy SOURCE to DEST or multiple SOURCE(s) to\n\ the existing DIRECTORY, while setting permission modes and owner/group.\n\ In the 4th form, create all components of the given DIRECTORY(ies).\n\ -- 1.6.0.3.866.gc189b ___ Bug-coreutils mailing list Bug-coreutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-coreutils