Re: Make Check on coreutils, darwin failed

2005-05-10 Thread Jim Meyering
Eric Blake <[EMAIL PROTECTED]> wrote:
> According to Adam Price on 5/9/2005 11:39 PM:
>> Making check in touch
>> make  check-TESTS
>> PASS: relative
>> 0a1
>>> touch: setting times of `/': Permission denied
>> FAIL: not-owner
>
> I've noticed that cygwin also tends to fail this test, because the typical
> cygwin user installed / themselves (as c:\cygwin) and has write access to
> change /.  I don't know if there is a better approach to finding a
> directory that the user does not have rights to (cygwin will soon have //
> appear as a directory with read-only properties, so // might work, but
> doesn't generalize well).  Perhaps something like this is needed in
> tests/touch/not-owner:
>
> if test `stat -c %u /` = `id -u` ; then
...

Thanks to both of you.
I've just added tests to check owner/group and whether /
is writable -- using `test' makes it easier :)

Index: tests/touch/not-owner
===
RCS file: /fetish/cu/tests/touch/not-owner,v
retrieving revision 1.3
retrieving revision 1.5
diff -u -p -r1.3 -r1.5
--- tests/touch/not-owner   23 Jun 2004 15:07:05 -  1.3
+++ tests/touch/not-owner   10 May 2005 13:30:39 -  1.5
@@ -11,6 +11,17 @@ fi
 . $srcdir/../lang-default
 PRIV_CHECK_ARG=require-non-root . $srcdir/../priv-check
 
+test=../../src/test
+if $test -w /; then
+  echo Skipping because you have write access to /.
+  (exit 77); exit 77
+fi
+
+if $test -O / || $test -G /; then
+  echo Skipping because you own /.
+  (exit 77); exit 77
+fi
+
 pwd=`pwd`
 t0=`echo "$0"|sed 's,.*/,,'`.tmp; tmp=$t0/$$
 trap 'status=$?; cd $pwd; chmod -R u+rwx $t0; rm -rf $t0 && exit $status' 0


___
Bug-coreutils mailing list
Bug-coreutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-coreutils


Re: Make Check on coreutils, darwin failed

2005-05-10 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

According to Adam Price on 5/9/2005 11:39 PM:
> Making check in touch
> make  check-TESTS
> PASS: relative
> 0a1
>> touch: setting times of `/': Permission denied
> FAIL: not-owner

I've noticed that cygwin also tends to fail this test, because the typical
cygwin user installed / themselves (as c:\cygwin) and has write access to
change /.  I don't know if there is a better approach to finding a
directory that the user does not have rights to (cygwin will soon have //
appear as a directory with read-only properties, so // might work, but
doesn't generalize well).  Perhaps something like this is needed in
tests/touch/not-owner:

if test `stat -c %u /` = `id -u` ; then
  echo Skipping because / is owned by user >2
  (exit 77); exit 77
fi
group=`stat -c %g /`
for g in `id -G` ; do
  if test $group = $g ; then
echo Skipping because / belongs to user's group >2
(exit 77); exit 77
  fi
done

- --
Life is short - so eat dessert first!

Eric Blake [EMAIL PROTECTED]
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.0 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCgKqD84KuGfSFAYARAuuXAJ0Vo+uBwLnjzUXkK6YGeXN4kef1SwCgipI5
FwdGOXEIQ1a+eZ2lKf5KLuI=
=ZqOw
-END PGP SIGNATURE-


___
Bug-coreutils mailing list
Bug-coreutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-coreutils


Make Check on coreutils, darwin failed

2005-05-10 Thread Adam Price
I am running macosx 10.4 with newly installed xcode tools.  Make  
check failed.  I am providing the first ~20 lines of config.log and  
the last ~50 lines of the output of 'make check.'  Let me know if you  
want any other information.  (I ran make install and everything seems  
to be working fine.)

config.log
## - ##
## Platform. ##
## - ##
hostname = New
uname -m = Power Macintosh
uname -r = 8.0.0
uname -s = Darwin
uname -v = Darwin Kernel Version 8.0.0: Sat Mar 26 14:15:22 PST 2005;  
root:xnu-792.obj~1/RELEASE_PPC

/usr/bin/uname -p = powerpc
/bin/uname -X = unknown
/bin/arch  = unknown
/usr/bin/arch -k   = unknown
/usr/convex/getsysinfo = unknown
hostinfo   = Mach kernel version:
 Darwin Kernel Version 8.0.0: Sat Mar 26 14:15:22 PST 2005;  
root:xnu-792.obj~1/RELEASE_PPC
Kernel configured for up to 2 processors.
2 processors are physically available.
Processor type: ppc970 (PowerPC 970)
Processors active: 0 1
Primary memory available: 2.25 gigabytes
Default processor set: 93 tasks, 316 threads, 2 processors
Load average: 0.32, Mach factor: 1.67
/bin/machine   = unknown
/usr/bin/oslevel   = unknown
/bin/universe  = unknown

**  The end of the output of  make check is  
below:


All 1 tests passed
==
Making check in tail-2
make  check-TESTS
./tail-n0f:/proc/13090/status: missing or 'different': skipping this  
test
SKIP: tail-n0f
./big-4gb: This test is relatively expensive, so it is disabled by  
default.
To run it anyway, rerun make check with the RUN_EXPENSIVE_TESTS
environment variable set to yes.  E.g.,

  env RUN_EXPENSIVE_TESTS=yes make check
SKIP: big-4gb
PASS: proc-ksyms
PASS: start-middle
sleeping for 7 seconds...
[1]-  Terminated  tail --follow=name a foo >err 2>&1
PASS: assert
sleeping for 7 seconds...
[1]-  Terminated  tail --follow=name a foo >err 2>&1
PASS: assert-2
==
All 4 tests passed
(2 tests were not run)
==
Making check in test
make  check-TESTS
PASS: test-tests
==
All 1 tests passed
==
Making check in touch
make  check-TESTS
PASS: relative
0a1
> touch: setting times of `/': Permission denied
FAIL: not-owner
PASS: no-create-missing
PASS: fail-diag
PASS: dir-1
PASS: dangling-symlink
sleeping for 2 seconds...
sleeping for 2 seconds...
PASS: empty-file
PASS: fifo
sleeping for 2 seconds...
PASS: no-rights
PASS: obsolescent
==
1 of 10 tests failed
Please report to bug-coreutils@gnu.org
==
make[3]: *** [check-TESTS] Error 1
make[2]: *** [check-am] Error 2
make[1]: *** [check-recursive] Error 1
make: *** [check-recursive] Error 1
___
Bug-coreutils mailing list
Bug-coreutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-coreutils