How to Submit a utility for SSH-CVS
Hi : I am trying to figure out the best way to do this. A lot of time, admins do not wish to run SSH daemon and cvs on the same box. This could be due to network/firewall issues or just plain performance. I have developed a tool (C/C++) "cvsrelay", that allows SSH daemon to invoke CVS via pserver protocol. In other words the admin ensures that SSH daemon invokes cvsrelay either via client env (CVS_SERVER) or SSH env. The cvsrelay executable is a small footprint utility that eseentially reads a config file (/etc/prefs.conf) to figure out which CVS server to relay the request to. I would like to submit the source code to the CVS community. What's the best way ? Regards , Rahul Bhargava ___ Bug-cvs mailing list Bug-cvs@gnu.org http://lists.gnu.org/mailman/listinfo/bug-cvs
Bug report and patch
I hereby grant permission to distribute this patch under the
terms of the GNU Public License.
BUG: 'cvs watch on' and 'cvs watch off' on an empty directory will
clear any default '_watchers' in that directory.
VERSION APPLIES TO: both stable (1.11) and feature (1.12) branches.
TEST CASE:
Sorry, my shell programming skills are extremely limited. Someone who
has the time and expertise should be able to convert this into a proper
addition for sanity.sh:
#assumptions: 'test-directory' exists in the repository
# as either a top-level directory or a CVS module,
# and it has no default watchers/watched.
cvs co test-directory
cd test-directory
mkdir subdir
cvs add subdir
cd subdir
#START watch add/remove sequence
cvs watch add
grep '_watchers' $CVSROOT/test-directory/subdir/CVS/fileattr
(the grep should succeed and currently does)
cvs watch on
grep '_watchers' $CVSROOT/test-directory/subdir/CVS/fileattr
(currently, this grep will fail - it should succeed)
grep '_watched' $CVSROOT/test-directory/subdir/CVS/fileattr
(this grep should succeed, and currently does)
cvs watch off
grep '_watchers' $CVSROOT/test-directory/subdir/CVS/fileattr
(currently, this grep will fail - it should succeed)
grep '_watched' $CVSROOT/test-directory/subdir/CVS/fileattr
(this grep should fail)
cvs watch remove
($CVSROOT/test-directory/subdir/CVS/fileattr should not exist)
($CVSROOT/test-directory/subdir/CVS should not exist)
#END watch add/remove sequence
echo Hi there>afile
cvs add afile
cvs ci -m "A file" afile
(repeat add/remove sequence, results should be the same)
(clean up)
PATCH:
The problem is, when onoff_fileproc and onoff_filesdoneproc call
fileattr_set the current attributes have not yet been read from the
current fileattr file. The patch simply forces the current fileattr
values to be read into memory before modifying the attribute.
Index: src/edit.c
===
RCS file: /cvs/ccvs/src/edit.c,v
retrieving revision 1.57.4.4
diff -u -r1.57.4.4 edit.c
--- src/edit.c 20 Mar 2004 22:25:49 - 1.57.4.4
+++ src/edit.c 12 Feb 2005 04:18:48 -
@@ -32,6 +32,7 @@
void *callerdat;
struct file_info *finfo;
{
+fileattr_get0 (finfo->file, "_watched");
fileattr_set (finfo->file, "_watched", turning_on ? "" : NULL);
return 0;
}
@@ -49,6 +50,7 @@
const char *update_dir;
List *entries;
{
+fileattr_get0 (NULL, "_watched");
if (setting_default)
fileattr_set (NULL, "_watched", turning_on ? "" : NULL);
return err;
NEWS entry:
* Thanks to a patch from Jim Hyslop <[EMAIL PROTECTED]>, issuing
'cvs watch on' or 'cvs watch off' in an empty directory no longer
clears any watchers in that directory.
--
Jim
___
Bug-cvs mailing list
Bug-cvs@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-cvs
FW: Changing passwords for CVS Users (pserver protocol)
Guess the dev mailing list is not really frequented, and also monitored? > -Original Message- > From: Guus Leeuw jr. [mailto:[EMAIL PROTECTED] > Sent: samedi 12 février 2005 11:48 > To: 'Jim.Hyslop'; '[EMAIL PROTECTED]' > Subject: RE: Changing passwords for CVS Users (pserver protocol) > > > -Original Message- > > From: [EMAIL PROTECTED] [mailto:info-cvs- > > [EMAIL PROTECTED] On Behalf Of Jim.Hyslop > > Sent: vendredi 11 février 2005 21:04 > > To: info-cvs@gnu.org > > Subject: RE: Changing passwords for CVS Users (pserver protocol) > > > > Guus Leeuw jr. wrote: > > > CVS pserver protocol does not allow for password change. > > > Maybe Mark wants to > > > add it in a feature release, and if so, I'd be happy to > > > provide the code for > > > it. > > I'd welcome such a feature. Please do send in a patch for it. > > Current way of thinking: > /* > * Ask a new password > * Confirm it > * Change administrative database passwd > * Change .cvspass through provided API in login.c > */ > > What do you think? > > Guus -- No virus found in this outgoing message. Checked by AVG Anti-Virus. Version: 7.0.300 / Virus Database: 265.8.7 - Release Date: 10/02/2005 -- No virus found in this outgoing message. Checked by AVG Anti-Virus. Version: 7.0.300 / Virus Database: 265.8.7 - Release Date: 10/02/2005 ___ Bug-cvs mailing list Bug-cvs@gnu.org http://lists.gnu.org/mailman/listinfo/bug-cvs
RE: Changing passwords for CVS Users (pserver protocol)
Guus Leeuw jr. wrote: > Guess the dev mailing list is not really frequented, and also > monitored? Does seem that way, doesn't it? Nobody's responded to my messages about the default watch attributes. I know many people monitor this list via gmane's NNTP interface - maybe there's a problem with gmane. Do you monitor this by email or by USENET? I'm subscribed to the mail list. -- Jim Hyslop Senior Software Designer Leitch Technology International Inc. ( http://www.leitch.com ) Columnist, C/C++ Users Journal ( http://www.cuj.com/experts ) ___ Bug-cvs mailing list Bug-cvs@gnu.org http://lists.gnu.org/mailman/listinfo/bug-cvs
Re: 'Dying gasps received from client.' with CVS 1.12.11
Hi Derek, I think I just checked in a fix for the zlib issue. For some reason, compress_buffer_input() was returning EOF to its caller as soon as it hit Z_STREAM_END, even though there was data waiting to be returned to the caller. It solves the issue with the sample client input Joerg sent some time ago. If you could both grab the CVS from CVS and let me know that I solved the problem correctly, I'll roll a 1.12.12 release soon. I just checked out CVS, compiled it and --version says: Concurrent Versions System (CVS) 1.12.11.1 (client/server) Copyright (C) 2005 Free Software Foundation, Inc. Senior active maintainers include Larry Jones, Derek R. Price, and Mark D. Baushke. Please see the AUTHORS and README files from the CVS distribution kit for a complete list of contributors and copyrights. CVS may be copied only under the terms of the GNU General Public License, a copy of which can be found with the CVS distribution kit. Specify the --help option for further information about CVS With this I imported two test modules using MacCVSClient, zlib data stream compression level 3. I use a MacCVSClient beta because the current 1.9 cannot cope with truncated paths in server responses. However, this beta uses the standard Mac OS X zlib as all previous versions did. So no change there. Both imports worked fine with 1.12.11.1. I double checked them against a 1.12.10 CVS where they both failed and caused MacCVSClient to wait and wait and wait... So, I'd say you nailed it! Good detective work. ;-) And sorry for the delay in testing this. Cheers, Joerg ___ Bug-cvs mailing list Bug-cvs@gnu.org http://lists.gnu.org/mailman/listinfo/bug-cvs
