Re: issue saving a game
El 23/10/20 a las 20:16, Antonio Ceballos escribió: > I could not reproduce the bug on Ubuntu 16.04, but I could on Debian 10.6. > > I have verified Simon's patch and I think it is fine and fixes the bug. > > Therefore, I have uploaded the change to the subversion repository in > Savannah. It will be included in the next release, 6.2.8, which may still > take a few weeks. > > Antonio > Hey! thanks a lot!! :) I was written an article for my blog when I found that bug. Happy to see that a fix is on the way! I will publish my article as soon as I get the fix in my openSUSE Tumbleweed system!! Thanks a lot for your support to free software! Happy hacking! -- --- GPG Key: 0xcc742e8dc9b7e22a Fingerprint = 6FE2 3B1F AAC8 E5B7 63EA 88A9 CC74 2E8D C9B7 E22A Aprende a proteger la privacidad de tu correo: https://emailselfdefense.fsf.org/es/ Mi blog sobre openSUSE, GNU/Linux y software libre: https://victorhckinthefreeworld.com/ Herramientas para proteger tu privacidad https://victorhck.gitlab.io/privacytools-es/ OpenPGP_0xCC742E8DC9B7E22A.asc Description: application/pgp-keys OpenPGP_signature Description: OpenPGP digital signature
Re: issue saving a game
I could not reproduce the bug on Ubuntu 16.04, but I could on Debian 10.6. I have verified Simon's patch and I think it is fine and fixes the bug. Therefore, I have uploaded the change to the subversion repository in Savannah. It will be included in the next release, 6.2.8, which may still take a few weeks. Antonio On Sat, Oct 10, 2020 at 10:12 AM wrote: > This seems to be FORTIFY_SOURCE compiler flag. Debian sets level 2, but > just level 1 triggers it. > > The code uses sprintf to concatenate strings which is "undefined" > behaviour, the offending code is flagged by enabling all compiler warnings > when building pgn.cc > > This explains why it wasn't caught in development. I've sent patch to > Antonio which fixes it, but he should probably be skeptical as I've not > done C/C++ for years, and haven't fixed related warning elsewhere. If we > are using C++ we should probably consider using C++ output features, and > definitely enabling all warnings and including FORTIFY_SOURCE level 2 as > this is how the distros roll. >
