Re: an archive of POSIX compat files ?

2005-06-28 Thread Stepan Kasal
Hello,

On Tue, Jun 28, 2005 at 09:12:32AM -0400, Karl Berry wrote:
> The English seems fine to me, but since Gnulib has a Texinfo manual, it
> seems like it might make sense to use a multi-argument xref instead of
> @uref (with rewording), as in:
>   @xref{Top,,,gnulib,Gnulib}, 

OTOH, is seems more useful to point developers to the web page than to
the info manual, which is not installed on most distributions.
Thus I think there should be both references.

What about the following variation of Keith's patch?

Stepan
Index: doc/autoconf.texi
===
RCS file: /cvsroot/autoconf/autoconf/doc/autoconf.texi,v
retrieving revision 1.919
diff -u -r1.919 autoconf.texi
--- doc/autoconf.texi   28 Jun 2005 13:08:29 -  1.919
+++ doc/autoconf.texi   29 Jun 2005 05:18:55 -
@@ -4564,6 +4564,14 @@
 environment.  Some functions may be missing or unfixable, and your
 package must be ready to replace them.
 
+Suitable replacements for many such problem functions are available
+from @uref{http://www.gnu.org/software/gnulib/, Gnulib}, which aims
+to provide a centralized repository of such portability functions.
[EMAIL PROTECTED],,,gnulib,Gnulib}.
+The source files themselves are available online,
+under various licences, mostly GNU GPL or GNU LGPL, at
[EMAIL PROTECTED]://savannah.gnu.org/cgi-bin/viewcvs/gnulib/gnulib/lib/}.
+
 @defmac AC_LIBOBJ (@var{function})
 @acindex{LIBOBJ}
 @ovindex LIBOBJS
___
bug-gnulib mailing list
bug-gnulib@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnulib


Re: check_version

2005-06-28 Thread Simon Josefsson
Derek Price <[EMAIL PROTECTED]> writes:

> Simon Josefsson wrote:
>
>>+  if (!req_version || strverscmp (req_version, VERSION) < 0)
>>+return VERSION;
>>  
>>
>
> Why did you choose to call the version string "VERSION" rather than
> using the "PACKAGE_VERSION" string automatically defined by AC_INIT?

No particular reason.  VERSION is defined automatically by AC_INIT
too, is it not?  Is there a difference between PACKAGE_VERSION and
VERSION?  I'd be happy to change, it doesn't matter for me.


___
bug-gnulib mailing list
bug-gnulib@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnulib


Re: check_version

2005-06-28 Thread Derek Price
Simon Josefsson wrote:

>No particular reason.  VERSION is defined automatically by AC_INIT
>too, is it not?  Is there a difference between PACKAGE_VERSION and
>VERSION?  I'd be happy to change, it doesn't matter for me.
>  
>

The CVS config.h is only showing `PACKAGE_VERSION'.

Regards,

Derek



___
bug-gnulib mailing list
bug-gnulib@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnulib


Re: check_version

2005-06-28 Thread Derek Price
Simon Josefsson wrote:

>Ok, unless someone suggests otherwise, I'll change it to
>PACKAGE_VERSION later tonight.  Perhaps it is Automake that define
>VERSION.
>  
>

The CVS project uses Automake 1.9.5 and Autoconf 2.59 and VERSION does
not get defined.  We might not be using a macro that defines VERSION,
but it isn't AC_INIT with four arguments that does it, via either
Autoconf or Automake.

Regards,

Derek



___
bug-gnulib mailing list
bug-gnulib@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnulib


Re: check_version

2005-06-28 Thread Simon Josefsson
Derek Price <[EMAIL PROTECTED]> writes:

> Simon Josefsson wrote:
>
>>No particular reason.  VERSION is defined automatically by AC_INIT
>>too, is it not?  Is there a difference between PACKAGE_VERSION and
>>VERSION?  I'd be happy to change, it doesn't matter for me.
>>  
>>
>
> The CVS config.h is only showing `PACKAGE_VERSION'.

Ok, unless someone suggests otherwise, I'll change it to
PACKAGE_VERSION later tonight.  Perhaps it is Automake that define
VERSION.

Thanks,
Simon


___
bug-gnulib mailing list
bug-gnulib@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnulib


Re: an archive of POSIX compat files ?

2005-06-28 Thread Karl Berry
+In case you want to use already existing files, you can have a look at
[EMAIL PROTECTED]://www.gnu.org/software/gnulib/, Gnulib}, a centralized

The English seems fine to me, but since Gnulib has a Texinfo manual, it
seems like it might make sense to use a multi-argument xref instead of
@uref (with rewording), as in:
  @xref{Top,,,gnulib,Gnulib}, 

(I know the references in the coding standards use @uref now; I only
realized this a few days ago.)


___
bug-gnulib mailing list
bug-gnulib@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnulib


Re: check_version

2005-06-28 Thread Derek Price
Simon Josefsson wrote:

>+  if (!req_version || strverscmp (req_version, VERSION) < 0)
>+return VERSION;
>  
>

Why did you choose to call the version string "VERSION" rather than
using the "PACKAGE_VERSION" string automatically defined by AC_INIT?

Regards,

Derek



___
bug-gnulib mailing list
bug-gnulib@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnulib


canonicalize depends on pathmax.h

2005-06-28 Thread Jim Meyering
FYI, I ran this command

  (cd modules; ../check-module *)

and saw some new warnings:

  lib/canonicalize.c: pathmax.h is `#include'd, but not listed in module's 
Files: section
  lib/fts.c: fts-cycle.c is `#include'd, but not listed in module's Files: 
section
  lib/fts.c: unistd-safer.h is `#include'd, but not listed in module's Files: 
section

I've done this to fix them:

2005-06-28  Jim Meyering  <[EMAIL PROTECTED]>

* check-module (find_included_lib_files): Hard-code another
pair of exceptions: fts.c includes fts-cycle.c and unistd-safer.h
but the fts-lgpl module file (correctly) does not list those files.

* modules/canonicalize (Files): Add lib/pathmax.h.

Index: check-module
===
RCS file: /cvsroot/gnulib/gnulib/check-module,v
retrieving revision 1.1
diff -u -p -r1.1 check-module
--- check-module26 Mar 2005 16:07:23 -  1.1
+++ check-module28 Jun 2005 11:23:37 -
@@ -151,6 +151,9 @@ sub find_included_lib_files ($)
and next;
   $file =~ /\bhash\.c$/ && $line eq 'obstack.h'
and next;
+  $file =~ /\bfts\.c$/ &&
+   ($line eq 'fts-cycle.c' || $line eq 'unistd-safer.h')
+ and next;
 
   $inc{$line} = 1;
 }


___
bug-gnulib mailing list
bug-gnulib@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnulib


Re: an archive of POSIX compat files ?

2005-06-28 Thread Stepan Kasal
Hello,

On Mon, Jun 27, 2005 at 02:08:07PM +0200, Stepan Kasal wrote:
> On Thu, Jun 23, 2005 at 10:20:33PM +0200, Patrice Dumas wrote:
> > > gnulib is an existing centralised repository, with implementations
> > > under various licenses, but mostly they are GPL or LGPL.
> > 
> > Maybe there could be a note about that in the autoconf manual ?
> 
> standards.texi, which is distributed with Autoconf, mentiones it.
> 
> But perhaps there could be a direct link from Autoconf manual; could you
> propose some wording?

I have received a proposal from Patrice.  A slightly modified version is
attached below.  Could any of the native speakers look at it?

Stepan

Index: doc/autoconf.texi
===
RCS file: /cvsroot/autoconf/autoconf/doc/autoconf.texi,v
retrieving revision 1.918
diff -u -r1.918 autoconf.texi
--- doc/autoconf.texi   24 Jun 2005 00:54:01 -  1.918
+++ doc/autoconf.texi   28 Jun 2005 10:17:55 -
@@ -4564,6 +4564,13 @@
 environment.  Some functions may be missing or unfixable, and your
 package must be ready to replace them.
 
+In case you want to use already existing files, you can have a look at
[EMAIL PROTECTED]://www.gnu.org/software/gnulib/, Gnulib}, a centralized
+repository with such portability files.
+The source files are available online
+at @uref{http://savannah.gnu.org/cgi-bin/viewcvs/gnulib/gnulib/lib/}
+under various licences, mostly GNU GPL or GNU LGPL.
+
 @defmac AC_LIBOBJ (@var{function})
 @acindex{LIBOBJ}
 @ovindex LIBOBJS


___
bug-gnulib mailing list
bug-gnulib@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnulib


Re: check_version

2005-06-28 Thread Simon Josefsson
Jim Meyering <[EMAIL PROTECTED]> writes:

> Simon Josefsson <[EMAIL PROTECTED]> wrote:
>> Ah, right.  I accidentally installed the m4 file.  Ok to install the
>> rest too?
>
> Sure.  It looks fine to me.

Done.


___
bug-gnulib mailing list
bug-gnulib@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnulib


Re: check_version

2005-06-28 Thread Simon Josefsson
Jim Meyering <[EMAIL PROTECTED]> writes:

> Simon Josefsson <[EMAIL PROTECTED]> wrote:
>> Paul Eggert <[EMAIL PROTECTED]> writes:
>>
>>> Simon Josefsson <[EMAIL PROTECTED]> writes:
>>>
/* Check version of libgcrypt. */
if (!gcry_check_version (GCRYPT_VERSION))
  die ("version mismatch\n");
>>>
>>> Can't you use strverscmp for this?  E.g.:
>>>
>>> if (strverscmp (GCRYPT_VERSION, VERSION) < 0)
>>>   die ("version mismatch\n");
>>>
>>> Even if strverscmp itself can't be used directly, it seems to me that
>>> its use would greatly simplify this package, and avoid the
>>> integer-overflow glitches Jim mentioned.
>>
>> Good idea!  How about this?
>>
>> 2005-06-25  Simon Josefsson  <[EMAIL PROTECTED]>
>>
>>  * modules/check_version: New file.
>>
>> 2005-06-25  Simon Josefsson  <[EMAIL PROTECTED]>
>>
>>  * check_version.h, check_version.c: New file.
>
> I just noticed that you used an underscore in the middle of a
> file name rather than a hyphen.  Long-standing GNU tradition is
> to use hyphens there.  I think one of the reasons is that hyphens
> are slightly easier to type.

Right, changed.

>> +Makefile.am:
>> +lib_SOURCES += check_version.h check_version.c
>
> Also, in coreutils and gnulib, we've been moving away from
> using the `Makefile.am' section of the modules files, for reasons
> discussed at length a few months ago.  And I'm pretty sure I saw
> some automake changes that will help Bruno do things the way he
> wants in gettext.
>
> So, you might want to remove that line and instead add a file
> named m4/check-version.m4 like this:

Ah, right.  I accidentally installed the m4 file.  Ok to install the
rest too?

Thanks.


___
bug-gnulib mailing list
bug-gnulib@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnulib


Re: check_version

2005-06-28 Thread Jim Meyering
Simon Josefsson <[EMAIL PROTECTED]> wrote:
> Ah, right.  I accidentally installed the m4 file.  Ok to install the
> rest too?

Sure.  It looks fine to me.
Thanks.


___
bug-gnulib mailing list
bug-gnulib@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnulib


Re: check_version

2005-06-28 Thread Jim Meyering
Simon Josefsson <[EMAIL PROTECTED]> wrote:
> Paul Eggert <[EMAIL PROTECTED]> writes:
>
>> Simon Josefsson <[EMAIL PROTECTED]> writes:
>>
>>>/* Check version of libgcrypt. */
>>>if (!gcry_check_version (GCRYPT_VERSION))
>>>  die ("version mismatch\n");
>>
>> Can't you use strverscmp for this?  E.g.:
>>
>> if (strverscmp (GCRYPT_VERSION, VERSION) < 0)
>>   die ("version mismatch\n");
>>
>> Even if strverscmp itself can't be used directly, it seems to me that
>> its use would greatly simplify this package, and avoid the
>> integer-overflow glitches Jim mentioned.
>
> Good idea!  How about this?
>
> 2005-06-25  Simon Josefsson  <[EMAIL PROTECTED]>
>
>   * modules/check_version: New file.
>
> 2005-06-25  Simon Josefsson  <[EMAIL PROTECTED]>
>
>   * check_version.h, check_version.c: New file.

I just noticed that you used an underscore in the middle of a
file name rather than a hyphen.  Long-standing GNU tradition is
to use hyphens there.  I think one of the reasons is that hyphens
are slightly easier to type.

> +Makefile.am:
> +lib_SOURCES += check_version.h check_version.c

Also, in coreutils and gnulib, we've been moving away from
using the `Makefile.am' section of the modules files, for reasons
discussed at length a few months ago.  And I'm pretty sure I saw
some automake changes that will help Bruno do things the way he
wants in gettext.

So, you might want to remove that line and instead add a file
named m4/check-version.m4 like this:

#serial 1
dnl Copyright (C) 2005 Free Software Foundation, Inc.
dnl This file is free software; the Free Software Foundation
dnl gives unlimited permission to copy and/or distribute it,
dnl with or without modifications, as long as this notice is preserved.

AC_DEFUN([gl_CHECK_VERSION],
[
  AC_LIBSOURCES([check-version.c, check-version.h])
  AC_LIBOBJ([check-version])
])


___
bug-gnulib mailing list
bug-gnulib@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnulib