Adapting changes for MSYS2?
Hi. A gawk user recently called my attention to: https://github.com/msys2/MSYS2-packages/tree/master/gawk > The patch file there is named gawk-4.2.1-msysize.patch. The patches mainly > seem to add an "msys*" option in several build scripts just after the > "cygwin*" system identity alternatives. I have adapted the patches for gawk's test/Makefile.am and will be pushing shortly. Can we get the changes for compile, config.guess, config.rpath, and ar-lib integrated directly into GNULIB, so that I can then pull them from upstream? They may be small enough that you don't need paperwork. I'm cc-ing Alexey Pawlow, the author of the changes. Thanks! Arnold
Re: Adapting changes for MSYS2?
On 11/9/19 10:40 AM, arn...@skeeve.com wrote: A gawk user recently called my attention to: https://github.com/msys2/MSYS2-packages/tree/master/gawk The patch file there is named gawk-4.2.1-msysize.patch. The patches mainly seem to add an "msys*" option in several build scripts just after the "cygwin*" system identity alternatives. I have adapted the patches for gawk's test/Makefile.am and will be pushing shortly. Can we get the changes for compile, config.guess, config.rpath, and ar-lib integrated directly into GNULIB, so that I can then pull them from upstream? I installed most of those changes to Gnulib. The exception is the proposed change to config.guess, which is upstream from Gnulib and is part of GNU config, so I'll CC: this message to config-patc...@gnu.org. As far as I can see, the proposed config.guess change has no effect, as the existing config.guess treats MSYS the same on all architectures in an earlier branch of that big 'case' statement. config.guess has done so since this commit in 2014, which specifically caused config.guess to treat MSYS the same on all machines, not just i* machines: https://git.savannah.gnu.org/cgit/config.git/commit/?id=f4ebd3ed097771a729b68e688236aea665e7c1f3 so I'm puzzled as to why the config.guess change would be needed even if it were effective.
Re: [patch] glob. If pattern has a trailing slash match directories only
Hi Dmitry, > The original version of this patch was discussed here > https://sourceware.org/ml/libc-alpha/2017-11/msg00983.html. When I read this mail thread, the status was that not all issues raised by Paul were resolved, in particular the performance regression. Are these issues supposed to be fixed in the new patch? Remarks about the tests (I appreciate that you add tests!): - Please follow GNU coding style, esp. regarding space between a function name and its arguments: int rc = symlink (old, new); - Similarly, add spaces around operators: GLOB_MARK | GLOB_ONLYDIR - The functions touch, md, ln, ln_s all return 0; better change the return type to 'void'. - Why is 'verbose' an 'int'? Couldn't it be a 'bool'? Bruno
