Re: More systematic naming of LIB variables

2023-01-06 Thread Bruno Haible 
Paul Eggert wrote:
> Thanks for cleaning up the naming. I think only coreutils and tar used 
> the confusingly-named old $(LIB_HAS_ACL) macro.

According to Debian codesearch
https://codesearch.debian.net/search?q=LIB_HAS_ACL&literal=1&perpkg=1
also 'recutils' and 'rrep' use acl.m4. But they don't use LIB_HAS_ACL
in their build system committed into git (I checked this); so we're good.

> I now updated updated 
> them, so we can remove the old name from Gnulib, which I did by 
> installing the attached.

Thanks. I expected the packages to be updated within a year, not within
a week :-)

Bruno

Re: More systematic naming of LIB variables

2023-01-06 Thread Paul Eggert 
Thanks for cleaning up the naming. I think only coreutils and tar used 
the confusingly-named old $(LIB_HAS_ACL) macro. I now updated updated 
them, so we can remove the old name from Gnulib, which I did by 
installing the attached.
From c551997131a8f1f8f648d39c2d7d5e8db026a139 Mon Sep 17 00:00:00 2001
From: Paul Eggert 
Date: Fri, 6 Jan 2023 17:25:02 -0800
Subject: [PATCH] =?UTF-8?q?file-has-acl:=20don=E2=80=99t=20bother=20settin?=
 =?UTF-8?q?g=20LIB=5FHAS=5FACL?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* m4/acl.m4 (gl_FUNC_ACL, gl_FILE_HAS_ACL): Don’t set LIB_HAS_ACL.
I think only Coreutils and Tar used it, and I’ve updated them.
---
 ChangeLog | 4 
 NEWS  | 2 ++
 m4/acl.m4 | 6 +-
 3 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index b85b8ec5bb..f531198fbb 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,9 @@
 2023-01-06  Paul Eggert  
 
+	file-has-acl: don’t bother setting LIB_HAS_ACL
+	* m4/acl.m4 (gl_FUNC_ACL, gl_FILE_HAS_ACL): Don’t set LIB_HAS_ACL.
+	I think only Coreutils and Tar used it, and I’ve updated them.
+
 	bootstrap: suppress stray message from --pull
 	* build-aux/bootstrap: Regenerate.
 	* top/bootstrap-funclib.sh (autopull): Suggest running autogen.sh
diff --git a/NEWS b/NEWS
index 16eac4c7df..65dcce7590 100644
--- a/NEWS
+++ b/NEWS
@@ -74,6 +74,8 @@ User visible incompatible changes
 
 DateModules Changes
 
+2023-01-06  file-has-aclLink with $(FILE_HAS_ACL_LIB), not $(LIB_HAS_ACL).
+
 2022-12-25  largefile   configure no longer enables year-2038 support,
 unless you configure with --enable-year2038
 or use the year2038 module.  This temporary
diff --git a/m4/acl.m4 b/m4/acl.m4
index 6c2db7d320..e612f1ae34 100644
--- a/m4/acl.m4
+++ b/m4/acl.m4
@@ -1,5 +1,5 @@
 # acl.m4 - check for access control list (ACL) primitives
-# serial 25
+# serial 26
 
 # Copyright (C) 2002, 2004-2023 Free Software Foundation, Inc.
 # This file is free software; the Free Software Foundation
@@ -141,7 +141,6 @@ int type = ACL_TYPE_EXTENDED;]])],
   fi
   if test -n "$gl_need_lib_has_acl"; then
 FILE_HAS_ACL_LIB=$LIB_ACL
-LIB_HAS_ACL="$FILE_HAS_ACL_LIB"
   fi
   AC_SUBST([LIB_ACL])
   AC_DEFINE_UNQUOTED([USE_ACL], [$use_acl],
@@ -211,7 +210,4 @@ AC_DEFUN([gl_FILE_HAS_ACL],
 FILE_HAS_ACL_LIB=$LIB_ACL
   fi
   AC_SUBST([FILE_HAS_ACL_LIB])
-  dnl For backward compatibility (e.g. coreutils still uses LIB_HAS_ACL).
-  LIB_HAS_ACL="$FILE_HAS_ACL_LIB"
-  AC_SUBST([LIB_HAS_ACL])
 ])
-- 
2.37.2

[PATCH] bootstrap: suppress stray message from --pull

2023-01-06 Thread Paul Eggert 
* build-aux/bootstrap: Regenerate.
* top/bootstrap-funclib.sh (autopull): Suggest running autogen.sh
only if it exists (i.e., the package is using autopull.sh/autogen.sh).
Suggest the same name for autogen.sh that is used in the test.
---
 ChangeLog| 8 
 build-aux/bootstrap  | 8 +---
 top/bootstrap-funclib.sh | 6 --
 3 files changed, 17 insertions(+), 5 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index ba2ebc3c3e..b85b8ec5bb 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2023-01-06  Paul Eggert  
+
+   bootstrap: suppress stray message from --pull
+   * build-aux/bootstrap: Regenerate.
+   * top/bootstrap-funclib.sh (autopull): Suggest running autogen.sh
+   only if it exists (i.e., the package is using autopull.sh/autogen.sh).
+   Suggest the same name for autogen.sh that is used in the test.
+
 2023-01-05  Bruno Haible  
 
string: Fix compilation errors in C++ mode on Android.
diff --git a/build-aux/bootstrap b/build-aux/bootstrap
index 6d1d22c675..c6c4901d3f 100755
--- a/build-aux/bootstrap
+++ b/build-aux/bootstrap
@@ -37,9 +37,9 @@ medir=`dirname "$me"`
 
 # A library of shell functions for autopull.sh, autogen.sh, and bootstrap.
 
-scriptlibversion=2022-12-27.16; # UTC
+scriptlibversion=2023-01-06.19; # UTC
 
-# Copyright (C) 2003-2022 Free Software Foundation, Inc.
+# Copyright (C) 2003-2023 Free Software Foundation, Inc.
 #
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -815,7 +815,9 @@ autopull()
 fi
   fi
 
-  echo "$0: done.  Now you can run './autogen.sh'."
+  if test -f "$medir"/autogen.sh; then
+echo "$0: done.  Now you can run '$medir/autogen.sh'."
+  fi
 }
 
 # - Get translations. -
diff --git a/top/bootstrap-funclib.sh b/top/bootstrap-funclib.sh
index 9e47e0d861..fca6a0392e 100644
--- a/top/bootstrap-funclib.sh
+++ b/top/bootstrap-funclib.sh
@@ -1,6 +1,6 @@
 # A library of shell functions for autopull.sh, autogen.sh, and bootstrap.
 
-scriptlibversion=2022-12-27.16; # UTC
+scriptlibversion=2023-01-06.19; # UTC
 
 # Copyright (C) 2003-2023 Free Software Foundation, Inc.
 #
@@ -778,7 +778,9 @@ autopull()
 fi
   fi
 
-  echo "$0: done.  Now you can run './autogen.sh'."
+  if test -f "$medir"/autogen.sh; then
+echo "$0: done.  Now you can run '$medir/autogen.sh'."
+  fi
 }
 
 # - Get translations. -
-- 
2.38.1

Re: Clang-built Gawk 5.2.1 regex oddity

2023-01-06 Thread arnold 
Thanks for the update.

Paul, let's leave dfa.c as is, with the modified code.
It's much easier to read anyway.

Thanks,

Arnold

Arsen Arsenović  wrote:

> Hi,
>
> Paul Eggert  writes:
>
> > This is a serious bug in Clang: it generates incorrect machine code.
> >
> > The code that Clang generates for the following (gawk/support/dfa.c lines
> > 1141-1143):
> >
> > ((dfa->syntax.dfaopts & DFA_CONFUSING_BRACKETS_ERROR
> >   ? dfaerror : dfawarn)
> >  (_("character class syntax is [[:space:]], not [:space:]")));
> >
> > is immediately followed by the code generated for the following
> > (gawk/support/dfa.c line 1015):
> >
> > dfaerror (_("invalid character class"));
> >
> > and this is incorrect because the two source code regions are not connected
> > with each other.
>
> This is now fixed in Clang:
> https://reviews.llvm.org/rGcf8fd210a35c8e93136cb8edc5c6a2e818dc1b1d
>
> Happy hacking!
> -- 
> Arsen Arsenović