Re: [bug-gnulib] problems in stdbool.m4
Hello, On Wed, Oct 12, 2005 at 08:23:29PM +0200, Bruno Haible wrote: > Stepan Kasal wrote: > > I noticed two problems with stdbool.m4: > > > > Even with Autoconf-2.59, this file is included in aclocal.m4, > > and thus the gnulib definition overrides the Autoconf one. > > This is what we want. Look at the comment: > -- > # This macro is only needed in autoconf <= 2.59. Newer versions of autoconf > # have this macro built-in. > > AC_DEFUN([AC_HEADER_STDBOOL], but 2.59 has it's own version of AC_HEADER_STDBOOL, though slightly different from Autoconf-CVS. And the gnulib copy is different from what Autoconf-2.59 has. > > m4_ifndef([AC_HEADER_STDBOOL], > > AC_DEFUN([AC_HEADER_STDBOOL], > Nope, this would be a regression. Oh, I understand now. But I don't think gnulib should redefine documented Autoconf macros. What about renaming it to gl_HEADER_STDBOOL ? Have a nice day, Stepan ___ bug-gnulib mailing list bug-gnulib@gnu.org http://lists.gnu.org/mailman/listinfo/bug-gnulib
Re: [bug-gnulib] problems in stdbool.m4
Bruno Haible <[EMAIL PROTECTED]> writes: > Paul Eggert wrote: >> > 1) now, the appended patch, >> > 2) in a year, change modules/stdbool to require gl_STDBOOL_H, >> >> Sounds good, except why wait for a year between (1) and (2)? >> I don't see the downside of doing (2) now. > > People who update from gnulib in a manual, not always synchronized way, > could be burned. The less trouble a renaming makes, the better. Sorry, I'm still lost. If we do (2) now, people will still have two years to change their code, no? What is the practical difference between the schedule you originally proposed, and a schedule that consists of doing (1) and (2) now, but (3) two years from now? ___ bug-gnulib mailing list bug-gnulib@gnu.org http://lists.gnu.org/mailman/listinfo/bug-gnulib
Re: [bug-gnulib] problems in stdbool.m4
Paul Eggert wrote: > > 1) now, the appended patch, > > 2) in a year, change modules/stdbool to require gl_STDBOOL_H, > > Sounds good, except why wait for a year between (1) and (2)? > I don't see the downside of doing (2) now. People who update from gnulib in a manual, not always synchronized way, could be burned. The less trouble a renaming makes, the better. Bruno ___ bug-gnulib mailing list bug-gnulib@gnu.org http://lists.gnu.org/mailman/listinfo/bug-gnulib
Re: [bug-gnulib] problems in stdbool.m4
Bruno Haible <[EMAIL PROTECTED]> writes: > To provide for a smooth transition from AM_STDBOOL_H to gl_STDBOOL_H, > I propose a three-step procedure: > 1) now, the appended patch, > 2) in a year, change modules/stdbool to require gl_STDBOOL_H, > 3) in two years, drop AM_STDBOOL_H. Sounds good, except why wait for a year between (1) and (2)? I don't see the downside of doing (2) now. ___ bug-gnulib mailing list bug-gnulib@gnu.org http://lists.gnu.org/mailman/listinfo/bug-gnulib
Re: [bug-gnulib] problems in stdbool.m4
Stepan Kasal wrote: > I noticed two problems with stdbool.m4: > > Even with Autoconf-2.59, this file is included in aclocal.m4, > and thus the gnulib definition overrides the Autoconf one. This is what we want. Look at the comment: -- # This macro is only needed in autoconf <= 2.59. Newer versions of autoconf # have this macro built-in. AC_DEFUN([AC_HEADER_STDBOOL], ... -- The ChangeLog entry that corresponds to this change is: 2004-05-31 Paul Eggert <[EMAIL PROTECTED]> * stdbool.m4 (AC_HEADER_STDBOOL): Detect _Bool bug in HP aC++/ANSI C B3910B A.05.55 [Dec 04 2003]. Problem reported by Jim Meyering. Also, fix a typo in a diagnostic. > Perhaps the following would fix it: > > m4_ifndef([AC_HEADER_STDBOOL], > AC_DEFUN([AC_HEADER_STDBOOL], > [... > ]) > ]) Nope, this would be a regression. > Second, AM_STDBOOL_H is misnamed. Wouldn't gl_STDBOOL_H be better? To provide for a smooth transition from AM_STDBOOL_H to gl_STDBOOL_H, I propose a three-step procedure: 1) now, the appended patch, 2) in a year, change modules/stdbool to require gl_STDBOOL_H, 3) in two years, drop AM_STDBOOL_H. Bruno *** stdbool.m4 6 Oct 2005 16:44:39 - 1.6 --- stdbool.m4 12 Oct 2005 18:26:28 - *** *** 28,33 --- 28,36 AC_SUBST([HAVE__BOOL]) ]) + # AM_STDBOOL_H will be renamed to gl_STDBOOL_H in the future. + AC_DEFUN([gl_STDBOOL_H], [AM_STDBOOL_H]) + # This macro is only needed in autoconf <= 2.59. Newer versions of autoconf # have this macro built-in. ___ bug-gnulib mailing list bug-gnulib@gnu.org http://lists.gnu.org/mailman/listinfo/bug-gnulib
