Re: [PATCH] argmatch: add variants that only match full argument

2022-01-30 Thread Pádraig Brady 

On 30/01/2022 18:58, Bruno Haible wrote:

Pádraig Brady wrote:

* lib/argmatch.h (argmatch_exact, [X]ARGMATCH_EXACT): New interfaces
that don't support abbreviations.
* lib/argmatch.c (argmatch_exact, __xargmatch_exact_internal): Likewise.
* tests/test-argmatch.c: Add tests.


The code looks correct. But I see some code duplication:
__xargmatch_exact_internal and __xargmatch_internal are very similar.
Given that both of these functions are only invoked through macros, how
about merging them into a single function? Namely, by adding an argument
of type 'bool exactp'.

Bruno


Good call.
I pushed with that adjustment.

Thanks for the review.
Pádraig

Re: [PATCH] argmatch: add variants that only match full argument

2022-01-30 Thread Bruno Haible 
Pádraig Brady wrote:
> * lib/argmatch.h (argmatch_exact, [X]ARGMATCH_EXACT): New interfaces
> that don't support abbreviations.
> * lib/argmatch.c (argmatch_exact, __xargmatch_exact_internal): Likewise.
> * tests/test-argmatch.c: Add tests.

The code looks correct. But I see some code duplication:
__xargmatch_exact_internal and __xargmatch_internal are very similar.
Given that both of these functions are only invoked through macros, how
about merging them into a single function? Namely, by adding an argument
of type 'bool exactp'.

Bruno