[Bug-gnupod] Configure as_echo fix
Configure has always printed -n strings on my MacBook. I fixed that by using as_echo and as_echo_n. See my patch on the rvdb/configure-fix branch. Cheers, Richard ___ Bug-gnupod mailing list Bug-gnupod@nongnu.org http://lists.nongnu.org/mailman/listinfo/bug-gnupod
[Bug-gnupod] Text::CharWidth
There is no test for Text::CharWidth in configure required by gnupod-delete. I'm not sure if it should be a required or an optional module. Cheers, Richard ___ Bug-gnupod mailing list Bug-gnupod@nongnu.org http://lists.nongnu.org/mailman/listinfo/bug-gnupod
Re: [Bug-gnupod] Configure as_echo fix
On Fri, Jul 03, 2009 at 08:37:20PM +0200, Richard van den Berg wrote: Configure has always printed -n strings on my MacBook. I fixed that by using as_echo and as_echo_n. See my patch on the rvdb/configure-fix branch. Looks good so far. I'll merge it. It's probably a shell oddity of the echo builtin. Which mac os version did you use? The default Mac OS X sh was originally Zsh; it was changed to Bash in Mac OS X 10.2. Do you happen to know if AC_MSG_CHECKING, AC_MSG_RESULT, and AC_MSG_NOTICE are posix ? cheers -henrik ___ Bug-gnupod mailing list Bug-gnupod@nongnu.org http://lists.nongnu.org/mailman/listinfo/bug-gnupod
Re: [Bug-gnupod] Configure as_echo fix
On 7/3/09 9:59 PM, H. Langos wrote: Which mac os version did you use? OS X 10.5.7 The default Mac OS X sh was originally Zsh; it was changed to Bash in Mac OS X 10.2. I definitely use bash. If it wasn't the default, I would have changed it. :-) Do you happen to know if AC_MSG_CHECKING, AC_MSG_RESULT, and AC_MSG_NOTICE are posix ? I'm not sure what you mean by them being posix, but they should be platform independent. Cheers, Richard ___ Bug-gnupod mailing list Bug-gnupod@nongnu.org http://lists.nongnu.org/mailman/listinfo/bug-gnupod
Re: [Bug-gnupod] mktunes.pl creates corrupt iTunesDB ?
On 7/2/09 3:43 PM, H. Langos wrote: Could you check if it still does what it was is supposed to do? :-) It looks fine, and my iPod still works, and didn't even have to reboot it for it to show my 30640 files. :-) I merged the low_ram branch into master yesterday evening but I wanted to sleep over it before commiting. Here are the changes that actually happend to master: git diff 94462eb 25a4d8b That diff looks good to me. It may be better to avoid merges among branches. Yeah, sorry about that. I won't be doing that again (and I'll be less eager to push commits I did). Cheers, Richard ___ Bug-gnupod mailing list Bug-gnupod@nongnu.org http://lists.nongnu.org/mailman/listinfo/bug-gnupod
Re: [Bug-gnupod] Text::CharWidth
Hi Richard, On Fri, Jul 03, 2009 at 09:16:41PM +0200, Richard van den Berg wrote: There is no test for Text::CharWidth in configure required by gnupod-delete. I'm not sure if it should be a required or an optional module. Actually it is FindHelper's prettyprint function and the same problem will arise in gnupof_find. I could workaround it more or less by disabling that code path if Text::CharWidth is not installed but it would cause the output to be wrongly formated (as by gnupod_search when printing non-ascii utf8 characters). It would be easier to simply require Text::CharWidth but I guess there's enough ppl who will never have an accented character in their mp3 collection. If you want to fix it yourself take a look at the code that handles Date::Manip in FindHelper. cheers -henrik ___ Bug-gnupod mailing list Bug-gnupod@nongnu.org http://lists.nongnu.org/mailman/listinfo/bug-gnupod
Re: [Bug-gnupod] Configure as_echo fix
On Fri, Jul 03, 2009 at 10:06:58PM +0200, Richard van den Berg wrote: On 7/3/09 9:59 PM, H. Langos wrote: Which mac os version did you use? OS X 10.5.7 The default Mac OS X sh was originally Zsh; it was changed to Bash in Mac OS X 10.2. I definitely use bash. If it wasn't the default, I would have changed it. :-) I use bash most of the time too. But I try not to rely on bashisms. Do you happen to know if AC_MSG_CHECKING, AC_MSG_RESULT, and AC_MSG_NOTICE are posix ? I'm not sure what you mean by them being posix, but they should be platform independent. I wanted to know if they are specific to gnu autoconf or if they are defined in the POSIX standard. But it seems that autoconf itself is not covered by the posix standard. Instead autoconf is defined by it's implementation (and its version specific bugs ;) Soo... if you feel like changing it to those macros, go for it. But I would probably not waste too much time on it. Where did you find the hint to replace echo $ECHO_N by $as_echo_n? cheers -henrik ___ Bug-gnupod mailing list Bug-gnupod@nongnu.org http://lists.nongnu.org/mailman/listinfo/bug-gnupod
Re: [Bug-gnupod] Configure as_echo fix
On 7/3/09 10:55 PM, H. Langos wrote: But it seems that autoconf itself is not covered by the posix standard. I assumed you already knew that. :-) Where did you find the hint to replace echo $ECHO_N by $as_echo_n? From the generated configure script. I wouldn't be surprised if the AC_MSG_* macro's use $as_echo internally. Using the macro's is probably more future proof. I'll take another swing at it when I have more time. Cheers, Richard ___ Bug-gnupod mailing list Bug-gnupod@nongnu.org http://lists.nongnu.org/mailman/listinfo/bug-gnupod
