Re: [Bug-gnupod] artwork support apparently (but not really) broken on ubuntu
Hi Chris, On Thu, Jul 02, 2009 at 07:03:21AM +0200, chris.com wrote: Hello Henrik, The behaviour is not intended as you so nicely put it. It is/was a bug and has been corrected in the 6.4.9-9 version. From the ChangeLog: 2009-03-01 6.4.9-9 Cristy quetzlzacatena...@image... * Convert returns MagickFalse for the -version option (reference http://www.imagemagick.org/discourse-server/viewtopic.php?f=2t=13230). Thats good news. So I'll let this pass and I'll not invest any time into working around it. I think conversion -version is a correct way to check whether ImageMagick is installed. autoconf contains a macro AC_PATH_PROG that checks the existence of the executable But there is no predefined macro as far as I can see that checks whether a particular version is installed Every program reports its version in a different format, so there is no standard way of checking for a version. At least no way that would work on different Linux distributions, let alone different Unix versions. However I haven't been able to figure out what to do with the IMAGIC variable. It seems indeed unused elsewhere. I'll try to figure that out next Don't bother.. it realy isn't used anywhere else. There's only the check and the output in configure.ac which is translated by autoconf into the configure script. But if we ever decide to improve the error handling or even decide to change the code according to autoconf's findings, it's good to know that we should be able to rely on convert -version. Thank you very much for the research. cheers -henrik ___ Bug-gnupod mailing list Bug-gnupod@nongnu.org http://lists.nongnu.org/mailman/listinfo/bug-gnupod
Re: [Bug-gnupod] artwork support apparently (but not really) broken on ubuntu
Hello Henrik, The behaviour is not intended as you so nicely put it. It is/was a bug and has been corrected in the 6.4.9-9 version. From the ChangeLog: 2009-03-01 6.4.9-9 Cristy quetzlzacatena...@image... * Convert returns MagickFalse for the -version option (reference http://www.imagemagick.org/discourse-server/viewtopic.php?f=2t=13230). I think conversion -version is a correct way to check whether ImageMagick is installed. autoconf contains a macro AC_PATH_PROG that checks the existence of the executable But there is no predefined macro as far as I can see that checks whether a particular version is installed However I haven't been able to figure out what to do with the IMAGIC variable. It seems indeed unused elsewhere. I'll try to figure that out next a+ chriss ___ Bug-gnupod mailing list Bug-gnupod@nongnu.org http://lists.nongnu.org/mailman/listinfo/bug-gnupod
[Bug-gnupod] artwork support apparently (but not really) broken on ubuntu
GNUpod's configure script tries to run convert --version and checks the returncode to determine if convert from imagemagick is installed. This (accidentially) works as convert accepts --version eventhough the correct option would be -version. On Debian both commands return with 0, which for configure means OK. $ convert -version ; echo $? Version: ImageMagick 6.3.7 12/10/08 Q16 http://www.imagemagick.org Copyright: Copyright (C) 1999-2008 ImageMagick Studio LLC 0 $ convert --version ; echo $? Version: ImageMagick 6.3.7 12/10/08 Q16 http://www.imagemagick.org Copyright: Copyright (C) 1999-2008 ImageMagick Studio LLC 0 Apparently imagemagick 6.4 on ubuntu 9.04 prefers not to be detected that way. Eventhough this version also accepts --version and -version, the return code in both cases is 1. u...@user-desktop:~/idm$ convert -version ; echo $? Version: ImageMagick 6.4.5 2009-01-22 Q16 OpenMP http://www.imagemagick.org Copyright: Copyright (C) 1999-2008 ImageMagick Studio LLC 1 u...@user-desktop:~/idm$ convert --version ; echo $? Version: ImageMagick 6.4.5 2009-01-22 Q16 OpenMP http://www.imagemagick.org Copyright: Copyright (C) 1999-2008 ImageMagick Studio LLC 1 This leads configure to the assumption that something is broken and therefore artwork would not work. But as far as I've looked into the code, this finding is not used anywhere in the code. So artwork operations will still be tried and will work as long as imagemagick is installed. Somebody should get in touch with the imagemagic developers and try to find out if that is intended behavior or just an oversight. Volunteers? cheers -henrik ___ Bug-gnupod mailing list Bug-gnupod@nongnu.org http://lists.nongnu.org/mailman/listinfo/bug-gnupod
Re: [Bug-gnupod] artwork support apparently (but not really) broken on ubuntu
Henrik, I'll contact them When you say 'this finding is not used anywhere' what doe you mean with this finding? The return code or the version? Chriss H. Langos wrote: GNUpod's configure script tries to run convert --version and checks the returncode to determine if convert from imagemagick is installed. This (accidentially) works as convert accepts --version eventhough the correct option would be -version. On Debian both commands return with 0, which for configure means OK. $ convert -version ; echo $? Version: ImageMagick 6.3.7 12/10/08 Q16 http://www.imagemagick.org Copyright: Copyright (C) 1999-2008 ImageMagick Studio LLC 0 $ convert --version ; echo $? Version: ImageMagick 6.3.7 12/10/08 Q16 http://www.imagemagick.org Copyright: Copyright (C) 1999-2008 ImageMagick Studio LLC 0 Apparently imagemagick 6.4 on ubuntu 9.04 prefers not to be detected that way. Eventhough this version also accepts --version and -version, the return code in both cases is 1. u...@user-desktop:~/idm$ convert -version ; echo $? Version: ImageMagick 6.4.5 2009-01-22 Q16 OpenMP http://www.imagemagick.org Copyright: Copyright (C) 1999-2008 ImageMagick Studio LLC 1 u...@user-desktop:~/idm$ convert --version ; echo $? Version: ImageMagick 6.4.5 2009-01-22 Q16 OpenMP http://www.imagemagick.org Copyright: Copyright (C) 1999-2008 ImageMagick Studio LLC 1 This leads configure to the assumption that something is broken and therefore artwork would not work. But as far as I've looked into the code, this finding is not used anywhere in the code. So artwork operations will still be tried and will work as long as imagemagick is installed. Somebody should get in touch with the imagemagic developers and try to find out if that is intended behavior or just an oversight. Volunteers? cheers -henrik ___ Bug-gnupod mailing list Bug-gnupod@nongnu.org http://lists.nongnu.org/mailman/listinfo/bug-gnupod ___ Bug-gnupod mailing list Bug-gnupod@nongnu.org http://lists.nongnu.org/mailman/listinfo/bug-gnupod
Re: [Bug-gnupod] artwork support apparently (but not really) broken on ubuntu
Hi Chris, On Tue, Jun 30, 2009 at 11:08:58PM +0200, chris.com wrote: H. Langos wrote: GNUpod's configure script tries to run convert --version and checks the returncode to determine if convert from imagemagick is installed. This (accidentially) works as convert accepts --version eventhough the correct option would be -version. On Debian both commands return with 0, which for configure means OK. Apparently imagemagick 6.4 on ubuntu 9.04 prefers not to be detected that way. Eventhough this version also accepts --version and -version, the return code in both cases is 1. This leads configure to the assumption that something is broken and therefore artwork would not work. But as far as I've looked into the code, this finding is not used anywhere in the code. So artwork operations will still be tried and will work as long as imagemagick is installed. Somebody should get in touch with the imagemagic developers and try to find out if that is intended behavior or just an oversight. I'll contact them When you say 'this finding is not used anywhere' what doe you mean with this finding? The return code or the version? With this finding I ment configure's assumption that imagemagick was not installed and that gnupod's artwork support would not work, based on the different return code of convert --version. As far as I've traced the gnupod configure script, it only sets the variable IMAGIC to No (ImageMagick is not installed) and the varible IMAGIC is printed at the end of the configure script. No changes in the actual gnupod code are made. No matter if IMAGIC is set to :-) If you are curious here's the configure.ac code: http://git.savannah.gnu.org/cgit/gnupod.git/tree/configure.ac cheers -henrik ___ Bug-gnupod mailing list Bug-gnupod@nongnu.org http://lists.nongnu.org/mailman/listinfo/bug-gnupod
