Re: Once again the NSOutlineView
Gregory, On 2004-02-15 00:35:23 +0100 Gregory John Casamento [EMAIL PROTECTED] wrote: [snip] Perhaps you may want to take over the maintainance this class? If there is noone else to do it right now, I will, yes. In particular as it seems like I was the only app developer who is intensely using this class (or say, who is trying to get most outof it :-) But be aware that I probably do not understand this code much better than you ;-) I wrote NSOutlineView, so please, if you have any questions about why something was done in a particular way, please let me know. I use this class heavily in Gorm. It was, in fact, originally implemented by me so that we could have an outline based view of the class hierarchy in Gorm. That's good to know. Maybe I am going to bother you with some questions later :-) But seriously, I can do it and maybe I should also take some care of NSTableView as NSOutlineView's ancestor. I've come across some strange stuff here too, but didn't dig into it, yet. BTW, who is the originator of those classes? Maybe he can be of some help for understanding the code. Fabien worked on NSTableView mainly, he and I cooperated when I wrote NSOutlineView to make the code more efficient. There is a lot of complex code in both of these classes, so change them with care. My original intent was to get NSOutlineView working for my purposes, in particular dnd and some reloading issues. Of course, I tried (and with possible further changes will try) to not break any existing code. Concerning the maintenance of those classes (or NSOutlineView in particular) I am quite indifferent. If there is need for a maintainer I can do it, if there is already one, I don't see a reason for a change. I think, we only have to agree on who is going to responsible for this. Cheers, Andreas -- Andreas Heppel Mail: aheppel at web dot de Home: http://www.andreasheppel.de Check out Burn.app - the CD burning frontend for GNUstep http://gsburn.sourceforge.net ___ Bug-gnustep mailing list [EMAIL PROTECTED] http://mail.gnu.org/mailman/listinfo/bug-gnustep
Re: Once again the NSOutlineView
Hi Fred, On 2004-02-14 14:11:51 +0100 Fred Kiefer [EMAIL PROTECTED] wrote: I did (hopefully) resolve this problem in a different way, by removing the helper method and inlining the code into reloadItem:reloadChildren:. This allowed for a few more corrections/simplifications (and would allow for more, if I only would understand better, what this method should do). I must admit, that NSOutlineView is a part of GUI, where I don't understand most of the code. No idea, for example, why it replaces the item with NULL, if it is nil. I just had a look at what you checked in two days ago. Seems ok to me, but a part of my patch is missing, and I wonder why. At the end of the reloadItem... method I updated _items and _levelOfItems to ensure that those containers reflect the possible change of the item object. Did you just forget this or was something wrong with that part of the patch? Otherwise, thanks a lot for checking this in. Andreas -- Andreas Heppel Mail: aheppel at web dot de Home: http://www.andreasheppel.de Check out Burn.app - the CD burning frontend for GNUstep http://gsburn.sourceforge.net ___ Bug-gnustep mailing list [EMAIL PROTECTED] http://mail.gnu.org/mailman/listinfo/bug-gnustep
Re: Once again the NSOutlineView
Hi Fred, On 2004-02-14 14:11:51 +0100 Fred Kiefer [EMAIL PROTECTED] wrote: I did (hopefully) resolve this problem in a different way, by removing the helper method and inlining the code into reloadItem:reloadChildren:. This allowed for a few more corrections/simplifications (and would allow for more, if I only would understand better, what this method should do). I must admit, that NSOutlineView is a part of GUI, where I don't understand most of the code. No idea, for example, why it replaces the item with NULL, if it is nil. I just had a look at what you checked in two days ago. Seems ok to me, but a part of my patch is missing, and I wonder why. At the end of the reloadItem... method I updated _items and _levelOfItems to ensure that those containers reflect the possible change of the item object. Did you just forget this or was something wrong with that part of the patch? I did forget about that, or rather, I didn't even realize that there was more in the patch. Sorry for that. As I am currently away from home it will take some time until I am able to correct this. Perhaps somebody else will pick up this task? Cheers Fred -- GMX ProMail (250 MB Mailbox, 50 FreeSMS, Virenschutz, 2,99 EUR/Monat...) jetzt 3 Monate GRATIS + 3x DER SPIEGEL +++ http://www.gmx.net/derspiegel +++ ___ Bug-gnustep mailing list [EMAIL PROTECTED] http://mail.gnu.org/mailman/listinfo/bug-gnustep
Re: Once again the NSOutlineView
Andreas, --- Fred Kiefer [EMAIL PROTECTED] wrote: Hi Fred, On 2004-02-14 14:11:51 +0100 Fred Kiefer [EMAIL PROTECTED] wrote: I did (hopefully) resolve this problem in a different way, by removing the helper method and inlining the code into reloadItem:reloadChildren:. This allowed for a few more corrections/simplifications (and would allow for more, if I only would understand better, what this method should do). I must admit, that NSOutlineView is a part of GUI, where I don't understand most of the code. No idea, for example, why it replaces the item with NULL, if it is nil. I just had a look at what you checked in two days ago. Seems ok to me, but a part of my patch is missing, and I wonder why. At the end of the reloadItem... method I updated _items and _levelOfItems to ensure that those containers reflect the possible change of the item object. Did you just forget this or was something wrong with that part of the patch? What was the change? I did forget about that, or rather, I didn't even realize that there was more in the patch. Sorry for that. As I am currently away from home it will take some time until I am able to correct this. Perhaps somebody else will pick up this task? I will. Cheers Fred Thanks, GJC = Gregory John Casamento -- CEO/President Open Logic Corp. -- bheron on #gnustep, #linuxstep, #gormtalk Please sign the petition against software patents at: http://www.petitiononline.com/pasp01/petition.html -- Maintainer of Gorm (featured in April Linux Journal) --- __ Do you Yahoo!? Yahoo! Finance: Get your refund fast by filing online. http://taxes.yahoo.com/filing.html ___ Bug-gnustep mailing list [EMAIL PROTECTED] http://mail.gnu.org/mailman/listinfo/bug-gnustep
