[bug #65198] mom/examples/*.txt: change '-k' to '-K utf8'

[G. Branden Robinson]

Update of bug #65198 (group groff):

 Open/Closed:Open => Closed 
 Planned Release:None => 1.24.0 

___

Follow-up Comment #7:


commit e103a6e61c0a7da21b2b211e6b3254730b85acd4
Author: Peter Schaffter 
Date:   Mon Apr 15 15:24:01 2024 -0400

[mom]: Amend examples/README.txt and README-fr.txt

Instruct use of -K utf8 rather than -k to process example files that
contain accented characters.




___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #65198] mom/examples/*.txt: change '-k' to '-K utf8'

[Peter Schaffter]

Update of bug #65198 (group groff):

  Status:None => Fixed  

___

Follow-up Comment #6:


[comment #4 comment #4:]
> Comment #3 appears to misunderstand the point of comment #2: this ticket
doesn't concern
[http://git.savannah.gnu.org/cgit/groff.git/tree/contrib/mom/mom.am
contrib/mom/mom.am] itself, but merely uses that file's build options as a
template for what ought to appear in
[http://git.savannah.gnu.org/cgit/groff.git/tree/contrib/mom/examples/README.txt
contrib/mom/examples/README.txt] (and its
[http://git.savannah.gnu.org/cgit/groff.git/tree/contrib/mom/examples/README-fr.txt
README-fr.txt] counterpart).  That is, it's suggesting changes akin to:

> diff --git a/contrib/mom/examples/README.txt
b/contrib/mom/examples/README.txt
> index 851a9a27a..34e06153c 100644
> --- a/contrib/mom/examples/README.txt
> +++ b/contrib/mom/examples/README.txt
> @@ -21,9 +21,9 @@ files with pdfmom(1).
>  pdfmom mom-pdf.mom > mom-pdf.pdf
>  pdfmom sample_docs.mom > sample_docs.pdf
>  pdfmom slide-demo.mom > slide-demo.pdf
> -pdfmom -k letter.mom > letter.pdf
> -pdfmom -k mon_premier_doc.mom > mon_premier_doc.pdf
> -pdfmom -k typesetting.mom > typesetting.pdf
> +pdfmom -K utf8 letter.mom > letter.pdf
> +pdfmom -K utf8 mon_premier_doc.mom > mon_premier_doc.pdf
> +pdfmom -K utf8 typesetting.mom > typesetting.pdf
>  
>  The files themselves
>  
> @@ -78,8 +78,8 @@ all PDF readers.
>  
>  The file, mon_premier_doc.mom, is a simple example in French showing
>  the use of common elements: section headings, paragraphs, lists, table
> -of contents and clickable links.  It should be generated with option -k
> -as there are some accented letters.
> +of contents and clickable links.  It should be generated with option
> +"-K utf8" as there are some accented letters.
>  
>  A few settings were also changed for this French document:
>  ATTRIBUTE_STRING is used to replace "by" by "par" in the document


> To my eyes, this appears to be a legitimate refinement, as -K is more
reliable than -k for known encodings.  But Peter is in charge of the content
of these files, so I'm reassigning this to him so he can make that call.

I've pushed the changes.  Closing this ticket.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #65099] 1.24.0 release goals

[Dave]

Follow-up Comment #4, bug #65099 (group groff):

I submit bug #63827 as something that should be addressed in some manner
before release, even if only in the form of a stopgap like resyncing groff's
pdfmark subtree with the substantially updated code upstream.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #65198] mom/examples/*.txt: change '-k' to '-K utf8'

[Dave]

Follow-up Comment #5, bug #65198 (group groff):

[comment #0 original submission:]
>   See "https://lists/gnu.org/archive/html/groff/2024-01/msg00106.html";

This URL is malformed and should be
https://lists.gnu.org/archive/html/groff/2024-01/msg00106.html

(A followup, not linked from that URL, is at
http://lists.gnu.org/r/groff/2024-02/msg3.html)

However, it's not clear to me whether/how the reported deficiency in the
Fedora example files is related to the README.txt content, unless Bjarni is
assuming the Fedora packagers build their examples by copy/pasting commands
from README.txt rather than using the included makefiles, which as noted in
comment #1 were updated in 2022.  So this might be an unrelated issue, and one
in the Fedora package rather than in groff.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #65198] mom/examples/*.txt: change '-k' to '-K utf8'

[Dave]

Update of bug #65198 (group groff):

  Status: Invalid => None   
 Assigned to:gbranden => PTPi   
 Open/Closed:  Closed => Open   
 Summary: [bjarnigroff] mom/examples/*.txt: change '-k' to '-K
utf8' => mom/examples/*.txt: change '-k' to '-K utf8'

___

Follow-up Comment #4:

Comment #3 appears to misunderstand the point of comment #2: this ticket
doesn't concern
[http://git.savannah.gnu.org/cgit/groff.git/tree/contrib/mom/mom.am
contrib/mom/mom.am] itself, but merely uses that file's build options as a
template for what ought to appear in
[http://git.savannah.gnu.org/cgit/groff.git/tree/contrib/mom/examples/README.txt
contrib/mom/examples/README.txt] (and its
[http://git.savannah.gnu.org/cgit/groff.git/tree/contrib/mom/examples/README-fr.txt
README-fr.txt] counterpart).  That is, it's suggesting changes akin to:

diff --git a/contrib/mom/examples/README.txt
b/contrib/mom/examples/README.txt
index 851a9a27a..34e06153c 100644
--- a/contrib/mom/examples/README.txt
+++ b/contrib/mom/examples/README.txt
@@ -21,9 +21,9 @@ files with pdfmom(1).
 pdfmom mom-pdf.mom > mom-pdf.pdf
 pdfmom sample_docs.mom > sample_docs.pdf
 pdfmom slide-demo.mom > slide-demo.pdf
-pdfmom -k letter.mom > letter.pdf
-pdfmom -k mon_premier_doc.mom > mon_premier_doc.pdf
-pdfmom -k typesetting.mom > typesetting.pdf
+pdfmom -K utf8 letter.mom > letter.pdf
+pdfmom -K utf8 mon_premier_doc.mom > mon_premier_doc.pdf
+pdfmom -K utf8 typesetting.mom > typesetting.pdf
 
 The files themselves
 
@@ -78,8 +78,8 @@ all PDF readers.
 
 The file, mon_premier_doc.mom, is a simple example in French showing
 the use of common elements: section headings, paragraphs, lists, table
-of contents and clickable links.  It should be generated with option -k
-as there are some accented letters.
+of contents and clickable links.  It should be generated with option
+"-K utf8" as there are some accented letters.
 
 A few settings were also changed for this French document:
 ATTRIBUTE_STRING is used to replace "by" by "par" in the document

To my eyes, this appears to be a legitimate refinement, as -K is more reliable
than -k for known encodings.  But Peter is in charge of the content of these
files, so I'm reassigning this to him so he can make that call.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #63354] Refine fallbacks.tmac

[Dave]

Follow-up Comment #37, bug #63354 (group groff):

(Of course, for fallback usage the .char in comment #35 and comment #36 should
be .fchar.)


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #63354] Refine fallbacks.tmac

[Dave]

Follow-up Comment #36, bug #63354 (group groff):

Maybe comment #34 and comment #35 are overthinking this.

The requirement for U+2012 is that it occupy the same horizontal space as a
figure.  There is no requirement on the width of the mark itself.

So what if the fallback simply uses the font's hyphen centered within a
figure's width?

.  char \[u2012] \o\# Overstrike...
'-\#  a hyphen and...
\h\#  a horizontal space...
^\w'0'u^'\"   the width of a zero.

This removes all considerations of generating a horizontal line at the same
height as the font's existing hyphens and dashes.  It solves the second and
third of the "potential implementation issues" comment #35 raises.  (I still
see no way around the first, but the current fallbacks.tmac \[u2012] already
has this drawback.)

It might even be simple enough that the internal commenting is overkill:

.  \" Overstrike a hyphen and a horizontal space the width of a zero.
.  char \[u2012] \o'-\h^\w'0'u^'




___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/